Received-SPF: pass (google.com: domain of linux-kernel+bounces-94702-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 7 Mar 2024 00:19:29 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Raju.Lakkaraju@microchip.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
	linux-kernel@vger.kernel.org, Bryan.Whitehead@microchip.com,
	richardcochran@gmail.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net 3/3] net: lan743x: Address problems with wake option
 flags configuration sequences
Message-ID: <70b01df1-d651-4f6b-a7fc-8e16c18c6e32@lunn.ch>
References: <20240226080934.46003-1-Raju.Lakkaraju@microchip.com>
 <20240226080934.46003-4-Raju.Lakkaraju@microchip.com>
 <b83b74b7-3221-4747-8b71-17738c18c042@lunn.ch>
 <LV8PR11MB8700C2F9461F4200431446D49F5F2@LV8PR11MB8700.namprd11.prod.outlook.com>
 <e038ec4e-c54d-4628-8997-90510c0d96ab@lunn.ch>
 <LV8PR11MB8700FC048AB32D6E7168855E9F5E2@LV8PR11MB8700.namprd11.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <LV8PR11MB8700FC048AB32D6E7168855E9F5E2@LV8PR11MB8700.namprd11.prod.outlook.com>

> I'm not able to find  any more "ethtool" documentations other than ethtool man page.
> 
> I have gone through the ethtool application code.
> (git://git.kernel.org/pub/scm/network/ethtool/ethtool.git) and check the WOL options.
> 
> In ioctl method (Not netlink), do_sset( ) function, before set the parameters, first get the WOL configuration.
> (i.e. in ethtool.c file, Line no. 3294)
> 
> Then, assign/overwrite WOL wanted config to wolopts parameter.

Thanks for documenting all this. So it does seem like wol options
overwrite, rather than add incrementally. So i would say the correct
'fix' here is to document that in the man page, because at the moment
it is not clear what should happen.

Now i need to go back and look at what your original issue was...

	Andrew