Received-SPF: pass (google.com: domain of linux-kernel+bounces-94745-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: <Woojung.Huh@microchip.com>
To: <Parthiban.Veerasooran@microchip.com>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<horms@kernel.org>, <saeedm@nvidia.com>, <anthony.l.nguyen@intel.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <andrew@lunn.ch>,
	<corbet@lwn.net>, <linux-doc@vger.kernel.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <Horatiu.Vultur@microchip.com>,
	<ruanjinjie@huawei.com>, <Steen.Hegelund@microchip.com>,
	<vladimir.oltean@nxp.com>
CC: <UNGLinuxDriver@microchip.com>, <Thorsten.Kummermehr@microchip.com>,
	<Pier.Beruto@onsemi.com>, <Selvamani.Rajagopal@onsemi.com>,
	<Nicolas.Ferre@microchip.com>, <benjamin.bigler@bernformulastudent.ch>
Subject: RE: [PATCH net-next v3 11/12] microchip: lan865x: add driver support
 for Microchip's LAN865X MAC-PHY
Thread-Topic: [PATCH net-next v3 11/12] microchip: lan865x: add driver support
 for Microchip's LAN865X MAC-PHY
Thread-Index: AQHab6OpOH9fv+fH6UiUBHGHSCgdN7ErYJiQ
Date: Wed, 6 Mar 2024 23:44:58 +0000
Message-ID: <BL0PR11MB29133BBDC826A8B79F59FEB1E7212@BL0PR11MB2913.namprd11.prod.outlook.com>
References: <20240306085017.21731-1-Parthiban.Veerasooran@microchip.com>
 <20240306085017.21731-12-Parthiban.Veerasooran@microchip.com>
In-Reply-To: <20240306085017.21731-12-Parthiban.Veerasooran@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pMJZZl0Gr/7q60cfczeb7Qh+CWNvv6mBs+jScAbHNV018mh4ekG1qZpwJIeU?=
 =?us-ascii?Q?kwCXjHuX3WHn8qY3/S+Km+t7ePvAWWupYdNvWC4A8wEg0ykO2rj/uposi12/?=
 =?us-ascii?Q?qCEu+CUadDMaWisc4zhy4Rhx5LrTwjJ5eRkonUVb6IiIiBTQ8KtPGCF8vLn6?=
 =?us-ascii?Q?X4SMMQ2djzRDwNNGX2coVeEX8SjwBQMoJiNNb/L/SleBS36oUWz1zrwYJ5mX?=
 =?us-ascii?Q?dY57Pb6eNKokAxMtX6h1UzPG3aaTE3qwy/wjZ5o6/UOclCypm+PLmml4F2oB?=
 =?us-ascii?Q?NXZotfzfqkaWN1RQHUJduxSs284TS92wo0bhIAViMjPXkRjPWSBWUeSIhNG5?=
 =?us-ascii?Q?Pcqs7GdwyQpIqEC7dt57WdVzahaFoNOQP6U5aJh15EtErst3uhLXK3tAjkVz?=
 =?us-ascii?Q?Ur9lIA1TbATbEAw9lFsUgYpiM8stDGHy8IS0HXYxUruxwlch9Di/U+/bJ+Jk?=
 =?us-ascii?Q?kJYC9gTCal606QnzddgUntmfw3i+ppufo/0yqaFUbFAKF4aLg0wdVT0EGAQN?=
 =?us-ascii?Q?QB7SOaTbqvL6KqZ/wZ/f84gpDFTds3RWCyGsXjMsR3EnS++VCM3EmUk+NdJw?=
 =?us-ascii?Q?Bdz07T+3e32+ehIqZCp48NCFPye+mO1aaS6xrCSdqAqunP5ukdvI2oiTv9DJ?=
 =?us-ascii?Q?pYRA0QQ+W41IkD7Z7D3oFIQr6sihJsim8/u70E4AlU7cpZOS1m6d4UMg91hB?=
 =?us-ascii?Q?p5k68zj+1Yq2lJgr10rJV+kYTWiI48guidur/GAQ0exJpvzGToST8OXqw23V?=
 =?us-ascii?Q?vHdoxWYswM23baSu+JRhjtzqCN16Vx0OSrsezwTw9lhhyZL14nUd5CfqGxQz?=
 =?us-ascii?Q?UyfaBKGm5iA/WIS3Tblzqyr3cp+xjL6urk3o6hiidxGu7lFpIr3t0VV+ssXY?=
 =?us-ascii?Q?maJbVmaaRnaWGjiCO7iPvUoCf+KR6+fPcT7tF+pDAom0Gx99MP5ti0ta54Iw?=
 =?us-ascii?Q?gPl+jZbIkc7gulZdOO2uzx8YQyWv01xZqAzUPIqhP1BwOxfkWpdBh3Hth/uK?=
 =?us-ascii?Q?jmati4Nb1zvoogD041NEfTNf/4Xyjs7No32N8j9mYUaeF+ASHQWRpJ3XZdya?=
 =?us-ascii?Q?x4sbS6x2gAdQh4s8aqftDWJtzzzJGlTO/IPMFq0Bx0XRR/beNXuOXKARJ4vn?=
 =?us-ascii?Q?yQTaabFMNJBqnkVkrxu4hgwVfiDUdRHco+BFFhKXxO22mBM40o14f/WqTKUB?=
 =?us-ascii?Q?4sL6Cc4yLKleSWnSY0NiSXJiugphIP6GHTllvNmauFWxszATNH13cGv/87m7?=
 =?us-ascii?Q?vOh6gjeJ/V4odsfjmSZjWJcnVQ/lrRLBryl/Qv5zZ01clU866QCg2/+TAsO7?=
 =?us-ascii?Q?RuNgUS+66xgdB0cZ/kytRMxVX/QX88pVgeV0V0KWUZJ8WCmg8QzB7B8vP6e/?=
 =?us-ascii?Q?tITw8/xrMjLg6HOdOR/7WTudY0kIaUakYkydhMHBp5DZw2hCXyh8cD3oUDzg?=
 =?us-ascii?Q?Y0NKy6foaZ4JEc8vHUnnXLo7kOG0p/UL+I84MTB3/rj5egXCYX9N0iamKaUN?=
 =?us-ascii?Q?sRCC0LhSO+b7aDa5+2RjLph1w6xkClcEGNZ5ydBYbRxDOaC0h0t0G4WgRXbk?=
 =?us-ascii?Q?YxMr7NbKr1E6amC4Mu/F5lDA38mgZ1Y1eT/0KUCO?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB2913.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1702a8b2-357e-4854-1489-08dc3e376f2d
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2024 23:44:58.8590
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FeRyZ77ZV57Hn244y1QBakrwHT8bbdcmsbf6FWKCA9U1MEzxA/DPH0guOHfkKF3bE2/aGl/jlfIaag+1Owgm2nYxRz0gwKNSNDX+30S+l+s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4598

Hi Parthiban,

> diff --git a/drivers/net/ethernet/microchip/lan865x/lan865x.c
> b/drivers/net/ethernet/microchip/lan865x/lan865x.c
..
> +static void lan865x_multicast_work_handler(struct work_struct *work)
> +{
> +	struct lan865x_priv *priv =3D container_of(work, struct lan865x_priv,
> +						 multicast_work);
> +	u32 regval =3D 0;
> +
> +	if (priv->netdev->flags & IFF_PROMISC) {
> +		/* Enabling promiscuous mode */
> +		regval |=3D MAC_NET_CFG_PROMISCUOUS_MODE;
> +		regval &=3D (~MAC_NET_CFG_MULTICAST_MODE);
> +		regval &=3D (~MAC_NET_CFG_UNICAST_MODE);
> +	} else if (priv->netdev->flags & IFF_ALLMULTI) {
> +		/* Enabling all multicast mode */
> +		regval &=3D (~MAC_NET_CFG_PROMISCUOUS_MODE);
> +		regval |=3D MAC_NET_CFG_MULTICAST_MODE;
> +		regval &=3D (~MAC_NET_CFG_UNICAST_MODE);
> +	} else if (!netdev_mc_empty(priv->netdev)) {
> +		lan865x_set_specific_multicast_addr(priv->netdev);
> +		regval &=3D (~MAC_NET_CFG_PROMISCUOUS_MODE);
> +		regval &=3D (~MAC_NET_CFG_MULTICAST_MODE);
> +		regval |=3D MAC_NET_CFG_UNICAST_MODE;
> +	} else {
> +		/* enabling local mac address only */
> +		if (oa_tc6_write_register(priv->tc6, LAN865X_REG_MAC_H_HASH,
> +					  regval)) {

Your intention to write 0 into LAN865X_REG_MAC_H_HASH?
If then, using 0 than regval makes more clear.

> +			netdev_err(priv->netdev, "Failed to write reg_hashh");
> +			return;
> +		}
> +		if (oa_tc6_write_register(priv->tc6, LAN865X_REG_MAC_L_HASH,
> +					  regval)) {

Same here.

> +			netdev_err(priv->netdev, "Failed to write reg_hashl");
> +			return;
> +		}
> +	}
> +	if (oa_tc6_write_register(priv->tc6, LAN865X_REG_MAC_NET_CFG,
> regval))
> +		netdev_err(priv->netdev,
> +			   "Failed to enable promiscuous/multicast/normal mode");
> +}
> +