Received-SPF: pass (google.com: domain of linux-kernel+bounces-94768-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 7 Mar 2024 11:07:17 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jan Kara <jack@suse.cz>
Cc: Winston Wen <wentao@uniontech.com>, Linux Kernel Mailing List
 <linux-kernel@vger.kernel.org>, Linux Next Mailing List
 <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the ext3 tree
Message-ID: <20240307110717.50b64fe9@canb.auug.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/YV2kPiMrovNC6.nKsM.9alL";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/YV2kPiMrovNC6.nKsM.9alL
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

After merging the ext3 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/sysctl.h:27,
                 from include/linux/fanotify.h:5,
                 from fs/notify/fanotify/fanotify.c:2:
fs/notify/fanotify/fanotify.c: In function 'fanotify_get_response':
fs/notify/fanotify/fanotify.c:233:48: error: suggest parentheses around ari=
thmetic in operand of '|' [-Werror=3Dparentheses]
  233 |                                   TASK_KILLABLE|TASK_FREEZABLE);
      |                                                ^
include/linux/wait.h:283:11: note: in definition of macro '___wait_is_inter=
ruptible'
  283 |          (state & (TASK_INTERRUPTIBLE | TASK_WAKEKILL)))
      |           ^~~~~
include/linux/wait.h:935:9: note: in expansion of macro '___wait_event'
  935 |         ___wait_event(wq, condition, state, 0, 0, schedule())
      |         ^~~~~~~~~~~~~
include/linux/wait.h:958:25: note: in expansion of macro '__wait_event_stat=
e'
  958 |                 __ret =3D __wait_event_state(wq_head, condition, st=
ate);          \
      |                         ^~~~~~~~~~~~~~~~~~
fs/notify/fanotify/fanotify.c:231:15: note: in expansion of macro 'wait_eve=
nt_state'
  231 |         ret =3D wait_event_state(group->fanotify_data.access_waitq,
      |               ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  3440e7e55ced ("fanotify: allow freeze when waiting response for permissio=
n events")

Though, I guess, you could argue that the ___wait_is_interruptible macro
should parenthesise the use of its "state" argument.

I have used the ext3 tree from next-20240306 for today.

--=20
Cheers,
Stephen Rothwell

--Sig_/YV2kPiMrovNC6.nKsM.9alL
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmXpBTUACgkQAVBC80lX
0GyIJgf9EiEsM3leOBeFVLdvpuIv3h7+e66I/TcA2ap4Olkbu4nJq/xLWNjzKBxJ
AB9+3MLZP51VbsYwaugAPaNwusYakvrLGf3Fywp8tUoMC+xgsc45CTxuHEeB4Aio
Zj6Qdg4nSOQImUOz6ZJ22sTEs7K9gOHG4PP9L/nG+ztFiH3PsUzl++ZzctOmFHmF
g9xuVGMzwu4CQ+mhnPwbejMqCjIt3lCjHFEMMiYAafqPXzUD6dScyKMdWA9fp/Qe
1Q14JefgecpzfmUFZv7jezwTRMzZP8GS22Ri5V7p4CEuq9/2hdfTeTaD8KFjfCkP
zEQugtbf66R5KxWngQd+vj9Wb1Smww==
=F2PT
-----END PGP SIGNATURE-----

--Sig_/YV2kPiMrovNC6.nKsM.9alL--