Received-SPF: pass (google.com: domain of linux-kernel+bounces-94776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1703596577.git.u.kleine-koenig@pengutronix.de>
 <4a97c8e6996c9c95244715310b57ce5af6ccb1ad.1703596577.git.u.kleine-koenig@pengutronix.de>
 <dfw3rfgifkv5qliwzxlziwq5kvud4vdro36v22celda6wasy2d@fpcpgcuo22bo>
In-Reply-To: <dfw3rfgifkv5qliwzxlziwq5kvud4vdro36v22celda6wasy2d@fpcpgcuo22bo>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Thu, 7 Mar 2024 01:20:33 +0100
Message-ID: <CAMj1kXE+T_puAegyDaBrXo-zUPJ4dJ8DWXq=1Ji4ZLMaM51Yrg@mail.gmail.com>
Subject: Re: [PATCH 1/2] virt: efi_secret: Convert to platform remove callback
 returning void
To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Dov Murik <dovmurik@linux.ibm.com>, Dan Williams <dan.j.williams@intel.com>, 
	Gerd Hoffmann <kraxel@redhat.com>, kernel@pengutronix.de, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 6 Mar 2024 at 22:35, Uwe Kleine-K=C3=B6nig
<u.kleine-koenig@pengutronix.de> wrote:
>
> Hello,
>
> On Tue, Dec 26, 2023 at 02:28:02PM +0100, Uwe Kleine-K=C3=B6nig wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling b=
y
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> >
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> >
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> >
> > Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
>
> Is this patch still on someone's radar? If a resend would help, please
> tell me.
>

I've queued this up in the EFI tree.

Thanks,