Received-SPF: pass (google.com: domain of linux-kernel+bounces-94783-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1709288671.git.isaku.yamahata@intel.com>
 <66a957f4ec4a8591d2ff2550686e361ec648b308.1709288671.git.isaku.yamahata@intel.com>
 <ZekKwlLdf6vm5e5u@google.com>
In-Reply-To: <ZekKwlLdf6vm5e5u@google.com>
From: David Matlack <dmatlack@google.com>
Date: Wed, 6 Mar 2024 16:36:25 -0800
Message-ID: <CALzav=dHNYP02q_CJncwk-JdL9OSB=613v4+siBm1Cp2rmxLLw@mail.gmail.com>
Subject: Re: [RFC PATCH 6/8] KVM: x86: Implement kvm_arch_{, pre_}vcpu_map_memory()
To: isaku.yamahata@intel.com
Cc: kvm@vger.kernel.org, isaku.yamahata@gmail.com, 
	linux-kernel@vger.kernel.org, Sean Christopherson <seanjc@google.com>, 
	Paolo Bonzini <pbonzini@redhat.com>, Michael Roth <michael.roth@amd.com>, 
	Federico Parola <federico.parola@polito.it>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 6, 2024 at 4:31=E2=80=AFPM David Matlack <dmatlack@google.com> =
wrote:
>
> On 2024-03-01 09:28 AM, isaku.yamahata@intel.com wrote:
> >
> > +     if (IS_ALIGNED(mapping->base_gfn, KVM_PAGES_PER_HPAGE(PG_LEVEL_1G=
)) &&
> > +         mapping->nr_pages >=3D KVM_PAGES_PER_HPAGE(PG_LEVEL_1G))
> > +             max_level =3D PG_LEVEL_1G;
> > +     else if (IS_ALIGNED(mapping->base_gfn, KVM_PAGES_PER_HPAGE(PG_LEV=
EL_2M)) &&
> > +              mapping->nr_pages >=3D KVM_PAGES_PER_HPAGE(PG_LEVEL_2M))
> > +             max_level =3D PG_LEVEL_2M;
> > +     else
> > +             max_level =3D PG_LEVEL_4K;
>
> Is there a requirement that KVM must not map memory outside of the
> requested region?

And if so, what if the requested region is already mapped with a larger pag=
e?