Received: by 2002:ab2:788f:0:b0:1ee:8f2e:70ae with SMTP id b15csp255459lqi; Wed, 6 Mar 2024 16:43:51 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVsdw4Ivmy0l5G0QUSlvEh1D+4pfXE4yuh+2Ea8cBpsPzv4Zkekvit1PL41WtgOGz1LlyRkmVm//23Nlqt8xEj0fRZz4Gs1g6qrZxZokQ== X-Google-Smtp-Source: AGHT+IFsB1R2QXOpx0LhIIUKQhzUQtaVo+yUDZuIU49hX6SkWRnOb75RAb434dDCorOGCdvhcp6O X-Received: by 2002:a05:6214:284:b0:690:9a03:83b9 with SMTP id l4-20020a056214028400b006909a0383b9mr2505753qvv.43.1709772231017; Wed, 06 Mar 2024 16:43:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709772231; cv=pass; d=google.com; s=arc-20160816; b=KMAVRi+qVeW1fQTdrHehRvrxSDE64O+y9AHDd6Oeilke2eqQKaDelVlVppqtIHmLSH BosyBRJ8tezSj/ZJOZ8L3U1EcXOs/XEnY/RIqLtDVEmkkn2JGDUZIJlARFKg16mo8u+Q c32IcKFpSOxu/LOjaKGcnp1oIpi9V7gfxhaW+zuWstv2RLrcm4Pz4+e/dZ22ycnrV8an itrrzPQaQ1rhkesHFMDHhozZ9LLEg6r62alrmBG4AMf/IhFdQ/g+VJdbEq7rky5lMMk6 5mX8JCtcL9WmqZOQd8FW/f7tTrky8/gZ5s9SVjQ9D3Aud/zJjSPWkJSDMHwky2xYrO/Y gwkw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wzCCuxsPBHXyXjRm5k2orXDzl3Uzi7tXXzCApNzY6Cs=; fh=iT69aLAFCaAL1ECVELFGqnZRVt9iikoJcvzeKR1Ry4g=; b=niRJgd5Nr1x1jGupujTgRO830R8q+e2jKZ/HfAnlTfEjsoHvelP1AU7Hv8ytSkC5VB VI0Rto/GZM3JSF41NeHT8u+NlnhJsB4FKtnDIuT/JViSbFtkbvLLA0S1GVvCKmWuKSgz wMqUlS4jmSnu6RBgHjHya7FdC8CS1KRbpKyosh35JItEwKRQH72ayUCSxPgNC3YvUdE5 CUs+Kdf/X3sDARZI0sQmjj7TSxpZbuhR5guefi4jl1i15srY8GEcYUJx6kS22NYtOBuH lNR3wF8Renf2v2qsPu9njS5RQUCc80/RetoPZoqYAczJOBaQf4s1YQ9eRDzQo2Kg4TJ6 wAsA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=hoTrwCOd; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-94787-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94787-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id r8-20020a056214212800b006907928dc20si8092814qvc.550.2024.03.06.16.43.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 16:43:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-94787-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=hoTrwCOd; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-94787-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-94787-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A6B1E1C21DF7 for ; Thu, 7 Mar 2024 00:43:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D37DE4A21; Thu, 7 Mar 2024 00:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="hoTrwCOd" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55C4B4C61; Thu, 7 Mar 2024 00:43:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709772220; cv=none; b=SlIyeStSi47nSQxe8laz5MBvaStGk9etTvMRZy2+T4teWQPgaCAlLnAaB429RUHrfAx+cXFOwZWnkaB+0+Sa6C9n+cR9nrXtKl+ClXhk2JSjui8Sg05kYw8GXAWuYJkiVcIex1eJvyVz4ffwSsBp9bwj9Dcf47iurVHN7POP3z4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709772220; c=relaxed/simple; bh=kICLgy5fS3zt0bLA8x8it0pE/DQMWVqNdsaAekk7NzI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sYSv2WmKlBVJN4Em3gom0wvMN7GUADMDHILpfDUI6l6XHkj528g9MoqXUoVCvdYgj0xtz1f+lsc63NKaiobacKyLQ/KLhmlbtXBsOOV2MwW+x2Bk4RaN4AIXqpCQqEDN0frlXwZbW1jy0+oNUvNZ8vak60l6Z61PnJQXqXIDovA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=hoTrwCOd; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=wzCCuxsPBHXyXjRm5k2orXDzl3Uzi7tXXzCApNzY6Cs=; b=hoTrwCOdOWG9dzlrFUXg7GpQ2E abQbgLeREA0rh6a2A4JZHI3yI9dyJtPUqiNfONa5MERXDSrnO3VUCwdsQOoYQE8i1AkGqlDPW9Xxz BeInsjquEol0rJObi8PNjrDre/BAK7QmsBVfQsKAzQ1uQnHcr+aGyKFFRuBGaWaUGB6U=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ri1rX-009XnQ-IA; Thu, 07 Mar 2024 01:43:55 +0100 Date: Thu, 7 Mar 2024 01:43:55 +0100 From: Andrew Lunn To: Parthiban Veerasooran Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, saeedm@nvidia.com, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, horatiu.vultur@microchip.com, ruanjinjie@huawei.com, steen.hegelund@microchip.com, vladimir.oltean@nxp.com, UNGLinuxDriver@microchip.com, Thorsten.Kummermehr@microchip.com, Pier.Beruto@onsemi.com, Selvamani.Rajagopal@onsemi.com, Nicolas.Ferre@microchip.com, benjamin.bigler@bernformulastudent.ch Subject: Re: [PATCH net-next v3 05/12] net: ethernet: oa_tc6: implement error interrupts unmasking Message-ID: References: <20240306085017.21731-1-Parthiban.Veerasooran@microchip.com> <20240306085017.21731-6-Parthiban.Veerasooran@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240306085017.21731-6-Parthiban.Veerasooran@microchip.com> On Wed, Mar 06, 2024 at 02:20:10PM +0530, Parthiban Veerasooran wrote: > This will unmask the following error interrupts from the MAC-PHY. > tx protocol error > rx buffer overflow error > loss of frame error The standard seems to call it "Loss of framing". To me as a network person, a frame is an L2 Ethernet packet. However, framing is something completely different, being able to synchronise a bitstream with some sort of markers, e.g. E1 to know where the 32 slots are. In this context, we are not talking about packets, but the SPI bit stream. So it would be good to use framing, not frame. Andrew