Received-SPF: pass (google.com: domain of linux-kernel+bounces-94845-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <1096418c-7657-4d38-8344-bf6cf3c1b8bb@linux.alibaba.com>
Date: Thu, 7 Mar 2024 10:02:20 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] erofs: apply proper VMA alignment for memory mapped files
 on THP
To: Chao Yu <chao@kernel.org>, linux-erofs@lists.ozlabs.org
Cc: LKML <linux-kernel@vger.kernel.org>
References: <20240306053138.2240206-1-hsiangkao@linux.alibaba.com>
 <30300dc7-3063-4e09-bb21-22951ec23a38@linux.alibaba.com>
 <b3601f0d-c315-4763-bbab-4174fe0af713@kernel.org>
From: Gao Xiang <hsiangkao@linux.alibaba.com>
In-Reply-To: <b3601f0d-c315-4763-bbab-4174fe0af713@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2024/3/7 09:07, Chao Yu wrote:
> On 2024/3/6 14:51, Gao Xiang wrote:
>>
>>
>> On 2024/3/6 13:31, Gao Xiang wrote:
>>> There are mainly two reasons that thp_get_unmapped_area() should be
>>> used for EROFS as other filesystems:
>>>
>>>   - It's needed to enable PMD mappings as a FSDAX filesystem, see
>>>     commit 74d2fad1334d ("thp, dax: add thp_get_unmapped_area for pmd
>>>     mappings");
>>>
>>>   - It's useful together with CONFIG_READ_ONLY_THP_FOR_FS which enables
>>>     THPs for read-only mmapped files (e.g. shared libraries) even without
>>>     FSDAX.  See commit 1854bc6e2420 ("mm/readahead: Align file mappings
>>>     for non-DAX").
>>
>> Refine this part as
>>
>>   - It's useful together with large folios and CONFIG_READ_ONLY_THP_FOR_FS
>>     which enable THPs for mmapped files (e.g. shared libraries) even without
>>     ...
>>
>>>
>>> Fixes: 06252e9ce05b ("erofs: dax support for non-tailpacking regular file")
>>
>> Fixes: ce529cc25b18 ("erofs: enable large folios for iomap mode")
>> Fixes: be62c5198861 ("erofs: enable large folios for fscache mode")
>>
>>> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> 
> Reviewed-by: Chao Yu <chao@kernel.org>

Thanks, added!

Thanks,
Gao Xiang

> 
> Thanks,