Received-SPF: pass (google.com: domain of linux-kernel+bounces-94881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <f3624f39-bbb1-451d-8161-8518e4108d8e@joelfernandes.org>
 <tencent_9882B228F292088CDD68F10CF1C228742009@qq.com> <20240306103719.1d241b93@gandalf.local.home>
 <27665890-8314-4252-8622-1e019fee27e4@paulmck-laptop> <20240306130103.6da71ddf@gandalf.local.home>
 <CAHk-=wgG6Dmt1JTXDbrbXh_6s2yLjL=9pHo7uv0==LHFD+aBtg@mail.gmail.com>
 <20240306135504.2b3872ef@gandalf.local.home> <CAHk-=wjbDgMKLgxbV+yK4LKZ+2Qj6zVL_sHeb+L9KDia980Q8Q@mail.gmail.com>
 <20240306142738.7b66a716@rorschach.local.home> <CAHk-=wgPAZ4KnCQergqAOUypwinYh=gZ0q4EQbwvuUcJ_8UK+Q@mail.gmail.com>
 <83b47424-e5e0-46de-aa63-d413a5aa6cec@paulmck-laptop>
In-Reply-To: <83b47424-e5e0-46de-aa63-d413a5aa6cec@paulmck-laptop>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed, 6 Mar 2024 18:43:42 -0800
Message-ID: <CAHk-=wiX_zF5Mpt8kUm_LFQpYY-mshrXJPOe+wKNwiVhEUcU9g@mail.gmail.com>
Subject: Re: [PATCH] rcutorture: Fix rcu_torture_pipe_update_one()/rcu_torture_writer()
 data race and concurrency bug
To: paulmck@kernel.org
Cc: Steven Rostedt <rostedt@goodmis.org>, linke li <lilinke99@qq.com>, joel@joelfernandes.org, 
	boqun.feng@gmail.com, dave@stgolabs.net, frederic@kernel.org, 
	jiangshanlai@gmail.com, josh@joshtriplett.org, linux-kernel@vger.kernel.org, 
	mathieu.desnoyers@efficios.com, qiang.zhang1211@gmail.com, 
	quic_neeraju@quicinc.com, rcu@vger.kernel.org
Content-Type: multipart/mixed; boundary="0000000000002c51840613090c9d"

--0000000000002c51840613090c9d
Content-Type: text/plain; charset="UTF-8"

On Wed, 6 Mar 2024 at 18:29, Paul E. McKenney <paulmck@kernel.org> wrote:
>
> TL;DR:  Those ->rtort_pipe_count increments cannot run concurrently
> with each other or any other update of that field, so that update-side
> READ_ONCE() call is unnecessary and the update-side plain C-language
> read is OK.  The WRITE_ONCE() calls are there for the benefit of the
> lockless read-side accesses to rtort_pipe_count.

Ahh. Ok. That makes a bit more sense.

So if that's the case, then the "updating side" should never use
READ_ONCE, because there's nothing else to protect against.

Honestly, this all makes me think that we'd be *much* better off
showing the real "handoff" with smp_store_release() and
smp_load_acquire().

IOW, something like this (TOTALLY UNTESTED!) patch, perhaps?

And please note that this patch is not only untested, it really is a
very handwavy patch.

I'm sending it as a patch just because it's a more precise way of
saying "I think the writers and readers could use the store-release ->
load-acquire not just to avoid any worries about accessing things
once, but also as a way to show the directional 'flow' of the data".

I dunno.

           Linus

--0000000000002c51840613090c9d
Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff"
Content-Disposition: attachment; filename="patch.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_ltgmgj3o0>
X-Attachment-Id: f_ltgmgj3o0

IGtlcm5lbC9yY3UvcmN1dG9ydHVyZS5jIHwgMTEgKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2Vk
LCA1IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEva2VybmVsL3Jj
dS9yY3V0b3J0dXJlLmMgYi9rZXJuZWwvcmN1L3JjdXRvcnR1cmUuYwppbmRleCA3NTY3Y2E4ZTc0
M2MuLjYwYjc0ZGYzZWFlMiAxMDA2NDQKLS0tIGEva2VybmVsL3JjdS9yY3V0b3J0dXJlLmMKKysr
IGIva2VybmVsL3JjdS9yY3V0b3J0dXJlLmMKQEAgLTQ2MSwxMiArNDYxLDEyIEBAIHJjdV90b3J0
dXJlX3BpcGVfdXBkYXRlX29uZShzdHJ1Y3QgcmN1X3RvcnR1cmUgKnJwKQogCQlXUklURV9PTkNF
KHJwLT5ydG9ydF9jaGtwLCBOVUxMKTsKIAkJc21wX3N0b3JlX3JlbGVhc2UoJnJ0cmNwLT5ydGNf
cmVhZHksIDEpOyAvLyBQYWlyIHdpdGggc21wX2xvYWRfYWNxdWlyZSgpLgogCX0KLQlpID0gUkVB
RF9PTkNFKHJwLT5ydG9ydF9waXBlX2NvdW50KTsKKwlpID0gcnAtPnJ0b3J0X3BpcGVfY291bnQ7
CiAJaWYgKGkgPiBSQ1VfVE9SVFVSRV9QSVBFX0xFTikKIAkJaSA9IFJDVV9UT1JUVVJFX1BJUEVf
TEVOOwogCWF0b21pY19pbmMoJnJjdV90b3J0dXJlX3djb3VudFtpXSk7Ci0JV1JJVEVfT05DRShy
cC0+cnRvcnRfcGlwZV9jb3VudCwgaSArIDEpOwotCWlmIChycC0+cnRvcnRfcGlwZV9jb3VudCA+
PSBSQ1VfVE9SVFVSRV9QSVBFX0xFTikgeworCXNtcF9zdG9yZV9yZWxlYXNlKCZycC0+cnRvcnRf
cGlwZV9jb3VudCwgKytpKTsKKwlpZiAoaSA+PSBSQ1VfVE9SVFVSRV9QSVBFX0xFTikgewogCQly
cC0+cnRvcnRfbWJ0ZXN0ID0gMDsKIAkJcmV0dXJuIHRydWU7CiAJfQpAQCAtMTQwOCw4ICsxNDA4
LDcgQEAgcmN1X3RvcnR1cmVfd3JpdGVyKHZvaWQgKmFyZykKIAkJCWlmIChpID4gUkNVX1RPUlRV
UkVfUElQRV9MRU4pCiAJCQkJaSA9IFJDVV9UT1JUVVJFX1BJUEVfTEVOOwogCQkJYXRvbWljX2lu
YygmcmN1X3RvcnR1cmVfd2NvdW50W2ldKTsKLQkJCVdSSVRFX09OQ0Uob2xkX3JwLT5ydG9ydF9w
aXBlX2NvdW50LAotCQkJCSAgIG9sZF9ycC0+cnRvcnRfcGlwZV9jb3VudCArIDEpOworCQkJc21w
X3N0b3JlX3JlbGVhc2UoJm9sZF9ycC0+cnRvcnRfcGlwZV9jb3VudCwgKytpKTsKIAogCQkJLy8g
TWFrZSBzdXJlIHJlYWRlcnMgYmxvY2sgcG9sbGVkIGdyYWNlIHBlcmlvZHMuCiAJCQlpZiAoY3Vy
X29wcy0+Z2V0X2dwX3N0YXRlICYmIGN1cl9vcHMtPnBvbGxfZ3Bfc3RhdGUpIHsKQEAgLTE5OTEs
NyArMTk5MCw3IEBAIHN0YXRpYyBib29sIHJjdV90b3J0dXJlX29uZV9yZWFkKHN0cnVjdCB0b3J0
dXJlX3JhbmRvbV9zdGF0ZSAqdHJzcCwgbG9uZyBteWlkKQogCXJjdV90b3J0dXJlX3JlYWRlcl9k
b19tYmNoayhteWlkLCBwLCB0cnNwKTsKIAlydHJzcCA9IHJjdXRvcnR1cmVfbG9vcF9leHRlbmQo
JnJlYWRzdGF0ZSwgdHJzcCwgcnRyc3ApOwogCXByZWVtcHRfZGlzYWJsZSgpOwotCXBpcGVfY291
bnQgPSBSRUFEX09OQ0UocC0+cnRvcnRfcGlwZV9jb3VudCk7CisJcGlwZV9jb3VudCA9IHNtcF9s
b2FkX2FjcXVpcmUoJnAtPnJ0b3J0X3BpcGVfY291bnQpOwogCWlmIChwaXBlX2NvdW50ID4gUkNV
X1RPUlRVUkVfUElQRV9MRU4pIHsKIAkJLyogU2hvdWxkIG5vdCBoYXBwZW4sIGJ1dC4uLiAqLwog
CQlwaXBlX2NvdW50ID0gUkNVX1RPUlRVUkVfUElQRV9MRU47Cg==
--0000000000002c51840613090c9d--