Received-SPF: pass (google.com: domain of linux-kernel+bounces-94886-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Xu Yang <xu.yang_2@nxp.com>
To: Frank.li@nxp.com,
	will@kernel.org,
	mark.rutland@arm.com,
	robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,
	shawnguo@kernel.org,
	s.hauer@pengutronix.de,
	kernel@pengutronix.de,
	festevam@gmail.com,
	john.g.garry@oracle.com,
	jolsa@kernel.org,
	namhyung@kernel.org,
	irogers@google.com
Cc: mike.leach@linaro.org,
	peterz@infradead.org,
	mingo@redhat.com,
	acme@kernel.org,
	alexander.shishkin@linux.intel.com,
	adrian.hunter@intel.com,
	linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	imx@lists.linux.dev
Subject: [PATCH v5 4/7] perf: imx_perf: add macro definitions for parsing config attr
Date: Thu,  7 Mar 2024 10:47:51 +0800
Message-Id: <20240307024754.3469810-4-xu.yang_2@nxp.com>
In-Reply-To: <20240307024754.3469810-1-xu.yang_2@nxp.com>
References: <20240307024754.3469810-1-xu.yang_2@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PeUQMOf7FCvU1vslfYQvsXfYFH80ART8AUt5jgfSzsQk+ANQb9ZijB+lerph?=
 =?us-ascii?Q?rKIEU9QpDqky/s15pgZOtxMi0PDLGfDeQJAenUM9+9wxhG7JjPz7THH3cZVV?=
 =?us-ascii?Q?c9A13ZW//0Hh8/pJu/e2Ae5+YHkMcyH8zFWrE0iPV5/9vDb9O9G0KjlZxMKi?=
 =?us-ascii?Q?mxeYB6fYlTBPlCmvmD15GdlTki7mW7cy1k1wz2GZ+Qu0Wdx3kqV5F3h7WDt7?=
 =?us-ascii?Q?c1TW9bqvuVxXCN+hr3YePqt4xohtEmwI4Eqi64s906TjW+I6cei23Y6F//lL?=
 =?us-ascii?Q?rzqbo3KBqAGpyzHeJG2l0jnv5K3lvt7x3adZ7EnIdUeqdR+jqUDUnqW2ESPp?=
 =?us-ascii?Q?MipCQN9FueGY2g72TbstXmrXaDGEbrV4MvJupWq8JAm4bIxzx2buBg7Qzfy7?=
 =?us-ascii?Q?w97wVzKoRvQRt76Rx7AhoIIm36RuB8Kd60AvPgJg5k254Ao/U6S7jCGr7DsF?=
 =?us-ascii?Q?TLbS1Wkn/09MHBnsuAVCFNKd60qKm1+Nmkkz1odoGICTTnhlpJ6YsSY7BvgZ?=
 =?us-ascii?Q?jMV/e9HtNXteQwIShDXkE0A4j32u7XEsjmDsTnnVhGTOkB110+RWrDlMIch4?=
 =?us-ascii?Q?c0p4wkY5tFFIkb87v0w6Unu6+iTJaGWsY6GL9myqAAtZ5iVmZ+QOY8aRWEOb?=
 =?us-ascii?Q?2k7h3NWvN3FCqT/9r7CpUUyVjxz4XIoQIxJEWyf/7+Bdb+kWnqL/lCx2S6cf?=
 =?us-ascii?Q?teGJYaSKMKw3hh5D+d2469Z4Cmm4wfowMjdZyw8frcj9RqVD/XCc47CT18sa?=
 =?us-ascii?Q?yiDzzDPyVlDfF/+ogwZ7XoipBnQ7CP5dXVYpBCOM0uxc0DzxDqqDjPbl1WpD?=
 =?us-ascii?Q?tXJ7q0gS+hDkM/oDwKoR9Nt8zFvusZFot673+laChP2Zn/KvEPw5VvOhRaZn?=
 =?us-ascii?Q?gQdl2GlpH1c5P+ebXfwBTNCpZ7H2S2MhBVfF94vovM6qgp86h9YSTcwoMkm4?=
 =?us-ascii?Q?6RgfQsSkl8uJJDyggwfa6Wv20fDVdsXv4SJm56fPbE1CJnNualDQQE2zzcTz?=
 =?us-ascii?Q?02HdeOsyZxNHLkrb1rgq2O0cq0w1Ziq2/4JkXjhBT0XvcNp5K1XuXAUavZDP?=
 =?us-ascii?Q?qO0GvNzrMM7K3/EqH11uR7KJ+UePk9v7WEbm8+vDoXRlEYffcLC70g1m0lbX?=
 =?us-ascii?Q?aKzc6YVl2bzqiRSBohm2mtcMxcwduChkB4BrJp6mOeGfHX4eU/44YvCuunZX?=
 =?us-ascii?Q?XIFAX5N3O2PYQlW54KIj6bfzHkg8R1EMxMflROOGi93eRsh1y01sKa7QRH30?=
 =?us-ascii?Q?WnLuYIDzeYWLx1YLUdZyMw1Zm1mxWNSLxQjmsn8oe13otDlQ5hqhWe5keYKu?=
 =?us-ascii?Q?PQyDAt6eey0GWp1/PTArSl6BFnxAqVcX7SqHX31H+UUf7E+/OakQi2cSRnx7?=
 =?us-ascii?Q?hfLBGyR0IgEstxQ14Upml3DVLwZ30nGSGJctt7ba6GdeGWkdHvk//d/CLE5A?=
 =?us-ascii?Q?XVblBG+H9ijRslZzYbuADjQb3US1MFuaGXwyhVemWL7wF/YlZE+sGlJNfiNh?=
 =?us-ascii?Q?jjCflk+enHFMZzWMQFoZ+MLo8S6+ECel/vxfRgAV2oSzOHqlv5gGMCTdfQGE?=
 =?us-ascii?Q?tUfQa7nQzLs3uChfvARc1jRhDmRKAHXUgCjnBWlE?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91765e0e-5db4-41e6-6210-08dc3e510d4e
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 02:48:21.7912
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Dz2L0gi2kRbIpCJqmF/vED9x3D56+lsbSvqcjv9DfVGMNNc8ArQsYZAhq0IwdG7SA7puw8ApxiKPRqHdHT81qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8022

The user can set event and counter in cmdline and the driver need to parse
it using 'config' attr value. This will add macro definitions to avoid
hard-code in driver.

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

---
Changes in v4:
 - new patch
Changes in v5:
 - move this patch earlier
---
 drivers/perf/fsl_imx9_ddr_perf.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
index 2cd5bcf1d3d1..35e422083948 100644
--- a/drivers/perf/fsl_imx9_ddr_perf.c
+++ b/drivers/perf/fsl_imx9_ddr_perf.c
@@ -42,6 +42,11 @@
 #define NUM_COUNTERS		11
 #define CYCLES_COUNTER		0
 
+#define CONFIG_EVENT_MASK	0x00FF
+#define CONFIG_EVENT_OFFSET	0
+#define CONFIG_COUNTER_MASK	0xFF00
+#define CONFIG_COUNTER_OFFSET	8
+
 #define to_ddr_pmu(p)		container_of(p, struct ddr_pmu, pmu)
 
 #define DDR_PERF_DEV_NAME	"imx9_ddr"
@@ -361,8 +366,10 @@ static void ddr_perf_counter_local_config(struct ddr_pmu *pmu, int config,
 				    int counter, bool enable)
 {
 	u32 ctrl_a;
+	int event;
 
 	ctrl_a = readl_relaxed(pmu->base + PMLCA(counter));
+	event = (config & CONFIG_EVENT_MASK) >> CONFIG_EVENT_OFFSET;
 
 	if (enable) {
 		ctrl_a |= PMLCA_FC;
@@ -374,7 +381,7 @@ static void ddr_perf_counter_local_config(struct ddr_pmu *pmu, int config,
 		ctrl_a &= ~PMLCA_FC;
 		ctrl_a |= PMLCA_CE;
 		ctrl_a &= ~FIELD_PREP(PMLCA_EVENT, 0x7F);
-		ctrl_a |= FIELD_PREP(PMLCA_EVENT, (config & 0x000000FF));
+		ctrl_a |= FIELD_PREP(PMLCA_EVENT, event);
 		writel(ctrl_a, pmu->base + PMLCA(counter));
 	} else {
 		/* Freeze counter. */
@@ -388,8 +395,8 @@ static void imx93_ddr_perf_monitor_config(struct ddr_pmu *pmu, int cfg, int cfg1
 	u32 pmcfg1, pmcfg2;
 	int event, counter;
 
-	event = cfg & 0x000000FF;
-	counter = (cfg & 0x0000FF00) >> 8;
+	event = (cfg & CONFIG_EVENT_MASK) >> CONFIG_EVENT_OFFSET;
+	counter = (cfg & CONFIG_COUNTER_MASK) >> CONFIG_COUNTER_OFFSET;
 
 	pmcfg1 = readl_relaxed(pmu->base + PMCFG1);
 
@@ -491,7 +498,7 @@ static int ddr_perf_event_add(struct perf_event *event, int flags)
 	int cfg2 = event->attr.config2;
 	int counter;
 
-	counter = (cfg & 0x0000FF00) >> 8;
+	counter = (cfg & CONFIG_COUNTER_MASK) >> CONFIG_COUNTER_OFFSET;
 
 	pmu->events[counter] = event;
 	pmu->active_events++;
-- 
2.34.1