Received-SPF: pass (google.com: domain of linux-kernel+bounces-94980-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <61ef7ebd-f5cf-4d48-9bbd-f011d751041a@linux.ibm.com>
Date: Thu, 7 Mar 2024 10:20:56 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 1/3] sched/fair: Add EAS checks before updating
 overutilized
Content-Language: en-US
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, peterz@infradead.org, yu.c.chen@intel.com,
        dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org,
        nysal@linux.ibm.com, aboorvad@linux.ibm.com, srikar@linux.ibm.com,
        vschneid@redhat.com, pierre.gondois@arm.com, qyousef@layalina.io
References: <20240306102454.341014-1-sshegde@linux.ibm.com>
 <20240306102454.341014-2-sshegde@linux.ibm.com>
 <CAKfTPtCnN95A8kQ-uBA7ykTMAzQVRzwER-XNJt4YyQXdxhDCTQ@mail.gmail.com>
From: Shrikanth Hegde <sshegde@linux.ibm.com>
In-Reply-To: <CAKfTPtCnN95A8kQ-uBA7ykTMAzQVRzwER-XNJt4YyQXdxhDCTQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 3/6/24 11:10 PM, Vincent Guittot wrote:
> On Wed, 6 Mar 2024 at 11:25, Shrikanth Hegde <sshegde@linux.ibm.com> wrote:
>>  #else
>> -static inline void update_overutilized_status(struct rq *rq) { }
>> +static inline void check_update_overutilized_status(struct rq *rq)
>> +{
>> +       return 0;
>> +}
> 
> static inline void check_update_overutilized_status(struct rq *rq) { }
> 

Yes. Thanks for catching. I made a mistake there. 

>> +
>> +static inline void set_rd_overutilized_status(struct root_domain *rd,
>> +                                             unsigned int status)
>> +{
>> +       return 0;
>> +}
> 
> static inline void set_rd_overutilized_status(struct rq *rq) { }
> 
> my comment on v4 about {return 0; } applies only for static inline int
> is_rd_overutilized(struct root_domain *rd)
> 
> Also, I don't think that set_rd_overutilized_status() is called
> outside #ifdef CONFIG_SMP so you can remove it.
> 

yes. this set_rd_overutilized_status and is_rd_overutilized or is_rd_not_overutilized
can go away for !CONFIG_SMP case. Let me do that and send next version. 

> 
> 
>