Received: by 2002:ab2:788f:0:b0:1ee:8f2e:70ae with SMTP id b15csp371236lqi; Wed, 6 Mar 2024 22:30:24 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVLQpxxqBQO3QhtJYJNnucAxl3G/u7fOuCxGWx8g0cNYFBMzYZ77IEhi/zhDynx9gYetU046/NQjz4mBcVefO1GHzGm5D6+RET8oO+atw== X-Google-Smtp-Source: AGHT+IGXegzrDfNWShPb5Aulskl+iLhknAuPlrlgZHTLveq+2ZzhCpKuugXpYvFBtXEoOCmpadWU X-Received: by 2002:a05:6871:a501:b0:21e:8af9:eecf with SMTP id wc1-20020a056871a50100b0021e8af9eecfmr8163244oab.47.1709793024229; Wed, 06 Mar 2024 22:30:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709793024; cv=pass; d=google.com; s=arc-20160816; b=eueYjXxB0B/0IYjsZAGn2FTX/B+Zq38f59X9oez0Jv5ziOhKb7etNk+NQmM1hKuaCB 8a8PZUYLELAlXBD4wpHPRHmYnMdgvmKLRDiCLEJuBXpMirQfxstVd/ctlKbgz2D5A1c6 eITkF5IUVrO5gT9oYefNe4PIbAcIuGgVqcW7oK+oxJ/np0GENAe8OWjQk/Pal5iQCtuu jKCa/Owo2RvB2WxsDN1M8CdU/g77/aaWcJDrTIU2g+lNfTQmk3OxZqOL7uLV8dYOBp4W E/JObuKbdn891xhu/msf0c4vZM37aIkahoE+TvP70AHvCklwcV4runNHIaT6zS1YMQ4c bkOQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=pQudPlGkZi7nLdd3r5u27oEC5zqBvNR6AkcRY0RjzpI=; fh=wS4e/4m5ZUvDOd0anYubzivu4LPpQLOcSgCJ/0yL4uY=; b=QSGZPERnTHBadpEHNz6gng47lEvF9PGa/Y7N9iUb4bGP2cOdCbhXGp5bWCUY7K4EJ+ V7w+/DNIzeLgFpIT4Br4+CxpLfGUnpEn+0IaLTk9sWogkGo7gZkrDphCBhDdEi/3hp00 oJ/SjnCMutVtzuNuk3nVyit+3g26u2J9O4AmKjFJEOAQTsh50laoz43TO5scHUZir/Nj /aWKnFBzarwn9lx3dX/RuRpnmYewr5PSr/OO5IhCjBVlOn8m1ptHplW2bQi0a/Z6GKRh uUSI1Z2T9BvYEkz/mBXauhfRVftI44PX8PcMeazLXKHxRARcsWPeeEs4Kfo+pkDrqRt6 r9yw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="Q/I3SFol"; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-95016-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-95016-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z3-20020aa78883000000b006e64eb3fd06si2550414pfe.1.2024.03.06.22.30.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 22:30:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-95016-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="Q/I3SFol"; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-95016-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-95016-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DBCEB284280 for ; Thu, 7 Mar 2024 06:30:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B9D9C1CD3A; Thu, 7 Mar 2024 06:30:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Q/I3SFol" Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CB721CD21 for ; Thu, 7 Mar 2024 06:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709793001; cv=none; b=WOvcgRrgNfSTBroMwNZcTinUYlVNH1bTeuUQPMXTXX/dVEw7rVxT+KBi/AIiHwEIW12GuXfD2rZo01Rc7SeTbsNxhngm+YhIzu5KGf4VozPa9Fu3EwIkSu4gPmoBZAQ1bn9rwGd947bqN5gRxMPYA6k0ClVCf7yhl2BmLXjrGvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709793001; c=relaxed/simple; bh=pQudPlGkZi7nLdd3r5u27oEC5zqBvNR6AkcRY0RjzpI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=HE/pukx7/bCza05cAdtgTj9bAQ9n2eTtjVmr4Ha5WKdhTAL9kS7qEX/Kbca9+RZiLxLGYvo8eW0pdijAU3TO1H5rKW7DncWl8vwoQnE9GeySZME1WEMZD6JYMRlY3VNSOmCELp7iuWAeVK2Fm/ZFpu/DPzVeyT7++IusGGYJCy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Q/I3SFol; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-565223fd7d9so5336a12.1 for ; Wed, 06 Mar 2024 22:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709792998; x=1710397798; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pQudPlGkZi7nLdd3r5u27oEC5zqBvNR6AkcRY0RjzpI=; b=Q/I3SFol/5kKf6WEHNP8m3bGEpy98Teh8cyAcei7QTtZ5GaULoAUcvdFf5+GOo8sq0 OGz9+hsZ/pgJ/1WmBk+dzcmi8CIHb30C4nli2txWNeLeclHylnD5oOoq8jZjlaL1LC1G FFzsyHAUomBh3rij92jhOaBZh6DUDMWfaUn0KdwrDSbjATrX+BCBloCQSLsHHg3nqU5E qRCBFY+dx9f0DhYBm9CgGc9Q3CPrdnpb8sh7/ksBoCQe8wLzplJ+RQ9cD4jljHLQi/yq iEtI/OMqYr8UVlsSJGQkZB/ZCAkkYrbniSUw/a8bXN6kBKi+YO0lsE5jGjybYTSFXJR/ eCbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709792998; x=1710397798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pQudPlGkZi7nLdd3r5u27oEC5zqBvNR6AkcRY0RjzpI=; b=hHtn+QoU0IcNbe45yV3IBXkAMDQVBsetsIvA0x9lrkIDWWDVWB2TtlCkR/0hBvpNPV YJX6IqY4b3P7UsiiAODtB5Cf2Y0twqyjjpUN67hsF16GKtseVMQI6ie0cRMchSbhz1uu OfiOVhDMZnnz8LpBo6BD2whCgKb+QzxqJIjNZfaRreSC9V5qG8ol50wzMcXOfGm7kujB gQ4s9cc03Hm5jU5m/L2Q/qM1Bz9OYZ17qKe8ybSsAK64XFXiZOLtIXIjgpX9SvMI7+6O AOj1l/0x8lbNJEZXc/7WsDJGlBgXMth3Q1mLzByXamw7NySX7pl1wDHLcqLFHd8JujY3 bUzQ== X-Forwarded-Encrypted: i=1; AJvYcCUsvO0gwPjysZ+GIHfViH/5om0tYX2FopblxD+wgSbuuhWAMnQ8uwLUBOgTAFuAxWtFOV4nb6DQUdcKS7eLH3q6wKQrm0Z5iT68E2FT X-Gm-Message-State: AOJu0YxorT3XkEJ+e4xsUZ6WCtNLk3gi8a2rbQrimbRkBFXPBpSYKJ8a tmanHlvDe+493uO00Aqn4FMmY5XASwtlye4qGi2tNOtIEyOdGHnRCgT1zLow4uTnru5ARuwfMeH nj2TjlZvBMQ2tnbjnTZOI5U346eaYUrZKHcCtcfo6EvkT0t/Qxw== X-Received: by 2002:a05:6402:5202:b0:567:eb05:6d08 with SMTP id s2-20020a056402520200b00567eb056d08mr142537edd.6.1709792998269; Wed, 06 Mar 2024 22:29:58 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240307061143.989505-1-gaoxingwang1@huawei.com> In-Reply-To: <20240307061143.989505-1-gaoxingwang1@huawei.com> From: Eric Dumazet Date: Thu, 7 Mar 2024 07:29:47 +0100 Message-ID: Subject: Re: [PATCH] net: fix print in skb_panic() To: gaoxingwang Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, liaichun@huawei.com, yanan@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 7, 2024 at 7:12=E2=80=AFAM gaoxingwang wrote: > > skb->len and sz are printed as negative numbers during the panic: > skbuff: skb_under_panic: text:ffffffff8e2d3eac len:-1961180312 put:-19611= 80408 head:ffff88800b6ac000 data:ffff887f804ffe78 tail:0x1e0 end:0xec0 dev:= team0 > This was on purpose. I prefer the negative values, I find this more useful to immediately spot the issue. Thank you.