Received-SPF: pass (google.com: domain of linux-kernel+bounces-95035-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <54f8943d-529a-4fa2-83f3-b79eeb0446ca@intel.com>
Date: Thu, 7 Mar 2024 15:04:39 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 013/130] KVM: x86: Use PFERR_GUEST_ENC_MASK to
 indicate fault is private
Content-Language: en-US
To: <isaku.yamahata@intel.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: <isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <c560cdadb7d0dc88b831cf1a5382cf6f166ff022.1708933498.git.isaku.yamahata@intel.com>
From: Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <c560cdadb7d0dc88b831cf1a5382cf6f166ff022.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnF1ZzdOeEVJbjJ2V3N2ZjFyS3Q4Z3dyYkNIWEdOUGQvYThPVFNnUDE0MkxI?=
 =?utf-8?B?MmZ0OVIxYXdVODQ1ekVuVUNUTll6OHZEN1JPVlgwd25GU1duTkFrZVFYWVpp?=
 =?utf-8?B?REtxZUJ0aVc2c3p5V1ZCUUJaTTU3V1NGdHZHd1BqREc4U2k4ZXdLRWhsbm5T?=
 =?utf-8?B?R0lFUjJwSHM2K1RVeVZnS3lFM0pXM2JqQUc0eC9ZUTgvR2g1L3d4eUdLYk1a?=
 =?utf-8?B?cHh0L3FqNjFYcVJKejBIdE5PKzRyYTBlb05HNWdocFJsTzVYOCtseXc3NlBu?=
 =?utf-8?B?SDdEYVJMSXVmRitkNEJpQUthRWsvT0h0T0xITmtUTTMrZWdKWXFyVlBkd1JU?=
 =?utf-8?B?SXB2V2IvV1FVcXVlYXd4emtuOUZDdTV5dWYrRDd5alJCc0JKeDJJdldwU0k5?=
 =?utf-8?B?dmtPMHcwbU94M3hKdk5zdEw1SzY2ZXM3emtmVUZDMCt3YTJvTjdSc1hZRzBK?=
 =?utf-8?B?MmdtNURKaGFMM2VhNUZmdC9XNWFYTDJITG14aVVkZGVUeUo1bURWaGxzTDAy?=
 =?utf-8?B?azJkejlZNk5JSVMxSUlXbDF5UTVKYlZYbVJCQ0pyb0VwS1c0QWsyQ29uOUpX?=
 =?utf-8?B?by84ZWlpZVM0WDRLS20xTjArSEMvZWQzKzAxdWlvWFJFME4wand6emFyT1F4?=
 =?utf-8?B?Q3hibHhPRDVRdEFucFBVa2tyWmx3ZVhkVXdDRERhcmJNVUFmc2l3d3M1aUha?=
 =?utf-8?B?RFE5VjRqU1NJODJHWnBSaW9kQ0JEUk9xR2xsZ0tzVmpVZ3U1bHlLRWx1OWVk?=
 =?utf-8?B?dDlBRmhoNWFnWnk4VGFsNC9sTEhCNkZjYmRtbUFkN09MOWxqUVRXc1AvbjUz?=
 =?utf-8?B?bTR0SWRyWlJ0MHB5WDZnS3VqeXlMSkFBd0Z1dUVUeHJEMTA1T0VrMEFHaDdr?=
 =?utf-8?B?N1U4OGNNakk0dDJEQWtIdEp6d3B6bE1LWkNPWjBkN2xXd254Tm9JUWRLY3NP?=
 =?utf-8?B?NGJsTFBWYTlLdUhoUGw0c2kzTkNpdVY4ZXZySmFaQlh4VmQxRW9VZUkvVFJ6?=
 =?utf-8?B?UEhNdExRbkkrR09PR0FxMXNmbWJCSU9BRm1ZR0pqelZIczdIbnFVU1dESWRT?=
 =?utf-8?B?ZzBETE1zenBHRGhmbUo4S3MyckxoenJtbmhVeDZ6WHFtaUxjSzhrUmUwZWwx?=
 =?utf-8?B?eldzWDRYdm4vdG4xc3pjQWdGd3MzKzFJWlZ6NW9wOXZIQXJ4VzBJd0Z6RUdJ?=
 =?utf-8?B?Rm9nZFdDaGNHd0x6eXJqN3AzWUVab01KazRZMGRtSUVKYjlMOW53U0tVVmxI?=
 =?utf-8?B?U3RpRTFoZTVtZkk5ODZsTlhaMUlZbkhUY1k4Qjl4R0MrSng4WEdWRDZsZmlk?=
 =?utf-8?B?ZVBYUmtYa2tEWnVoMGxPbTZzVUhKTU5hQVljTFBIdEIrV0haRTh5WUVvRTRz?=
 =?utf-8?B?YmpFbXAvZm93QS9qMXU4R0ZBanNTRXd0bFVOS1FpOTlLMTd2VU56d2crRHMr?=
 =?utf-8?B?Q1YzQnlRMlNUY0lLQlFNRzIwM1MxejlPdUdMbk41a1g2M3ZpN29SQVZWelhD?=
 =?utf-8?B?dEFiKzdrWUFMeDV4dzFIUzV0L3EzMTFDSVR1Y3JyZG40UEFPWWwyVjM3WlV0?=
 =?utf-8?B?NUJoVElxdXFRc1J3dzdSVVBqTmsvdVhBOWVvWDd0dWIxQ3kzSU5tREhFQjdB?=
 =?utf-8?B?ZHhFeW1aUDZvNFd0USt1RnBnUjF4NWRtaUlTQ1phbEd1dUE3eUJERmd4QmZV?=
 =?utf-8?B?WERyWTI0M21ZM3l5VGk0UFNlc2YycHdQM1ZBY0JPK01oVmg5VlMvYUdVRHg1?=
 =?utf-8?B?STFUdkV4c1JESFBQNWdXVnBuRmNmTGgrNXA1d1dJaW5ycXJJTTdESTY3Q2E5?=
 =?utf-8?B?YWhjaWtzalVlZ0lMeEZyU3JrcDB4Q1Z3UHh3WXlaNWhxcXFQOEhoZFB0YWFJ?=
 =?utf-8?B?U21vVkpNYXhleDB5QnNPODNtY2JIRUpiY2ZzNi8zRkY1alplY2lNeVJFN3lu?=
 =?utf-8?B?bmJuTWpRamtDcE1obTZzNGViVUovb2x0T2pJVGxKdGlCZGlTRVJuYloySjVN?=
 =?utf-8?B?QXZENzkyTmpSbXNQTHpDK0IyMXRJZXV4T0V5RzYzZzZNR0MyWFErWEtxbWF3?=
 =?utf-8?B?bVlZVjJDSlpPRU1OWjEybjhQSGx3Q0lpb0RvZ2VVVkNEMzNYdEpIN0p4MVVs?=
 =?utf-8?B?QkpUNnRENEZBREU4Q0VWcHAzWUxmZzBGUC8wT2lVL2F3d3lIajJGTk5OZTBw?=
 =?utf-8?B?cFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ebf14fa9-4de5-40d0-e365-08dc3e74dea3
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 07:04:45.6091
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q7mOcX86CpPzke8Qd4wU3JLJxepxXb5odENfpRf5x3FUoeOm+cNo2VU5U6m2oO1FDuYlwNdJufBynlhSfKk1Ww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8601
X-OriginatorOrg: intel.com


On 2/26/24 16:25, isaku.yamahata@intel.com wrote:
> +	/*
> +	 * This is racy with updating memory attributes with mmu_seq.  If we
> +	 * hit a race, it would result in retrying page fault.
> +	 */
> +	if (vcpu->kvm->arch.vm_type == KVM_X86_SW_PROTECTED_VM &&
There are more than two times of similar check in this patchset.
Maybe it's better to add a helper function to tell whether the type
is KVM_X86_SW_PROTECTED_VM?


Regards
Yin, Fengwei

> +	    kvm_mem_is_private(vcpu->kvm, gpa_to_gfn(cr2_or_gpa)))
> +		error_code |= PFERR_GUEST_ENC_MASK;
> +