Received-SPF: pass (google.com: domain of linux-kernel+bounces-95037-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 7 Mar 2024 08:08:33 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, 
	"Ricardo B. Marliere" <ricardo@marliere.net>, Thorsten Scherer <T.Scherer@eckelmann.de>, 
	linux-kernel@vger.kernel.org, Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: siox patches for next development cycle [Re: [PATCH 0/4] siox:
 Move some complexity into the core]
Message-ID: <bdp3rbzcfvjvibyseqzwgmokj6hchwt6fxysjfg2vz5er67li4@ih6cpndluxlj>
References: <cover.1708328466.git.u.kleine-koenig@pengutronix.de>
 <lkgvr2t4wzw4jkfg523zcek6y2v5l7kj6onw77yffvvs7i2gfy@6ectsjpcg64t>
 <vg5yex3wpnfeibgkwmi33yazdxdz2pbhn4w72mnffqm3qtvjf6@gv3syxj6gsk7>
 <2024030655-sketch-conical-b506@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mnfzi4r4qfqk5vwt"
Content-Disposition: inline
In-Reply-To: <2024030655-sketch-conical-b506@gregkh>


--mnfzi4r4qfqk5vwt
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Greg,

On Wed, Mar 06, 2024 at 10:46:43PM +0000, Greg Kroah-Hartman wrote:
> On Wed, Mar 06, 2024 at 07:24:38PM +0100, Uwe Kleine-K=F6nig wrote:
> > On Tue, Feb 27, 2024 at 11:21:24AM +0100, Thorsten Scherer wrote:
> > > On Mon, Feb 19, 2024 at 08:46:28AM +0100, Uwe Kleine-K=F6nig wrote:
> > > The series looks sensible.
> > >=20
> > > Acked-by: Thorsten Scherer <t.scherer@eckelmann.de>
> > >=20
> > > @gregkh: Would you please pick up Uwe's series as well?
> >=20
> > There are currently six patches for drivers/siox waiting to be applied.
> > (Two by Ricardo and four by me.) Thorsten asked Greg to do so. Greg
> > didn't pick these up yet though. So I collected them and put them to a
> > branch at:
> >=20
> > 	https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git sio=
x/for-next
> >=20
> > I'd like to get them in during the next development cycle.
> >=20
> > Greg, what is easiest for you? Are they still on your list of open
> > patches and we (I) need just a bit more patience? Or should I send a PR
> > to Linus when the merge window opens?
>=20
> Yes, they are on my list, but I am way behind, sorry.  But hey, a pull
> request is faster, I'll go take this now, thanks!
>=20
> Oops, nope, I get the following build error with this tree:
> 	ERROR: modpost: "devm_siox_master_alloc" [drivers/siox/siox-bus-gpio.ko]=
 undefined!
>=20
> So are you sure you tested this?

Dang, Stephen notices that, too. TIL if I only do:

	make allmodconfig drivers/siox/

a missing EXPORT_SYMBOL doesn't make the build fail.

I squashed=20

diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
index ae103349c91a..24a45920a240 100644
--- a/drivers/siox/siox-core.c
+++ b/drivers/siox/siox-core.c
@@ -730,6 +730,7 @@ struct siox_master *devm_siox_master_alloc(struct devic=
e *dev,
=20
 	return smaster;
 }
+EXPORT_SYMBOL_GPL(devm_siox_master_alloc);
=20
 int siox_master_register(struct siox_master *smaster)
 {

into the offending commit in my above branch and did some more extensive
build testing.

Sorry
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--mnfzi4r4qfqk5vwt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXpZ/AACgkQj4D7WH0S
/k6nMwf7BSoxxR2R7lVuowBHVHMkXUrDH7vvsFpfr1E2e4MpLHsic+XW2tUbS4xn
FGQ6P+4Ctg45WGuQydDxUI0xo6pfpKxMiv3VQXnSLThTkhb5iXhcNOxno49rUWtE
c4o3IHcZfdUHOMXN0TfUUpSCi1yoXwkoTpOu5f2CEON0Fl3Nn5A4hQ6sVUbrKz/j
Nh5qK3pfQPipxlZ0KYWYAB6tM7mZCs3RbA58DEvJY5spueCDtkj9d4IGzes8PbHd
EBecaIfU0rMCHggSf8uxhiZzSyDtTn0kYDKKSJfpHuoOC9rBSssj660v3efyWgft
vZkTym6yhKAdvsa6BOPufwFIcPHgVg==
=W5K8
-----END PGP SIGNATURE-----

--mnfzi4r4qfqk5vwt--