Received-SPF: pass (google.com: domain of linux-kernel+bounces-95117-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 7 Mar 2024 08:16:19 +0000
From: Lee Jones <lee@kernel.org>
To: Karel Balej <karelb@gimli.ms.mff.cuni.cz>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	Duje =?utf-8?Q?Mihanovi=C4=87?= <duje.mihanovic@skole.hr>,
	~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Subject: Re: [RFC PATCH v3 2/5] mfd: add driver for Marvell 88PM886 PMIC
Message-ID: <20240307081619.GI86322@google.com>
References: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz>
 <20240303101506.4187-3-karelb@gimli.ms.mff.cuni.cz>
 <20240305114418.GB86322@google.com>
 <CZM1LPDLQXLP.VVOVCCQPGBOL@gimli.ms.mff.cuni.cz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CZM1LPDLQXLP.VVOVCCQPGBOL@gimli.ms.mff.cuni.cz>

> > > +static int pm886_initialize_subregmaps(struct pm886_chip *chip)
> > > +{
> > > +	struct device *dev = &chip->client->dev;
> > > +	struct i2c_client *page;
> > > +	struct regmap *regmap;
> > > +	int err;
> > > +
> > > +	/* regulators page */
> > > +	page = devm_i2c_new_dummy_device(dev, chip->client->adapter,
> > > +				chip->client->addr + PM886_PAGE_OFFSET_REGULATORS);
> > > +	if (IS_ERR(page)) {
> > > +		err = PTR_ERR(page);
> > > +		dev_err(dev, "Failed to initialize regulators client: %d\n", err);
> > > +		return err;
> > > +	}
> > > +	regmap = devm_regmap_init_i2c(page, &pm886_i2c_regmap);
> > > +	if (IS_ERR(regmap)) {
> > > +		err = PTR_ERR(regmap);
> > > +		dev_err(dev, "Failed to initialize regulators regmap: %d\n", err);
> > > +		return err;
> > > +	}
> > > +	chip->regmaps[PM886_REGMAP_REGULATORS] = regmap;
> >
> > Except for the regulator driver, where else is the regulators regmap used?
> 
> Nowhere, at least as of now. So you are saying that I should initialize
> the regmap in the regulator driver?

I am.

-- 
Lee Jones [李琼斯]