Received-SPF: pass (google.com: domain of linux-kernel+bounces-95121-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <40914a69-d4b7-4fdd-bc58-cf9b28271ac3@rasmusvillemoes.dk>
Date: Thu, 7 Mar 2024 09:18:17 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] bootconfig: do not put quotes on cmdline items unless
 necessary
Content-Language: en-US, da
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>, linux-kernel@vger.kernel.org
References: <20240306122452.1664709-1-linux@rasmusvillemoes.dk>
 <20240306124211.b490ea3c2372d89cff8c287c@linux-foundation.org>
 <e1075345-ea35-4b39-a158-a0d165314a14@rasmusvillemoes.dk>
In-Reply-To: <e1075345-ea35-4b39-a158-a0d165314a14@rasmusvillemoes.dk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 07/03/2024 09.10, Rasmus Villemoes wrote:

>>> +static int has_space(const char *v)
>>> +{
>>> +	for (; *v; v++)
>>> +		if (isspace(*v))
>>> +			return 1;
>>> +	return 0;
>>> +}
>>
>> Do we already have something which does this?
> 
> Well, 'value[strcspn(value, " \t\r\n")] ? "\"" : ""' would be a
> oneliner, but not particularly readable. Also that list of characters
> doesn't necessarily match isspace(), see below.

I didn't look close enough. We do have strpbrk(), so strpbrk(value, "
\t\r\n") ? .. : .. , but that still leaves the question of just what set
of characters to search for. But there's no harm in just making it "
\t\n\v\f\r\xa0" except it requires a comment saying "these are precisely
the isspace() characters in the kernel's ctype".

Rasmus