Received-SPF: pass (google.com: domain of linux-kernel+bounces-95153-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Alex Williamson <alex.williamson@redhat.com>
CC: "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "clg@redhat.com" <clg@redhat.com>, "Chatre,
 Reinette" <reinette.chatre@intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/7] vfio/pci: Disable auto-enable of exclusive INTx IRQ
Thread-Topic: [PATCH 1/7] vfio/pci: Disable auto-enable of exclusive INTx IRQ
Thread-Index: AQHacAtu1xn5Hoku+0au9dqEK9o17bEr9Zgw
Date: Thu, 7 Mar 2024 08:39:16 +0000
Message-ID: <BL1PR11MB527189373E8756AA8697E8D78C202@BL1PR11MB5271.namprd11.prod.outlook.com>
References: <20240306211445.1856768-1-alex.williamson@redhat.com>
 <20240306211445.1856768-2-alex.williamson@redhat.com>
In-Reply-To: <20240306211445.1856768-2-alex.williamson@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/q8LI44KfqlfLkEsRruj/wiMngaJMkflcq3H8AMFfL10GW64UblSMO0H9gpV?=
 =?us-ascii?Q?0KCm2/USA1GQ5z2L1ZokrC6h9BYEXBLmrzLXXF3TGbIIi2Xt7urn8h5Reufl?=
 =?us-ascii?Q?gV5zVb3kVsE/xHkidg7cGjbgI69ZndHKElrVn3syWLkNy5U0s2Eq7MP0SyvT?=
 =?us-ascii?Q?EnuzqwmCDvawT9/3Iwk2TR0mSfPd8orEkFBRqL0AHr+14vsRMjVdUVNdnJ+o?=
 =?us-ascii?Q?/FkEyaoMF0i2OgfLuncsZPdAGTZFfJ0+KhmJa1e0J8d2si+Zs16LNFcx1Vnk?=
 =?us-ascii?Q?3et5pSkGvuMLbjc+ahrY3vYMxu/pMV8zZxNXngjZjHbjMtYfDHEgcF1TY27E?=
 =?us-ascii?Q?m1HmJnxIF8yIr5CisvQIspmPafg9GBFHEXTlUorhHa13x/M+Xva2zWjHr9SC?=
 =?us-ascii?Q?AFirw5B6LTFN8BjTrpaXf0bBmZwyye0zEl064Vm2mSIlgyQZHWFnUIXLTlyq?=
 =?us-ascii?Q?VrLFFWffiNDC3plY0PdnV5lEN6/SZ+pTPHBQrBXI0i0gWBF2IImZ8o2S0sB6?=
 =?us-ascii?Q?cisyf1g6PyqckfpD7Mb8CFR/cJ3mvfy1oimrfy7fdV8C8UViScbnmUI1G1fY?=
 =?us-ascii?Q?Zdlpqmgu0VV1QZinrNFOEKo6VF6w+npUdzN5YygjqtGAC1djrm6xkMHFxWta?=
 =?us-ascii?Q?87a92HqjKjnxv/w9dTtIWdcmU1TQXx5Pzez9ei6ugRtgdVD+DX9oJItkVObh?=
 =?us-ascii?Q?POIlBnQ3tEji/WiPEWjzdet2M/glBzkL2rDsB0ZxD4QgASG4mTo3a1ti95W+?=
 =?us-ascii?Q?xtozEKnhb2tsihUf3mEMW1A4uYORb6N1pHrpCidCPnXQov24Vhp6j3tZOPiF?=
 =?us-ascii?Q?sDqKbf/a9Q79Fov39BqfNBzv3CC/UYFnpLAqbjaJYMQCyTPSRn2thIwkSRE1?=
 =?us-ascii?Q?t0rP+G91PuvbYGybuDemnjhN32ig+jmDasnt3YlNdIOIFH5TN5HVzZNVJJYi?=
 =?us-ascii?Q?dsnOYa2q0O0+csTKAqOV33+rG7yir+2UARa79zvEq2rt3ux2B8KW5PN5AXjy?=
 =?us-ascii?Q?W4sQO0Io7hf1W2cIuMbjNY0kEI3jX7XniuLNpLB5YWbsePmf/SJjFKrfB6Dv?=
 =?us-ascii?Q?FzpLwhPYGpJvG2W8WjWW02+wbt+RX/IwAL1eVNhtZ+7Fu6JV5/PU6z9QmSYD?=
 =?us-ascii?Q?o8YLV7+Uslc9GB6AubEMD99i9cG3S3CxX3u+3wPhnl3siVvHQdA0unJOs3aO?=
 =?us-ascii?Q?J2M8VA+P0SiGCvOiqPfj9xRcWDtWv0nuC+VPD6c3MXJ3kK986E8gplksdqM4?=
 =?us-ascii?Q?CunSh5hytmbhL3zWsmCKw5fJAsyv1GkgP89EvlcNPkTEC1av2ZT56lbFU6yR?=
 =?us-ascii?Q?AMM4MLO6+AHD6mIpFLjKZL/jmmkSs1tLOHwMBXyav99IvTfhZpWlSl0Eya8L?=
 =?us-ascii?Q?dwYyMPA0FG2hBzXbBqsFlHrwFiHhzIGKa46QqTR29OYo+4gbGRarfqsb3kh3?=
 =?us-ascii?Q?uDIknpVW1HJeazV0reSGhj7pQjiKxqLlSf/mDGG8oUXTtWciExZaxQSxUZg/?=
 =?us-ascii?Q?7r4dkhs9q/U5FHfJUQLB1o9rsdyztavlPyDEO4biaZ4d6igckKC83UNt6z9a?=
 =?us-ascii?Q?+f0e+6wOkp1fsRW1roDus2e+7V6gwpb87fS/ecJe?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5271.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1432610b-fed3-421d-db47-08dc3e82130a
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2024 08:39:16.5572
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xiw2SJck084dnX9Jeavhxb7qbzTXZZ7jomvmfFJAl98O6mXFguBtTDhY83Q6Ys2fOyBHVZ1k6LK620PWihDSKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6417
X-OriginatorOrg: intel.com

> From: Alex Williamson <alex.williamson@redhat.com>
> Sent: Thursday, March 7, 2024 5:15 AM
>=20
> Currently for devices requiring masking at the irqchip for INTx, ie.
> devices without DisINTx support, the IRQ is enabled in request_irq()
> and subsequently disabled as necessary to align with the masked status
> flag.  This presents a window where the interrupt could fire between
> these events, resulting in the IRQ incrementing the disable depth twice.
> This would be unrecoverable for a user since the masked flag prevents
> nested enables through vfio.
>=20
> Instead, invert the logic using IRQF_NO_AUTOEN such that exclusive INTx
> is never auto-enabled, then unmask as required.
>=20
> Fixes: 89e1f7d4c66d ("vfio: Add PCI device driver")
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

CC stable?