Received-SPF: pass (google.com: domain of linux-kernel+bounces-95167-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <c3ebaa55-d05b-4f11-83a8-2a0fb85044cf@oracle.com>
Date: Thu, 7 Mar 2024 08:55:51 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes
 group
To: Igor Pylypiv <ipylypiv@google.com>, Niklas Cassel <cassel@kernel.org>
Cc: Damien Le Moal <dlemoal@kernel.org>, Jason Yan <yanaijie@huawei.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Jack Wang <jinpu.wang@cloud.ionos.com>, Hannes Reinecke <hare@suse.de>,
        Xiang Chen <chenxiang66@hisilicon.com>,
        Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
        Bart Van Assche <bvanassche@acm.org>, TJ Adams <tadamsjr@google.com>,
        linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20240306012226.3398927-1-ipylypiv@google.com>
 <20240306012226.3398927-6-ipylypiv@google.com> <ZehLpV06mpHxjecc@ryzen>
 <ZejYb4ykeF7Qx5a5@google.com>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ZejYb4ykeF7Qx5a5@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?SlpLdGE0Y2FTZ1BYWXdFbDIwWkZ0Z1hUZjdKWTNyb2xGZGdpRnYzdlVoMVor?=
 =?utf-8?B?R2N6Q2RsN0o0bXpOQ09rdGRubGRlb0FhcTlPWjJDS1I3K2JLUk8rWVlDWHpt?=
 =?utf-8?B?TlIzUWkyeVJXWVpxMlBzc0VoQksxU1MybVN2ZXZ4SFU5Z0lCWUl0OTFUbzVj?=
 =?utf-8?B?bUZtd3F1TThaakt5TXdrcDZER1phWVFIU0JuUDJTVVRYL2Uwd25UdFQ2YklT?=
 =?utf-8?B?c2xtZUJsU2paU1BWWEgvQWxrOFZuRlIyS2x1cFVJdEtwbnZ2NEJzM1hwdEFN?=
 =?utf-8?B?VjZ5VytySXFtaHBrNG4vMWVNcDBkTXVSTXI1dm8ybE1vZjJsRlNzeWdzemw4?=
 =?utf-8?B?QlVmaXVSUGVqS2xtR2VpZVVUcFc5VitLL1NzYU1hOGhEZHBsRlJYRjFTam45?=
 =?utf-8?B?N0hKOVZKVDRnK1JYYTE2Q2tDdTh6ZGZHaDdFYkcrWVEzSTRhd0NJaEpybk1u?=
 =?utf-8?B?MlJKOVcxSmVORUJiY25sN212VFZpRkgycEM5Z2ZNbkdUVHMyZjJmRm1qUW5J?=
 =?utf-8?B?RGdacWFZRS9YNU9RMUUzOHJGQ1lhWnd6Wk56UFhQM0lkOWZYc3NQU3F6Yzhi?=
 =?utf-8?B?RDBqenBlU0ZhNjNYVzg0Z0g3RjgyOFJINGk1aWkxeEd1bHlIcEs3SHR4NTFy?=
 =?utf-8?B?emFkUEVLYnh6UENlZllBVk1ITEhHanU5VXhIY3UwVkZ0STJMd3B5ZWNOcklr?=
 =?utf-8?B?TUIwRnVRN2RqTFNDbTZ2V01qVmVIbUZsQ1hmVWRyY2tTVFB5MmFCZ2lQNHM2?=
 =?utf-8?B?QkpHcHBOUno3N0srbktnZE1SeFdlZGdxLzZBUkt1c08zUDBmZnlwS2FLZTA0?=
 =?utf-8?B?TlhzMUovSk1pWU9pdEo1N0Z1ZFRQWDN4azVMaW96TWQ3bXVmbEl0cnVDWTBN?=
 =?utf-8?B?T1RHTUtTeCtyT3c3aU9DRzduUmlFN1lTZmt0N0pQQjVtTnRqRmhYMCs0NXJ5?=
 =?utf-8?B?Z3krSkV0V0hTdFRwRGlnUURlc0w1Nmd6RU1KTWREa2l3WDdaWjhMdGZMcXBW?=
 =?utf-8?B?cDVFMHlBQjNzZXNpbytObnBNMUZPQnVwMm8yQkUyU0Z6OVlyUjdpaXBwRFFI?=
 =?utf-8?B?cVJ4dDU5TCs4TURHWlpMSzdWUUVocmQrVGlwbmRTb25ySDNDalNtdEIvSC96?=
 =?utf-8?B?MkZtNHBsT3h3ZlpYQUZyVWVLcTgzdDcyeEJyN1VKT0lNZXBMa1F2eEF3cFVr?=
 =?utf-8?B?Uzk5WmdlbTdZQUtZQ3gzUmo1YTRIUzduSURseElmSHFVMnRRVUx4cjJ5ZDZP?=
 =?utf-8?B?R3VCTXYwd2Z3N3RoZmppd1dTQUtVZHRNSXR4bldZUDUybWZmSitYM3Q4TVlx?=
 =?utf-8?B?SzZCczdBeCt5N0NLUzQ3eldrKzkrK3JSNTZnZ3FvclJrUHE2NjdURllNWWxj?=
 =?utf-8?B?ektRM29CcmxDVE5tVG55WXJ4aG1FL1d5TWJmZy9iZXRyZlRiU2VLL1doN1Fv?=
 =?utf-8?B?Rm1KM2ZBd1k2ZC9QbWJDcmlwUHNFVktWWVlMQU51bUt2WUV6OVlMMGhLUXZv?=
 =?utf-8?B?MDI3dDJoQ3NsQmNxYzdWdklWVUxJaVVBeCtWSnZrODA0b1Q2VythMitOQ0Fk?=
 =?utf-8?B?S2VSRTIzbE1FR2w5d0NIVmdvbVd5K3l0YzgwTHA5TDNBVjZ5YjlabGxuMG9o?=
 =?utf-8?B?dWZMRlZkMmUycjljSFhNS2ZON1l5N09zT2dpeGVmVzdkWkdPTzM3cnFpdFNQ?=
 =?utf-8?B?Q3JEM2VCL2JVZ1JVczhxRXZSWTN6K2NGMVhzaGpScDgycDBVR0V0UUI5WnNN?=
 =?utf-8?B?YlIrQ0cxNGlXYmtlQysvUGIyeENxdUlyb2R3MTNKdDBhb0VrVzdHVG1lMzZk?=
 =?utf-8?B?OEV0RHNIbW13SmFZZkRRWVVNb2hkaDFCZmlrUlpSdUphMktnMFkvVTEvTmg1?=
 =?utf-8?B?WWFwOGRST1FpQjUzQTZNdVZMV2R3bGVKM3RsZFM3U0lmOTRjS21sYkhDakxR?=
 =?utf-8?B?VnJNZ0lzdnVwYVFJVFBmN2dmVngzOHdYUWRBeDJ5V3ZMMDlrUUIxWlJjSEVQ?=
 =?utf-8?B?b3FEdkZmdHRCS0Y0VHVVeW9naWFpVHE1UWhvSTdqeCtBQTlUNE9kWUw1eUxn?=
 =?utf-8?B?c09Ga2xab3grOWc3YUFwV0p4OWp2Wk5meUd2eFR2akkwYlRZMlJueGY4dmRZ?=
 =?utf-8?Q?86es4tEtBCweZvcinalLWqzld?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	75jmFI1cP0lSHS0SSMsgFI4iSkgf0vXhun8Xg6WShWiIeOCgzluAj++SERUBDlZapTy4PFjGsrbAIY6sV0rXo9HURS+f830b5J4IKujfkRGEG9ziA9RXOInpWApl/D3iHLcMI6gYtdf2aTPPnx2EnI/JdtSh6AiyKC1/VgcE88MxxTgGrIbj+wO236l4SFW5+miNac/zvCuGqhJ1d2QL+x4xbWSnQPeLDeD9tE168jH+8ZPgViJXuwkzsTYxATTfO72k585W1JEiavtwDAEjt0mbcjsqH538Ejl+zlu5HLw6CS9866vU7DvZDnG0k/QmBcdmGeRXhYizyBollZQADrPRmmlBeX/93qES01KFWw/9uWuZiRFQIWzcQvB64oOaqcJzX2RKoQ6Y73r4TcMLsNxl0mqnPrg/p0CsIh9DAr76FZ0yth24QTmJ3N/cQN9IavoV/HTYJYcXgbXamNH0oSaEbReE8XpI1MP22CzwJglR3J5XeMMydtocIWSxpNiiTRcSc56wznMhPas+rElmtrGv2ATGOmp4DmoFdrCjEpoEr78aqxJFXT5oDfUik8+vUX17qTVUIxO0m1OtRE/B86CZ0AKBUb+bQ9XJLUUif8I=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f5adb47-cca2-4cf3-ca2f-08dc3e84666d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 08:55:55.6896
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sXUSAWexd6F5nIaIo14QcxRMJJQFbByTtmtBRi418ApqBNRufrBowDgwwdBWHDaAQ8Brw5H3pTaegcZcOsvg9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB5961
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-07_05,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 adultscore=0 phishscore=0 spamscore=0 mlxscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403070064
X-Proofpoint-GUID: C_mSmkwrNUqkNEjgx_QRlFFTHnYlEUKX
X-Proofpoint-ORIG-GUID: C_mSmkwrNUqkNEjgx_QRlFFTHnYlEUKX

On 06/03/2024 20:56, Igor Pylypiv wrote:
>>> ---
>>>   drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++
>>>   drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++
>> Is there a reason why you didn't patch:
>> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c ?
>>
> I originally patched hisi_sas_v1_hw.c as well. John Garry pointed out
> that v1 HW doesn't support SATA so I dropped the change.

If you are going to do another spin, then maybe update the commit 
message with this.

Thanks,
John