Received-SPF: pass (google.com: domain of linux-kernel+bounces-95216-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 7 Mar 2024 10:25:45 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>
CC: "Yu, Fenghua" <fenghua.yu@intel.com>, "Chatre, Reinette"
	<reinette.chatre@intel.com>, Shuah Khan <shuah@kernel.org>,
	"james.morse@arm.com" <james.morse@arm.com>, "ilpo.jarvinen@linux.intel.com"
	<ilpo.jarvinen@linux.intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages
Message-ID: <o6va7b7rc3q46olsbscav7pla4hxot2g6xhctflhmf64pj5hpx@56vtbg3yyquy>
References: <cover.1709721159.git.maciej.wieczor-retman@intel.com>
 <8a158ada92f06b97a4679721e84e787e94b94647.1709721159.git.maciej.wieczor-retman@intel.com>
 <SJ1PR11MB608310C72D7189C139EA6302FC212@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <SJ1PR11MB608310C72D7189C139EA6302FC212@SJ1PR11MB6083.namprd11.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?pg2Oz/fQ6zEmu17A8snpTzgw+ja+Sfl/RWT/H6R8sX5fyjUfdbwhhSQH3X?=
 =?iso-8859-1?Q?fkMbO7NUHz3O/AGLIu8/PQFt68c+DO1680hZuRdp0qVohBKmf9grt3PEjB?=
 =?iso-8859-1?Q?0h6n7+irmrQTeT2g//PJIUi2qis/1hIMa3cuddzed+BHHE1eOFE217by30?=
 =?iso-8859-1?Q?Pi5vfe9opTLeCTaG3SWnk8Oe2JN1GnwSVc8785geMS1f5N692PZwsN2xE6?=
 =?iso-8859-1?Q?6HSZCu80A1H343vpC2Pja8gv2LSHy/bLPV5bHw/l2MKUdbtMRtBYYJiIZ6?=
 =?iso-8859-1?Q?IJm+U8Xdug8uz2Ty2tE9WgXQJntrf3t9WEdbpMxU6w/2fCil0Qncia+PLc?=
 =?iso-8859-1?Q?vip6p3y1q4hNIRbNbBEmEFYkv5oMOZsfleuF2l0UlclzPgEfjUIvokPWG4?=
 =?iso-8859-1?Q?PwlGwQHcgQ2RYlyqSJmKPI8oaLtJoMPTCXaWiD5bF0XGIBsVkhrJ2cZaqE?=
 =?iso-8859-1?Q?ODraAPB1krIUQPSOnlliLd2B9HfNsvCKFU0R5QtsNRDbNziE8LyzPhCZjR?=
 =?iso-8859-1?Q?HVzlRAqpeyfd1EnrlNswdPAQdL4lbR7AX8SVYyrCqEls1lNW+qiBX9LvGf?=
 =?iso-8859-1?Q?BSqgSeb6uFT8iNjVCfFYTY1n4EUP1VaMle6uegJV0ceQOif1vhnK3giEq8?=
 =?iso-8859-1?Q?hs34oC3pd7hoigMuDrtyI958E91KDVyupu9dBPfIcgID/gMibxIyfCmDyQ?=
 =?iso-8859-1?Q?+pRGVXLLOyUKGPhtxR7brOnPZEsFzuEDVOiDzdGyIN/vlryTPgUd8HPVRA?=
 =?iso-8859-1?Q?/PGoLjtU5X9XUZcm7rp+DjSELZzATn7veMDB+c06ZM1z7x7xGTrudvD482?=
 =?iso-8859-1?Q?w/fiNiATMdTBmfy6QWvYhIZNFHcYjy34t0ytHA565WatEvz0SmH4gGIDBG?=
 =?iso-8859-1?Q?2mCkMkd0VJnybDaigMqIUbNXhy9k5KjtkpazDpkRX5Z6neuLyGtB5DPH1E?=
 =?iso-8859-1?Q?R90GyzD7CP4Vkn28WQld+794KAeTEGe2QKQaVbaUsrJgxS2ebl+ciJgvcv?=
 =?iso-8859-1?Q?oK0AQKMz3QTfyE4u5jtaluqFJG+Ya747kv1yoPvrzusLTWS+LSgTGXQ421?=
 =?iso-8859-1?Q?X40lRv1oScAwJED1Hy+4vp4SfLEKKI5WFSLMmjfNsMXzI3e9VcyhMx4cJX?=
 =?iso-8859-1?Q?yMHU1k5JaKvU90/FSliIWAanOK1FLkQqq1CFdHzWAtXRd6d9dyUnIoemIo?=
 =?iso-8859-1?Q?esAllQ4QFaeuWIgL/hUd0wsbgW48U+nn+0Nx6DaqXEXk6mE8Jodh144J6R?=
 =?iso-8859-1?Q?ZWIjigTydm/JUreGF/S6Z6cNnrehqqJbZ4idEQKqm8vPDRzike215R4kyV?=
 =?iso-8859-1?Q?2Y7NhtUeOVToVpaACuMhTvxg5tHq8QIFkAirzJjLbi4RFQysXYqBXh1dST?=
 =?iso-8859-1?Q?JzAwxSmhDQsA6tUUt+6eXCKbNGjSbdjlgLFThgRRdSoWbyZB1gyhZYT0ca?=
 =?iso-8859-1?Q?lMZhIdZNtQx0HTKdevVU86lzU7ARlaF0wAjuZz5XHIyfnfrDkADkGTFjyD?=
 =?iso-8859-1?Q?9K1oiifKzhy4Ol9/MTVAJ5l4lPJmJ6TSuCfWksUe29s2WQWDY9amM0gA19?=
 =?iso-8859-1?Q?bTqO3PW1cc7lh7kCUE5qptW8FWDTyE8zy8qF4uSl7QBw5WugXzyVMiJTsy?=
 =?iso-8859-1?Q?vO6ZzeNti5VELC4fDDIve9lS6rSrmgFjFtucil91+ByVTeP0ai9bjii0Lq?=
 =?iso-8859-1?Q?VG39672gEj8+Re0e3l8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fa0f0e61-dbfa-49de-9da2-08dc3e8896c8
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 09:25:54.8062
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CQLVdra18MPK+V7GW9LT8jBvxXihA86YInTOyC1KjNClXkpW2zeAzsTGS8LAHfNOOZ+yOmSaXWvdjFIk6Wkixsw8YTZIjhWtuz1rvq01V9c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6842
X-OriginatorOrg: intel.com

On 2024-03-06 at 21:54:02 +0000, Luck, Tony wrote:
>> Figuring out if SNC is enabled is only one part of the problem, the
>> other being whether the kernel supports it. As there is no easy
>> interface that simply states SNC support in the kernel one can find that
>> information by comparing L3 cache sizes from different sources. Cache
>> size reported by /sys/devices/system/node/node0/cpu0/cache/index3/size
>> will always show the full cache size even if it's split by enabled SNC.
>> On the other hand /sys/fs/resctrl/size has information about L3 size,
>> that with kernel support is adjusted for enabled SNC.
>
>Early versions of the kernel SNC patch series added an info/l3_MON/snc_ways
>file to provide this information. I was talked out of it then:
>
>https://lore.kernel.org/all/f0841866-315b-4727-0a6c-ec60d22ca29c@arm.com/
>
>But that discussion didn't consider the question you discuss here: "Does this
>instance of the kernel support SNC?"
>
>So you have a clever solution. But it seems like a roundabout way for
>an application to discover whether the kernel has configured resctrl for
>SNC mode.
>
>Should the kernel provide an info/ file listing the SNC configuration?

I suppose it would be a benefit for other numa aware applications to have an
easy access to this kernel support information.

>
>If so, what should it be named? "snc_ways" as a kernel variable was
>later replaced by "snc_nodes_per_l3_cache". Is that a good filename?

"snc_nodes_per_l3_cache" seems okay to me.

And I understand that the file content would show SNC mode and the presence or
absence of this file would tell if kernel supports SNC?

>
>-Tony

-- 
Kind regards
Maciej Wiecz?r-Retman