Received-SPF: pass (google.com: domain of linux-kernel+bounces-95221-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <dc6c4d98-e56a-448d-b372-38ce0cd927e9@nvidia.com>
Date: Thu, 7 Mar 2024 11:28:52 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] nvme: Use pr_dbg, not pr_info, when setting shutdown
 timeout
Content-Language: en-US
To: Len Brown <lenb@kernel.org>, kbusch@kernel.org,
 linux-nvme@lists.infradead.org
Cc: maxg@mellanox.com, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
 linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>
References: <49a7c0b667abe23d95d67cf0cf7ea7e193d9f2a1.1709773065.git.len.brown@intel.com>
From: Max Gurtovoy <mgurtovoy@nvidia.com>
In-Reply-To: <49a7c0b667abe23d95d67cf0cf7ea7e193d9f2a1.1709773065.git.len.brown@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OW4ySDJMeURwWmtRRHVUMk4rbXduNlNKUFQ1Nzg2SFBwL1UrT3J5NnJxRHlF?=
 =?utf-8?B?YjVqaFVHRjVmSHhxV1FZMnVHWDlHZjg3ZnY2MTF2RmhLRmpxUGNLZm9ORmw2?=
 =?utf-8?B?TFE2RWJzczc2ZStiYmdheElkRElGVFAzMStsSVlncGRsQjF6bDRqOUgwend0?=
 =?utf-8?B?WklRQVpnWmlFNUMwNGtvSm9CTFNhUDdBLzhSQi9YZzRjQjB2YnFIVllYM24x?=
 =?utf-8?B?Y3RrYVJFRTRuRkpKWEc4c3luNXRhYUV5OUJ2YVgralJhMzdwZVVIU0ZGTDF3?=
 =?utf-8?B?aXhuQjE5UWlQTkY2TFNsWGdKLy9xK21xYzdiRXYrQmlsQmJIY2pNaEVsN1U1?=
 =?utf-8?B?TC8yQmdiNVhRZ3pXN0Z1VTh5ZzlTeEpUaDlBYlFpWURtSzRoRFhOZ1czeU1o?=
 =?utf-8?B?cUVPUE5aQTlDTzc0OUF5dWhQVFdFaHgrRldnMjZNTlJHb1BxV09RNEViTHhB?=
 =?utf-8?B?N2piUFY3MTdhYVFNN1kxb1p6M0xHQzJOZTlOaURxSDIyV1BNYnBhamdUWndS?=
 =?utf-8?B?bW5nd2FkMW9xcTNpOUkzZnlzS0sxbEFQZkFLV2V4aDkwV3NqV25QQVpkMG5z?=
 =?utf-8?B?dVN4UFVPcnpYdUpCUjJEbmcybi9QTnZHRnFOTks2WkpSdkx1RXB4NXc5aWZr?=
 =?utf-8?B?VjRtMGJUMlJuQldvd0ZtWGpEdTlid0ppTGZ6NFJOeThHUi9hZ1BibGhKZlBz?=
 =?utf-8?B?dDM2Z01HUTlTcmpZS2pDaE5hSVBNOU0xZmdqOUlEZTVwc1Z4QmtxbmxiNFpo?=
 =?utf-8?B?MGh6T0xhdTlRZk5VNnFKQ3puZ2F0Um5URklWLzhQV1U5VjUxT3o2YUFVMEJN?=
 =?utf-8?B?NXJWc0lQemdLaXA2dDlCd0hyTnpRZWRlN05ZdWxCY3RrYXVkQkw1ZXBKK2Nn?=
 =?utf-8?B?NTVIeVBkSGNpT2dxS1liY3VKZjg3RnZ2Tk5SeUc0K0RucFVsbzJUb0VkWmd2?=
 =?utf-8?B?b01ZM3NJakxzam9mYjkzbENHWVZNemUzSTc3TGMzSkJVcUVtTmZoMlg1UUgy?=
 =?utf-8?B?N3l4d1lEWG44YjhxNVkrakZSYjh1a2VjMURKSE00MEVoZExiNFlvaURZUEsy?=
 =?utf-8?B?a1MrakoyMGJkcXpkOUpjV2FSRGdpd1QvSEJhRFpacWI4cnJMVzcrV3VDYlQ1?=
 =?utf-8?B?bGdHM1NYTnpzTGhMcnJ0OUl5a2llcjd3VmtaOHZ0a25rRWwwMTRCQTNMSk5a?=
 =?utf-8?B?M1kvWVJkMzlpTmtpVWkrdnNSaFFQclFQVzk1OTBWK3ZQaFVYUXNLN2g5Q1RD?=
 =?utf-8?B?azBSUm1LQ2F1cmcvU25wQzNEOHZBWStxeEVnczVhY2dGVkIzbU14allKU0RD?=
 =?utf-8?B?VmJ5djdqZ2pMY29GVWYyNXc2TUszVUxGMS9wa0FHMEJ1VVBnRGZhTHR5ZWtK?=
 =?utf-8?B?cWVkUkRqSUJzZU01NWF6bWk0eDdnTHhHVkMwU3F6MXZZdGcwRDNxVGloTUdN?=
 =?utf-8?B?b0JXQ09yakZJZ1FFYThtd0ZySnU0WjRBalhpZkU5b25UdEhkZ0w5OUljajZq?=
 =?utf-8?B?aWlIcXZuRWlKNWdaM09GYndnaEhsTll2Sjd2eGF5OVJYWTFrVnJMUFZwYTBi?=
 =?utf-8?B?a2VSUlBXTlFzTHAwYXMybDRQRTIraExnNmRtai9FekQzU3VrUTc5aTRNQlly?=
 =?utf-8?B?UnpUWmM3RFB1dGMyNUVCNXkxWDVoQS9SQmVHWC9qMmFDZzE0WE1Ld3hPdmoy?=
 =?utf-8?B?dXVsYSs0ckZ1UDVUWC9pa2p2eXFsbTU1UGRqVjFiczA0UjlrVDRwL09GSVJu?=
 =?utf-8?B?cmxQRHBmU05kcURXTGhTR2ZJQ0o1Z3dXMXQ5VzV5cDNzcUNnNWZWTldkRjJu?=
 =?utf-8?B?K0ZCOVpiYnNVNG4ydW9yOFFGZEh5Ymt6cXRNdkdueTRJSHNMN2U1RTFITmVj?=
 =?utf-8?B?NVNPNEY3ZXJuT0pWcVFkMVFCNnRiQnplUzBUWi9UOEg0K2ZsTHZSOTRRSDRl?=
 =?utf-8?B?bHZxNUtIOVlSWXZnRjR2VzVaU3UrZUdSTkd0bHh2bVN6S2xlYXpON1c5Nzg1?=
 =?utf-8?B?UFBCWXZXQWZDS2dnZUU3QllTcURmZWorcDYrVE04SklMbDZhdzlpSTlwdXZG?=
 =?utf-8?B?VjZpSlFuTHZFSVlmVW9YMGlkZUEremw0OHVjT1B3YXNVSUV0L3Y3TUxMYk5U?=
 =?utf-8?Q?pkgtqdD6QZ9o8LkJNV4Vhr1Lj?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be61e20f-ea3c-4c00-93ff-08dc3e8905bc
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5040.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 09:29:00.9251
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2xTbVm4hs3KVeMGa4dt414hNVp9VAZoqvQX22dc8mzLn8I6P1+sqwS7CctC5sAJJK7piFdQBMNTYqgdfNNr8kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9227


On 07/03/2024 3:05, Len Brown wrote:
> From: Len Brown <len.brown@intel.com>
> 
> Some words are alarming in routine kernel messages.
> "timeout" is one of them...
> 
> Here NVME is routinely setting a timeout value,
> rather than reporting that a timeout has occurred.

No.
see the original commit message

"When an NVMe controller reports RTD3 Entry Latency larger than the 
value of shutdown_timeout module parameter, we update the 
shutdown_timeout accordingly to honor RTD3 Entry Latency. Use an 
informational debug level instead of a warning level for it."

So this is not a routine flow. This informs users about using a 
different value than the module param they set.


> 
> Assuming this message is actually useful to somebody somewhere,
> let's make it DEBUG level...

why ?
I don't think it is necessary.
> 
> Fixes: 1a3838d732ea ("nvme: modify the debug level for setting shutdown timeout")

This doesn't sounds like a bug fix to me.

> 
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
>   drivers/nvme/host/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 0a96362912ce..e361af1953a4 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3205,7 +3205,7 @@ static int nvme_init_identify(struct nvme_ctrl *ctrl)
>   						 shutdown_timeout, 60);
>   
>   		if (ctrl->shutdown_timeout != shutdown_timeout)
> -			dev_info(ctrl->device,
> +			dev_dbg(ctrl->device,
>   				 "Shutdown timeout set to %u seconds\n",
>   				 ctrl->shutdown_timeout);
>   	} else