Received-SPF: pass (google.com: domain of linux-kernel+bounces-95283-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Xu Yang <xu.yang_2@nxp.com>
To: Frank.li@nxp.com,
	will@kernel.org,
	mark.rutland@arm.com,
	robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,
	shawnguo@kernel.org,
	s.hauer@pengutronix.de,
	kernel@pengutronix.de,
	festevam@gmail.com,
	john.g.garry@oracle.com,
	jolsa@kernel.org,
	namhyung@kernel.org,
	irogers@google.com
Cc: mike.leach@linaro.org,
	peterz@infradead.org,
	mingo@redhat.com,
	acme@kernel.org,
	alexander.shishkin@linux.intel.com,
	adrian.hunter@intel.com,
	linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	imx@lists.linux.dev
Subject: [PATCH v6 5/7] perf: imx_perf: fix counter start and config sequence
Date: Thu,  7 Mar 2024 17:57:28 +0800
Message-Id: <20240307095730.3792680-5-xu.yang_2@nxp.com>
In-Reply-To: <20240307095730.3792680-1-xu.yang_2@nxp.com>
References: <20240307095730.3792680-1-xu.yang_2@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PKWnbxceFK5pYxCzHLtLh8Hzc9uivulkr4HC9rahLyBj4cy+Bl36Jvrmyhfg?=
 =?us-ascii?Q?A5OwwbYgxfq1wRuMDCO1vtn3tuSfK1KgJO+BonwwnMzC5q0/NQMagLGAhZ2D?=
 =?us-ascii?Q?1yOtGYKb5gO53fw8+JKf0IYIdiFxcKMmDru/9nZVkPVBZhF5HORgBbycb9fU?=
 =?us-ascii?Q?B0xMS+kRmmqgkp2xDmEqHl67uezWQSp4kNha8mUUo/Wh+PAKi0jDeuTIWEof?=
 =?us-ascii?Q?OgySnIfS6H5kh38O1p5X4uw/3Pq4ssTpFgmtcULXmY5GgfoXk2IaqTssB+Uq?=
 =?us-ascii?Q?nEio2q00AELGEE5Eaz0KFWYwxEVQYvaSrmR6LGpkou4dPhxr4tAr7NP3TzVv?=
 =?us-ascii?Q?17UDHufOnGaplDdHG/Qe0SIB/1u9yRKgEo94nzgWZc8fSYPRDh6dh7OgnbhA?=
 =?us-ascii?Q?u41QUp19i0rvbh6pkO9AhgCpSRW1RgkWsX3x9iira1OlF6hc9KSuFvyPpMnM?=
 =?us-ascii?Q?4hHrwbkxK/shyEqtFFx5BHdiLkFt927bXm0Wt8t1oSJN1lwa3fQZ8FdnPE0o?=
 =?us-ascii?Q?xV6oWMF6HoS3mKT9leDyGElByg2by3/aWfQVV1uZML9xkFCXH/BMUT6woOy3?=
 =?us-ascii?Q?hnzy6dHaMzuQgCbqXAOjLeYVha8yc9XwLKTPJ930W2r/tEdVgvBaiE31rXCu?=
 =?us-ascii?Q?AnJQqBorsdjGxWMEgghBcmp2x9eIKkRj8J694ZrsAlRIFn6JT/5PloiPVQwQ?=
 =?us-ascii?Q?AokuBhUCRxXdr/VhG4p7sE4J0RyuzmZjgppBRw2cFLKP3lEzizEfRSZ4e9i6?=
 =?us-ascii?Q?jy5hmU05T5w+yR6uyuc+GjXNQr3XNzM/Jok5xaYvqv0YfagM3xgmmr2yzE46?=
 =?us-ascii?Q?fDZeUtTjLD0Amjz1OH0ltQBNH6bHfCfEbFBcnfMs1ztnEYOAybGxUDoft690?=
 =?us-ascii?Q?coqGT4xP1fZgnoD+gWV4N8oCtsAPLaSsa2IwBuZpMgQ7aoirgQZESPXO/AD+?=
 =?us-ascii?Q?zsq5jcg3OqmGmDJ7WsKOfdRyEzhDXeiMC4SG+m3GqeXGHLoY2zb52jcphidO?=
 =?us-ascii?Q?e/OYCJZfOUKg+xZLRoZoZUe8bT6CiRGmZi6DABRuj8CYfSUfOTcRPCiuFh+9?=
 =?us-ascii?Q?pbqGvKwrWejhDtTJW/EdAsZNYjHb7+xPaaAIuiUX+ITInEkK5WtEz20s5f/+?=
 =?us-ascii?Q?OA15aiewfpEdEYFSBISqn4e4V5FW/oBgbjxTTdGCT1n0z0xmu8fPtXo6GfZ2?=
 =?us-ascii?Q?WVP6BGvNvEjxQzzMd6pK/P8XW1tvMczLFsv4iaqEA1AKmNrT+o7L9PDq9gpA?=
 =?us-ascii?Q?M3lA7uOaEi4NMh+Rbc7v2xXJIwlywZWEc1nQpBtkx0uAtSkTbatMIWPsJhyh?=
 =?us-ascii?Q?00Hkv9uF6068hS4ZlyQ9B6V0zvnFsQDbYoBDKfUWSN1MV8gqhuS0dD8/tO3V?=
 =?us-ascii?Q?QSe4d/EiVk5k4mzV/yh4yBDAYfzTkD3MNu2T1G3ofWn2b38GQ7jfbskmLMIV?=
 =?us-ascii?Q?so0QLIvW0TUpjx+eXate5Zd+lyOP0HiXj0kHRECEDzZ07IzldwrmsS85Wemk?=
 =?us-ascii?Q?aEEyfctu3VF6lKVC1sS/exOAgLtLMs/ZJO1B6VVowIp7m5hgCybrpGw87lXP?=
 =?us-ascii?Q?SKDF/z5MmgYbb64vZ9TL9b9MxFmc14ZbBEYrZ8OD?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ccc7ae2-1a1d-4539-821e-08dc3e8d0df4
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 09:57:52.8485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XDQF9X5CZXcG6o0nkGdCvFRk7V1QnlsA27Nd4aKT00xl1KvJiAFcejQk+pjAxp2eGhkvhLmZUuzUfU8UIhX6xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8504

In current driver, the counter will start firstly and then be configured.
This sequence is not correct for AXI filter events since the correct
AXI_MASK and AXI_ID are not set yet. Then the results may be inaccurate.

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

---
Changes in v5:
 - new patch
Changes in v6:
 - no changes
---
 drivers/perf/fsl_imx9_ddr_perf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
index 4e8a3a4349c5..52234b97d0cb 100644
--- a/drivers/perf/fsl_imx9_ddr_perf.c
+++ b/drivers/perf/fsl_imx9_ddr_perf.c
@@ -543,12 +543,12 @@ static int ddr_perf_event_add(struct perf_event *event, int flags)
 	hwc->idx = counter;
 	hwc->state |= PERF_HES_STOPPED;
 
-	if (flags & PERF_EF_START)
-		ddr_perf_event_start(event, flags);
-
 	/* read trans, write trans, read beat */
 	imx93_ddr_perf_monitor_config(pmu, event_id, counter, cfg1, cfg2);
 
+	if (flags & PERF_EF_START)
+		ddr_perf_event_start(event, flags);
+
 	return 0;
 }
 
-- 
2.34.1