Received: by 2002:ab2:788f:0:b0:1ee:8f2e:70ae with SMTP id b15csp452897lqi; Thu, 7 Mar 2024 02:07:20 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXMyKkO0n9fZlU3FqjL1USvv869pZLOzh1mafGEEfNvVGQ/L85/Ir3kkG8xT2q6yrDYQM1z//D9ela92R/EbBIJ8ZPdtwKORRyi1Kpipg== X-Google-Smtp-Source: AGHT+IGLr1cxwPQS9ikDn1dV7Ii/tjTPUqDHQaWTgXcciiLFuyeJUgRYB1LI3NEiQidpxJu6IF0I X-Received: by 2002:a05:620a:a85:b0:787:a1fc:b4e9 with SMTP id v5-20020a05620a0a8500b00787a1fcb4e9mr8047935qkg.28.1709806040695; Thu, 07 Mar 2024 02:07:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709806040; cv=pass; d=google.com; s=arc-20160816; b=SEkbpTspGFpDo+h2FEEmV2jGpn2+YD6VSgBvUT/D1vjIfS1UNRdOkq81iXRgw+3Vhq sKXsHvCIBkdzZYwzC20RMY9PHI6KMw/7G8549Mma7RMRi0I1PxUmJ+B12IL0AnvKjayK oGSVIATaQXUh+Wl+g+T5Xs3GlhrnvDdwcR5SE6rjDFbgHmv7kjKtEQxG5dFwUqVkf23z QwRfeBVEnda+nT/aEI8xwTgZe7t+s7weDbvcYWHgxl/R57YEWeqd6p1kERpZG/9H3+RH CrsCGe4PkBiTGfY0GxcsQCWoOjzmaQl0EZ5QJOnffwfcmFx452MP+ct8lHBUYfTw/Brf ufvA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:date :subject:cc:to:from:message-id:dkim-signature; bh=yud+lLLingW7W9RmmT8X5waWeda+HIRaWpRJ0ENXHtA=; fh=x/ceKplH9pQNJc7WLiOOmfjP+wvNcsTnPQNWkxef3rA=; b=EfbjSYTIrLoUzkC7T9bLJoNeG023SIX8jT2IMo0rAkfM5ACn6XGd+KEU748ppssGQz ccQvg0w+fSr9jq9SQ/6hf40JynhpiAv0DmOpDuu/DqpzB6DiJN8g9K4QtXHPKwyP4wns UKLPiMTFBnZh3xMwasPsb0+31+geYkPQ7ORe8wCf9VFvqz+JG4C7AIdrOF4aqinIP8bJ UbIW0q37d0LHkuPyLxzqoZN+kqo+MdFRkSWbbFHzxLHoVK6xu3vpZUrH30mtnIaNlPKQ A4VWumtZgO85h5sZFg4AfYr/JITs8HfT7o5TXvhLWp+VWpSu2K4ZPmSFFfPwg1pgGtmR SaAw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=TOcGzGmr; arc=pass (i=1 spf=pass spfdomain=qq.com dkim=pass dkdomain=qq.com dmarc=pass fromdomain=qq.com); spf=pass (google.com: domain of linux-kernel+bounces-95292-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-95292-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=qq.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id ow35-20020a05620a822300b00787f71c0307si15529529qkn.738.2024.03.07.02.07.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 02:07:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-95292-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=TOcGzGmr; arc=pass (i=1 spf=pass spfdomain=qq.com dkim=pass dkdomain=qq.com dmarc=pass fromdomain=qq.com); spf=pass (google.com: domain of linux-kernel+bounces-95292-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-95292-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=qq.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 474071C20FAD for ; Thu, 7 Mar 2024 10:06:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9BB6B1292E0; Thu, 7 Mar 2024 10:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="TOcGzGmr" Received: from out203-205-221-239.mail.qq.com (out203-205-221-239.mail.qq.com [203.205.221.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF0E21292D9 for ; Thu, 7 Mar 2024 10:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.205.221.239 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709805761; cv=none; b=OWi3T41RlwgO8tXh8uK+EKAZGzEWAj2roixdOj+f28nyxE3ib2NeafFcgHglp4gnuBrpeW9MitzD7e2oUvCTG6IaNFccWm8FmIXHa501zN9nMuWr08ge24axWGFugk3R6WBs6DyWZlj6BQ1r4oqvEDwCcNrHMZcr2yw37cYur9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709805761; c=relaxed/simple; bh=3Wn0tHhJ7B6JwZAL895kM8y1Q1sZYX28Y4p3wQyptXQ=; h=Message-ID:From:To:Cc:Subject:Date:In-Reply-To:References: MIME-Version; b=TD8QEJx2VpfDatlG0vVmzYLnvUovwoyMImutMeCQNPTbVzEBecLt0Lc5H1EeQVlmMl34bp0wnckwiUzVotuekbLHf0QymNB9zkyFMeTsbQOB0fmssh5qNOPqALe3juPnK+SNR+lfqW3u/NeUPyf2ScUJpJ6BpBmPMq0ZJ/s6/ro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com; spf=pass smtp.mailfrom=qq.com; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b=TOcGzGmr; arc=none smtp.client-ip=203.205.221.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1709805757; bh=yud+lLLingW7W9RmmT8X5waWeda+HIRaWpRJ0ENXHtA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=TOcGzGmrrAPHmdncZIycEXVQmrMp323Z5MUBV9/Bn6ejoz+7QuEQvwR08NYDkidhd deAX6c4pyShogmeoTuonpyYY6JijJ9gxKUv7bAjkan7STSKAwL3YJ6UeGU931hn4xq BEG6wLAtpdwwT9lxtW4V/OcCEpQWRnqQafMN9xb0= Received: from pek-lxu-l1.wrs.com ([2408:8409:c90:315:7d1b:6e30:5639:5d6c]) by newxmesmtplogicsvrszc5-2.qq.com (NewEsmtp) with SMTP id 9EAAC10; Thu, 07 Mar 2024 18:02:30 +0800 X-QQ-mid: xmsmtpt1709805750tlz6wg07x Message-ID: X-QQ-XMAILINFO: MW5hkHoBpWXy14vldM0dsxpmQ3Mnm6YeXvWrvW2bzYFZc2BH8W+TNQ37dUNp29 T6UVzEOXdB6/E7dIaWOox+UU/g3QkH1IlzDLUZQXLmNV1J2IrqDyjzkCHvmWmuRS/5cCKGhCMUO+ tpWdH540ATKHWakZ7Jz42vja8vlNy3BFwXuQ2H/14vwRPQAdF2H0/ZhMyt18/elnw+kurIazENLi V1xeRAu5Wl/mvVmKRSECaM0i0c3Nm5fpZroD07dZUUkTcjLO9is52UM2BNFb18hT5oTQvdknHrVI MbLHHnzkJyFg9o9pqniiGh5kc34rqAku4gn+m5obEWL1czZf8/lRtyrzYD5zjxMoH/Q7hlF+o+Xy Gswb3lv01wAfzsc0z4U4d4x6knQVktY8upXuDcDluS8OeCbDRz83Ncu2M0FuxQg2bohkSc7xpbbe VoVBGCT/WK6Sn3OrmfNccgpIoyGT9Be8yKcohbiTc4GRPH22Gxm4A58d9LQsSMze+QN89wi63XnX 8/VinJI2smgA1cbwLMpksvqlgG++WhNjWX0bqIsLTC4b++c7RdmPhTBnyIbFryWWsdpJoOEPQGJO VDqoTQ8stMBvuxzLW/qdQLNQwDrdWRMArR47ixW8PWixkhbmGLa7+/rcNB0r9TaRdzRSSjbEsggJ luotBTglDFsrNBuAiJVT7eLXHKsMYnHQirRrVLYCgCX7hDqPhI1++/QC0gLyBbyANEUU5aou4NFh K90GVwUZ5rzPBs1YeXOK4TeMLYzB/R6P4/N7IzJIxW95s2aGeA/bQvgFnh4v1m3H0mTwr8kuO3fk vTtrqP6eOlcHYGi7JxNehd0N+76UCbFP5FLNtwiUmmBe+JO6lYsuOJ/TkLVYU0/gJzYXfrXAbNmr YZ6x11c1+DZ4l0V5bNH2gsl8NVZ+ZrD5TyGITwgSgM9ML0oEwHum1P8qfhH+rP5NXhPI3GXedmzs nF0w+928i7n9rNc31oYw== X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= From: Edward Adam Davis To: syzbot+3c47b5843403a45aef57@syzkaller.appspotmail.com Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [net?] possible deadlock in team_port_change_check (2) Date: Thu, 7 Mar 2024 18:02:31 +0800 X-OQ-MSGID: <20240307100230.974510-2-eadavis@qq.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <0000000000004af86e0612f195c7@google.com> References: <0000000000004af86e0612f195c7@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit please test dl in team_port_change_check #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index f575f225d417..590412701402 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1212,7 +1212,9 @@ static int team_port_add(struct team *team, struct net_device *port_dev, goto err_port_enter; } + mutex_unlock(&team->lock); err = dev_open(port_dev, extack); + mutex_lock(&team->lock); if (err) { netdev_dbg(dev, "Device %s opening failed\n", portname); @@ -1309,7 +1311,9 @@ static int team_port_add(struct team *team, struct net_device *port_dev, vlan_vids_del_by_dev(port_dev, dev); err_vids_add: + mutex_unlock(&team->lock); dev_close(port_dev); + mutex_lock(&team->lock); err_dev_open: team_port_leave(team, port);