Received-SPF: pass (google.com: domain of linux-kernel+bounces-95299-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <01c09e14-e991-4c3f-a747-3cfd591c56e8@oracle.com>
Date: Thu, 7 Mar 2024 10:04:41 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 2/3] scsi: libsas: Add a helper
 sas_get_sas_addr_and_dev_type()
Content-Language: en-US
To: Xingui Yang <yangxingui@huawei.com>, yanaijie@huawei.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        damien.lemoal@opensource.wdc.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, prime.zeng@hisilicon.com,
        chenxiang66@hisilicon.com, kangfenglong@huawei.com
References: <20240307093733.41222-1-yangxingui@huawei.com>
 <20240307093733.41222-3-yangxingui@huawei.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240307093733.41222-3-yangxingui@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?N0dYU3BWU3B5aElTdVVadlVnVng5NU1Hazc5LzBrZE5mZFhVOEFyWUxkUEpl?=
 =?utf-8?B?MldxLzB5TWx0WVB6RnFDZXZpZFV4TXRuRm1mMCtHakpEWEF1Qm9YbXQvTTBz?=
 =?utf-8?B?U2FKME5UWGYvZkdOOFR5L3N0eFUvd1pUaEgxSXRrTEF5aG5oT0JsR3dRTVg3?=
 =?utf-8?B?NzR6blZudDdETkVzT2hydEdZbnp4a2ttbVFPdEhoYnpwVkF2aDI2R1ZRbG91?=
 =?utf-8?B?UzY5bjlOMFozS1FWYXg5aTRqNWhzck9IVUVFUnEzWkhSaXZqYm9HN0hBNWdp?=
 =?utf-8?B?MS9GWmYyZ0VYQ2hjWWhyRUFQdFhlM0xhUHdVdUtETUtZaXdWMnlvak4wUmpD?=
 =?utf-8?B?WGMvQnE4T2IwOHlEV2RtRTRpa3BoMmM2Y1ZYS0dwWnpkTks3YmhqNE5rVEJF?=
 =?utf-8?B?cXVRaEE0NHNTZG5uUE44WHkzeS9vTldxeTg4eFVKWU1XdWN1ejEyS1luV3gx?=
 =?utf-8?B?Nkt5ZFJWRDJSQ25uNlZUcmxPdGZhN3BZaERUQzJPaEZPL1ZIME9CVjRjQ3dC?=
 =?utf-8?B?OGpLSzlmVmZONDZPeUU5OU1qbWdJak9CSDNHb1VhZWR5ZlVESHlZQWlTQjMy?=
 =?utf-8?B?Tkhsang1Z1o1VjJzYXFjamt6UzFPRkhUd3ZQS3g2V1BZM1gzQjhrWWFPT1BP?=
 =?utf-8?B?dG94aE95RlNCdUFweW1QbzlkbnJXVzc1b2dpdW5KcjllOTRXNE9BdWI0T3FC?=
 =?utf-8?B?K3phM3puZmZJRzVVeGNOVlh0eVJjd3JFdTBqekFuR00ySzhLOHc5aWJ5TzNS?=
 =?utf-8?B?WXA1UXFrYkpNZHRFcGo3TjBEQlppSXg3Y296Zmw0eHhJcWRZQVZqM09uWlVO?=
 =?utf-8?B?RkUvMUNDMHBGbUc4a0M0WDEvSE1rYVlYSW91NVBiT0Z2UlFXUzI5N1UrU3pp?=
 =?utf-8?B?b3RhdzJINmJVNmxOK21UU2tkaGFYOHF1eWpvY1NiMmFTeTlnUXRqd0FoSWpu?=
 =?utf-8?B?c2RCYTlmekwrdllFZGlKSDVWQzhRMHh4RFkzYmtDTnQ1bjN2RXJKVDlNYXIx?=
 =?utf-8?B?T3ZrcS9YL3hlMUJOZzErKytBQXArNTRzQWZReVc1L1NWazNOR3hkOFVvMEFD?=
 =?utf-8?B?YkdPN1ZHRVJMbll3bzFvUjRPOVZWSXZ0YzdnMXpGME01WXAwK1pOMnlVdFl5?=
 =?utf-8?B?SnVITU9wQzdmWWlQak0zSzZCR2RNMUFVVkptRmdXdHczQzVHSDdlWGJEdUxl?=
 =?utf-8?B?aHR6YlZCWHBLVDgxWnhJUjVETWhkWGF6V0xkSUdydDNDdVZ2bmc0MlhXZHp2?=
 =?utf-8?B?ZVZBUjZ3SFcvM0RmMnJWdnZVOUxiUFh0SGUvKytiUTh2bGJLT2djVU54ODlz?=
 =?utf-8?B?aDJrdzZSckRGYzZRY3ErM3A5MEQxN2lqVjhOWHJJZ3MvOXV0QSs1RzF1T1dT?=
 =?utf-8?B?c2kySlN5MG04VGtiUm01eldvZktGU3Fqak5hZjVWREg4b2o5akdwUTZVV3Nm?=
 =?utf-8?B?TzJ0MERKbjJtWE5xWThNU0tMYWlZdzRtbm5xNmVaYzlaN3ZIbXNhc25lc21S?=
 =?utf-8?B?eFJrZXRxczhqdU16TGJvcHRMYStwbHVlTy9JVDM2UWxXc3RFOUw4SldjR2xW?=
 =?utf-8?B?K0lzREVmaWlBZXh6SWxSR1NMTEEwVmF0MTgyNmFVRW1kaFpXYys2SG5ZSnMr?=
 =?utf-8?B?SlZEcS9LZmpjdi84YWdHWUVJK0RZdmtVamxmQUNsRWc3clpoSkNHN1Q5YzVF?=
 =?utf-8?B?YzFndlEzWmF6U2g2cnRXc1lpWE9VN3B1U25WeFZWL20vSis2a3ZiTUlTNzhH?=
 =?utf-8?B?WkdUVDZWSzdzS2phSUxDKy9Ob0RaQy84MHdJRGp1blQzWHBRZWk3aVV4cGxt?=
 =?utf-8?B?ZUZrL05oWlROenROcVFIdG9vdXYrbXVJQm1iSUp4TVdEb0ZGR0h5RnArSTVn?=
 =?utf-8?B?TmtrM0pWbVV2SUxmOFNMN3RMS1Nhd0U3NWhhWHRjQmRNb3VUQjdhMjFXR0Ry?=
 =?utf-8?B?OTlOcVEyK1F1YTJ4Yi9KKzlscklMTXFHbVpseWQvQTlwdlhGd05wdjErRmoy?=
 =?utf-8?B?bmg4RWF5Q0tEMHNBa25RbWsyaVBQcklUYzJYZ09DWm5BbENzSHBVckpSb1RQ?=
 =?utf-8?B?V2ZBYUxuZlZVRFd0Q05VUWRTamgySi9RR0RENzJMTlZad1prbWR0TStybDJl?=
 =?utf-8?B?SUlweXU1NzNSTEVUZUliZ2NQQmc4RTdUaWlKTE8zQTJZSEdleGs4aTlnYTg2?=
 =?utf-8?B?dlE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	DMNofHAVmEn9m1wi5q6zMbB7IiLAHbsTgcMJONi0VueABZyxxR7c/9+R+ZfAPs+yVwh4ECVkTgqdVtsyXJ7kZADCRYHLFEr4HDnDqh8brAf+/+qzAQgCWJTVjoFnHgjw+gyHPZZ4rKqBFjGXtzakebTCtwMuwt+pW18s4K1Ubexr+Ra6VdPwknWrn7OYkacDGay7AGeR0ju4+IT6Ts3Qq7oR9EquQ+o4W+XiOyvGNEEy6RAxP7zKnipfkCA8VMIryRkQzeCAkzItt4gG5wLzKv97dtds86+3hmt5rXkWVdb3L4W9UmYtfEO33N6eyPzxAmeM11yN1ZccpKtv18/MB9DCmoBP5h0d4Un9G0jhfTT58+I7Q/U/N0KaE757KA3/xmt2lEISrj0i5H0n5qlL8Q2yFhntvDw920UQ8H3c2cnxHkI2ni4JneAHiavc9VzcuIuAjFdqPm9aDteQjXHdoipC7CZwupAoDU0EkL7Q9UutFvO8lqIah0V+NMpAv+KZ9PwNyNQnx7x1LA28MW63s6KJNCJ2GcPEWcTiUdILznWoCAS2hb9SkgjRd/2h/9X/W34RN+orvQDpV0NJURBfph+00laAvjknToGvNZR6lq8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99dad832-6c1b-45a5-3904-08dc3e8e03d1
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 10:04:45.2313
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ogbYF3bOzJ3ZKZb1wXdYzFM8D+yUfSHzRwmNFaMgmjlOuQYIA+a74zvVy96P6gIEkWHnh/tCNRa4mumXZhCNjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6142
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-07_06,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999
 spamscore=0 phishscore=0 mlxscore=0 malwarescore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403070073
X-Proofpoint-ORIG-GUID: v0vLrvm9cVxrIg4v5vLjFkxbkzKZ7Xam
X-Proofpoint-GUID: v0vLrvm9cVxrIg4v5vLjFkxbkzKZ7Xam

On 07/03/2024 09:37, Xingui Yang wrote:
> Add a helper to get attached_sas_addr and device type from disc_resp.
> 
> Suggested-by: John Garry <john.g.garry@oracle.com>
> Signed-off-by: Xingui Yang <yangxingui@huawei.com>

Reviewed-by: John Garry <john.g.garry@oracle.com>

> ---
>   drivers/scsi/libsas/sas_expander.c | 19 ++++++++++++-------
>   1 file changed, 12 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
> index 1eeb69cba8da..d6147616339f 100644
> --- a/drivers/scsi/libsas/sas_expander.c
> +++ b/drivers/scsi/libsas/sas_expander.c
> @@ -1631,6 +1631,16 @@ int sas_discover_root_expander(struct domain_device *dev)
>   
>   /* ---------- Domain revalidation ---------- */
>   
> +static void sas_get_sas_addr_and_dev_type(struct smp_disc_resp *disc_resp,
> +					  u8 *sas_addr,
> +					  enum sas_device_type *type)
> +{
> +	memcpy(sas_addr, disc_resp->disc.attached_sas_addr, SAS_ADDR_SIZE);
> +	*type = to_dev_type(&disc_resp->disc);
> +	if (*type == SAS_PHY_UNUSED)
> +		memset(sas_addr, 0, SAS_ADDR_SIZE);
> +}
> +
>   static int sas_get_phy_discover(struct domain_device *dev,
>   				int phy_id, struct smp_disc_resp *disc_resp)
>   {
> @@ -1684,13 +1694,8 @@ int sas_get_phy_attached_dev(struct domain_device *dev, int phy_id,
>   		return -ENOMEM;
>   
>   	res = sas_get_phy_discover(dev, phy_id, disc_resp);

At some stage - I am not saying necessarily now! - it would be good to 
stop this function returning both a linux error code and a SAS protocol 
response code

> -	if (res == 0) {
> -		memcpy(sas_addr, disc_resp->disc.attached_sas_addr,
> -		       SAS_ADDR_SIZE);
> -		*type = to_dev_type(&disc_resp->disc);
> -		if (*type == 0)
> -			memset(sas_addr, 0, SAS_ADDR_SIZE);
> -	}
> +	if (res == 0)
> +		sas_get_sas_addr_and_dev_type(disc_resp, sas_addr, type);
>   	kfree(disc_resp);
>   	return res;
>   }