Received-SPF: pass (google.com: domain of linux-kernel+bounces-95305-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <b105b26c-9c0b-4315-beeb-7879de85d240@oracle.com>
Date: Thu, 7 Mar 2024 10:08:14 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 3/3] scsi: libsas: Fix disk not being scanned in after
 being removed
Content-Language: en-US
To: Xingui Yang <yangxingui@huawei.com>, yanaijie@huawei.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        damien.lemoal@opensource.wdc.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, prime.zeng@hisilicon.com,
        chenxiang66@hisilicon.com, kangfenglong@huawei.com
References: <20240307093733.41222-1-yangxingui@huawei.com>
 <20240307093733.41222-4-yangxingui@huawei.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240307093733.41222-4-yangxingui@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?R2svbEcvbCs5bzlteWkrRjNlV0s1WlUrRTVhd0hwYlN6OUFkdTVpd3FhcTJI?=
 =?utf-8?B?aE1tdEsva0JDakFuQnFibDM3Ym5PNjU4Q3o0U3dmb2NZM0NmMWNMN2tmYUJ2?=
 =?utf-8?B?SFNjYlQzbDA5TkJnQ1oxLzhFVm85dy9EbVRmZGpaRytPUjVxSCtCaVMvTmZ3?=
 =?utf-8?B?NW41OFFwcFVUOThEQnZJN3VGQmFRdlZSRjl3M1F0dEpvRnVuQ3pLV3dpWWs5?=
 =?utf-8?B?bEZ3dEhtVURya01wYVRIRm1ROFQwMXJCc1NyWFBDY2VlS0FVaFhvKzlKVi92?=
 =?utf-8?B?WmY1eFI4eWoyMXNpUWY3a2N4WFlNdU5VekJVM3N2a1lhdUo2VEt5QkZYUVFj?=
 =?utf-8?B?aE4xcVpROUxiaitmbE53VnJrRnQzSkgvQnJKRFBacWtNdDJncnZVRlFjaHZj?=
 =?utf-8?B?d3JVc2VlU3pvMXMxM2VNa0NBemhNdWpoYU04dnRKamp0ZzRMNldPaFk4ZnlG?=
 =?utf-8?B?SVNQYTBQemFpNUdKNHZhYjZVTmZxbkV6UlZEYTBPTTMzTTV2ck90WFd3SzRO?=
 =?utf-8?B?L3ozSHJyQ2RsdmI1YTNRU2lNM2lPRmI1ZWZlTllMcUZabTFuUnRqU0lTS2RY?=
 =?utf-8?B?c0ErRkNtWHJKL2xJM0ZnNDFINTg4d0Q2SEJ6NjdIaXdEMHlYRXhWVy9CNTRy?=
 =?utf-8?B?SzJyem1HYS9zbkJnczZyZTZVeG1ZYmg1RFl5TnNneGdZUFJzNzN0b1Y3UVdH?=
 =?utf-8?B?bEtNazFQbzVnNlZkM2pIbGhVdlFrTmdaOXRaM0hUMDlXVU9FeHJ4bDJzWFlL?=
 =?utf-8?B?U1NMNjE0bDJSSEpuYUNOSVZkZ25QMUFGOWZoNTRkcjF5V1pxZG5La08zeHIv?=
 =?utf-8?B?UDFLWjluay8vYUNUWHV6QTVKVENuTm8xRzVJWW8ySTVZSEJ3RlVNMEE2akpN?=
 =?utf-8?B?bE1GN0l4dEQ4Q3ptWkkrK05iUUtCK1FUL2FpWGFZMXg0WTYxWmNKMmNDL3Av?=
 =?utf-8?B?RiswbmwxR1YrT3IvVnQxZXZreEdkTEYxd0Y1WHZudHpkYjUvZzJCemhrWWZL?=
 =?utf-8?B?Z2Rva1k1NmNMUDBEKzZER0N0bVZ0MDJoMDk3M00xRGJHMytqaFJjNm1xK0M4?=
 =?utf-8?B?cW1DbnJMS2RzM1RwL0NnTzNFS05raWNwellJWFBSSmRFNUUrbWd5STlaNzJD?=
 =?utf-8?B?TktETHZCNUFLOEtDRXd3UytuUkpYVnB6N2dMaVZMVVB2MHZ4Wlp1RW9pNWVK?=
 =?utf-8?B?bU11dHpzUjUycTZlVUdycDlPZ2hxR2xSZlNnR0MvbkpNMFE3U2xRWHZJNzdr?=
 =?utf-8?B?NnVoMlZsU2xoVGVUWnBSQzdwcGU1YVovcWNOdnRWVUhtM2QvaEhQMGhSbmNu?=
 =?utf-8?B?ZFppcmhUTlVhMzBPbGVSOXg3cmdjVUJKM1VlTFB0am5GM3hEcHB2S3hWRUZp?=
 =?utf-8?B?MDlHbjFnWlFpQ25TRHBhblJOaEFkOW1uTnVzQUtBZjJHOGFzN0ZnbkNyZzBr?=
 =?utf-8?B?aXFKMHE3NTlxYWdDRDlLOEx6d0JlZ2FRV29LNHZMZXNhM2tiSmNMNWhiSkFy?=
 =?utf-8?B?VWFrNUlSMWZVTlAvc1JTdEJOT014dlZmaG9wWVRTQ3NRaFNpQWoxVDZBczMv?=
 =?utf-8?B?bGdqR3hTWEVYSko5SWpqemZaeEZzUUlhZWV6QkhDQ25NTjhLVGNJcXVsSHRS?=
 =?utf-8?B?aU8xQVFJY00xeGFlZ3FuczI0TUl4TlFLWStPVVBIK3dmcC9UYjJVcHZzMnNO?=
 =?utf-8?B?am01d3BvUWh5cjhlMkk3RTIrZ0FRWVlyaVU5WDgzbmxSbjBrSmJjaVVoemYx?=
 =?utf-8?B?OVVJS2FCVnd1bVkxWUg3bmd2dS9kRVVLTFd5UEhnbXhIL2w5cjBQYTJGMEZI?=
 =?utf-8?B?ZDZJUzIrQTNwTWIwWXJ1cmMyb0UrMFRUaHNONkE5WjhrR0FEaGJ0RWNsczd0?=
 =?utf-8?B?R0xXUFZITlZZWld1THR5MWxLa1ZJWXVKL2IwN25uZmNLYUs2bHd2NlZHMEha?=
 =?utf-8?B?NUkwWjk2MlJMdVlEQkdTMGptQ1NhZ09qQmtrU2RPU2NxaGQrb0gyZjVlVnpE?=
 =?utf-8?B?dXAvZzBFWVVKQ3BIK09RelJ5QWgrdnhoUGs2TFpCY081MmNUa3JQVFhwUi9W?=
 =?utf-8?B?Tm95UjJDSFRFSklqbmNTT3ZlTUtjcHN5UGRLTSs5cWw1WnoyYTFFTldkNmJo?=
 =?utf-8?B?ZUFhNDZLUjRxMnJPclZFcG1LamlZUmtHNmRDUTZ5OFE5bUx1QzllS0JINVZa?=
 =?utf-8?B?N1E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	n19/3omtYWIm9vve9VzmQ/KNWHp2qM9nmdv8s8CBG2acJuQOeiEgF3S2IUUQ/70qoHv57wxqq0GxVPL28Lkn4EkFpNKsbDabYSIVmAtTMGoU50DE6OLEj9grOFzXpeAEpeC2NkjqoLK5L3HeaU2xu/5KZACoz9q93RnMF7QMHmOARIxZHrOFkZkkQukPgwiFoJJZjgdC+8d3WUIN4/M+JmeDzhwWy94LTh4t8wen00z6plD1tUONG8MSe0SQQv/AxjNLvR3v2LyEWxkxT0tBhQn/z1qhVehU1hYT13bLcVPTC4xA7iKGiMF4RzTUaEsy3HGS/wIlDamjlAmW/vNiIHApOBDtZXuEykpOyI2gmZm6/N9rv339KCR8ucpvLLhVzSI0ORAn2P+qH6qnQ8SczO6mQd5SVgXkXxXgBgIiIx5+apCqFp+tnC5tJuRZf6s6InoZQoPmhDRssppq0BxN0+Z1CjsmN7v7JZ85UAm/HcEs4w8u08Jgzm+dI4QHvz7nl/0jWS+K/aMADs+ifhA85g9i16wPfwT41+H8FRurI3EPH5sOyIebRKTTFxepybW0Xw+zoxDv9PDV38WUkoGvcM2cydsFkMQgHhR/dIt8ZFY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfd00553-26b9-4e83-65ec-08dc3e8e833b
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 10:08:18.9490
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fEdg/4GDbL8HecMKwVhJenL8695rPaiW/nEo/opAPaO0Jqa9GBrP2p2aWVamPbwhTb012UIAeYFr/ak9wfhqmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6142
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-07_06,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 adultscore=0 phishscore=0 spamscore=0 mlxscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403070074
X-Proofpoint-GUID: ufdMUiOq-VFSHh6cjouzpkrj4-fcYrCx
X-Proofpoint-ORIG-GUID: ufdMUiOq-VFSHh6cjouzpkrj4-fcYrCx

On 07/03/2024 09:37, Xingui Yang wrote:
> As of commit d8649fc1c5e4 ("scsi: libsas: Do discovery on empty PHY to
> update PHY info"), do discovery will send a new SMP_DISCOVER and update
> phy->phy_change_count. We found that if the disk is reconnected and phy
> change_count changes at this time, the disk scanning process will not be
> triggered.
> 
> Therefore, call sas_set_ex_phy() to update the PHY info with the results of
> the last query. And because the previous phy info will be used when calling
> sas_unregister_devs_sas_addr(), sas_unregister_devs_sas_addr() should be
> called before sas_set_ex_phy().
> 
> Fixes: d8649fc1c5e4 ("scsi: libsas: Do discovery on empty PHY to update PHY info")
> Signed-off-by: Xingui Yang<yangxingui@huawei.com>

I am also ok with a change to revert to allocating the resp memory with 
alloc_smp_resp(), but make the changes neat please:
Reviewed-by: John Garry <john.g.garry@oracle.com>