Received-SPF: pass (google.com: domain of linux-kernel+bounces-95289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <a382d713-f2d7-4b92-99c7-3b2cc066179f@oracle.com>
Date: Thu, 7 Mar 2024 10:01:14 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 0/3] scsi: libsas: Fix disk not being scanned in after
 being removed
Content-Language: en-US
To: Xingui Yang <yangxingui@huawei.com>, yanaijie@huawei.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        damien.lemoal@opensource.wdc.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, prime.zeng@hisilicon.com,
        chenxiang66@hisilicon.com, kangfenglong@huawei.com
References: <20240307093733.41222-1-yangxingui@huawei.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240307093733.41222-1-yangxingui@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NWRUcUE2WndldHVjWFlneHptbWhyaXE2emJoczR2M2pGem1zTm5kRE00TW1q?=
 =?utf-8?B?aENkRzZ0d3BtNEVobFdTN2dhYkFVS3hkSlN6Y29NUVgzV0tBZ1VFWUhndERG?=
 =?utf-8?B?QUVMZEZHQk1pZEFjays1TlVUKzVEN2RWb2Z0a1J0RlFiT3U2cWhQcFc0S2k5?=
 =?utf-8?B?OTR6cUFiTFZBaU9tUzN2cVdseTRJRitHRUltdjhEV2M1WjhyQXRrWTRJS2JP?=
 =?utf-8?B?TG9SU1cvZWp3cDhUWDZydzNRZUZsbiswQzBMVk5NVU5reFZiSFhieHI3NTBN?=
 =?utf-8?B?K3QvQUxITG41TUxaQnczb3p0OWJSMmJpL0RucXpXZ3NVY1lNZnB5eUxTYzIx?=
 =?utf-8?B?V3BQOVh1VlM1aDN3NnBzMmU4L1hNVk9TTjQ4Y0pDaDM5OTFJbUdmZEZhN1N1?=
 =?utf-8?B?a2J1bEZHNVorN2RMS0xpNkMrdVBydEo4RHNLaVVFbGx2c0RrZmdOZlY3Y2w2?=
 =?utf-8?B?TzI1dEdrYTNvQnZLdFVBcytER2V2b0ZvNm81cWhnV1ZCSlJDRXBjbGFIaGVL?=
 =?utf-8?B?dlNiVHl6MHJFTGFUNnFoQUp2aVNMcDBTaWp4Vm1VTUoxWTZMY2FsSEpGLzBO?=
 =?utf-8?B?cW5YTG0vOFlIckY0ekVUWXB4Y0tuVXo5aGlZYXZ0aWhadXNsTlhnVFBlMzJM?=
 =?utf-8?B?aWJwTVFnOUo5d3V0UXB6OGVYaVNlMEw2d1ZIMDNGWTErTHVhOFBYMXJPYS9j?=
 =?utf-8?B?ZlhrRzNEYU9TREZqeW44QjYzK1JmSWx0UVlRSzFGMzBWSzBUZU16WkYzdDZO?=
 =?utf-8?B?eW1iWHBVajc0Q1AzKzkybnJzNENpWmJHenZnYVV4eklwemVFMVlkVTFseElS?=
 =?utf-8?B?ODZ0dVZncHlmeEtIU3ZYVG0xeStMeUVlYnNUTUZCZ3dQaERYK1BXWjVnUXN2?=
 =?utf-8?B?Z0hxOGhJc3hTQTQ2eHdIVGV1ZVFBY2o0YXFOOWpRb0ZRWjhnRnR2QWk1bUhZ?=
 =?utf-8?B?K1I4bVJ6eHpJVmRxZWVFQXl1OFJQSVN3cXk1N2NGbTJYNVBQUGQyZXY1eEI2?=
 =?utf-8?B?V0dvQjAzNjROaW9Ocm5MbHgwN1ZuWnk4YmxQa3ZIdHlCRFVIMHU2VTRKV1dO?=
 =?utf-8?B?YUY1dXplWG1EUkVoZ0hoTnhSdmluT05mRHg4SWhqY3krSlVQZ0Y2VUt1UUlp?=
 =?utf-8?B?L0MvNHZjK0RSZ3ZacjU0eHA4SFJZVHVKNGZRMWo4dUV5eXg0b0todE5vZHV4?=
 =?utf-8?B?VTR3Sm9kaXZPQndlWlp3eU92NjRDa3pyR3hEejNvNG1LTjBqS2hKVzhkLzhQ?=
 =?utf-8?B?bFdEdGpvNWQvQkR4cnlybFRsUUtUbW1oc0tmRTFRQytOcnp5bS8xRzlRcWs0?=
 =?utf-8?B?SjFaVEkwdE1hTXJQdWp4eVhPSFJ0YW1OOWI0K1ppdldscDFJMkRUc3locmZv?=
 =?utf-8?B?S3dpQy9SS1NGd3lZQVpPN3NObmM4dldHOEx0MU1Dd3h2NHBYUURnWmNDYU1F?=
 =?utf-8?B?NS9XWEVXdlFaWElhVThuRVJEaTNON2VUVDQxYjdlTDNBTHN4S2hmSy9zaC81?=
 =?utf-8?B?dWt5dTNXSXk0Yjh0VmJBK1lYMFd1b2diWVFmTEZRVmJ0SExGY1R2ZVpSWGZx?=
 =?utf-8?B?c0ZuZk1QRXNQSWhyTVlGZ0pvQUl4a1M3V3VwSzdya2tuUVZ3WkV4VGgzSVFM?=
 =?utf-8?B?NTlzVmVBaDk2Y2RrMnhxZk5oWmliaFdZZm40ZDlJT1EzYXJMOGpCa3RUS0VF?=
 =?utf-8?B?L3paQlVvNlRPY2J2eGpZM1p0RWc3VXBveDJNUjlQOXJja1VqS1ZwRkRXREd5?=
 =?utf-8?B?QUV2c0FTQ1pWY20vaVFKVkY2dzJJUWxmQk1FZndRUkdBdnY2eXlLeHlDU1ZI?=
 =?utf-8?B?VzFodmtBbFpXOE9OczZsaFM1YWFuKzFhS1ZZRk1taWw2ei9rRmFaSTlGVTdv?=
 =?utf-8?B?dlRLZG00dlU4UEV4WS85aHJDL3ZNUHJBUXlMZzZmUUpyMXJOcnl0Z2lCZkVY?=
 =?utf-8?B?L1RHM3BGd3oxWHMrQTkrZ3k5ZjhTNEV1RE02SmswUHJ4d3dpSlFyUmxrTE1S?=
 =?utf-8?B?c1Fpa0ZFZkZ1MVFvNzZRdFpJdkluWmUrbGxjb3RlSS9MakpiZndXRjRXQStM?=
 =?utf-8?B?aVV6YTgzejdDWnNQaTlNWHEzU0VGRkFiUHRzNTZXcmRkYkpOVXFmOUdRTks0?=
 =?utf-8?B?T0ExQzZMVFU0K1NNVDhYSlliTzhpS2dQUnNpMFdGVG1PL0RBV1czNzBYVFIz?=
 =?utf-8?B?TXc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	uBOWlij4vbfuGPgnAUy2Qkl61YjsI08v6GixeEcCdUzQsynBcs0MuKhDH5ZGOr72YE5vR4iwRRqj4Cfcoo5ebEZVr8/YT8gMkdukGuMbAsc0AieFv+H1EKoZpmcAKgQ/eJrQHeJttWweWYnMJHp7sILNB4UT1rwFGPrdCLO6v9aHEAxrs41+uamIkQnZR5q4gmufOEs/n/lghtuPMjJTUNzBpouAUwasjjWQleS5qcFWOolcmL9pwnAvPlfl22fNaXLXOn3DzN8CMB+T+GgotDPxurEBqer32EbETkqLlPW73mNc1C1ltNZnJBeoAAoubh+W4jzrimD8/0bS1COSaheGWEwH9WjD4F0SbtaAqFZQTWzo1+bhxcnA9k2c8Zsi3mQS8SiQLCooqxvcfblMutjlqrs0mdYjxVYyx76TBuvqCjv9SW0NF8kLE1v3yMBH9gsYhoAicAV3nUCadGLhRGst4tX9w9tmAoUwDrgL3vOmFjSEm6CokqZti0HRy7AFqk5nisL01GMWquIPRHeSxgO2gebQr8zn9JyUSFWSXOWfMSXepI9rtL6SsGnWb27T2kOhTYzhKrDgOJeLjAx/8DWBm2KORER5aMcCxh1739w=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae271ce5-ef12-408b-af0e-08dc3e8d8911
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 10:01:19.2648
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qcj2RzrFvm6MVRWMuNqYB27gjVlGo6aIkPrjYnnsK58mQjmO/1k5ZR8v0DlR6QST5Pq2qUiJG5c99Gz0P0bODA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6331
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-07_06,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 adultscore=0 phishscore=0 spamscore=0 mlxscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403070072
X-Proofpoint-GUID: NpiZO7uDzAXW_HBBIg9A_56qPwnrkxjw
X-Proofpoint-ORIG-GUID: NpiZO7uDzAXW_HBBIg9A_56qPwnrkxjw

On 07/03/2024 09:37, Xingui Yang wrote:
> This patch series fixes an issue when do discovery on an empty PHY to
> update PHY info after device unregister could cause newly connected device
> to not be scanned.
> 
> Changes since v2:
> - Based on John's suggestion, allow smp_execute_task() arguments to be on
> the stack.

You can't just change one particular smp_execute_task() callsite to put 
the disc memories on the stack - they should all be changed.

Better yet, we should see how the changes look and then decide to change 
at all.

Anyway, since you are simplifying the code, let's revisit the 
smp_execute_task() change later.

Thanks,
John