Received-SPF: pass (google.com: domain of linux-kernel+bounces-95331-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <a485fbdea26e19afe00f603bd65c83e2be20abe6.camel@sipsolutions.net>
Subject: Re: pcap-dbus.o:undefined reference to `dbus_message_demarshal'
From: Johannes Berg <johannes@sipsolutions.net>
To: Anton Ivanov <anton.ivanov@cambridgegreys.com>, Waqar Hameed
	 <waqar.hameed@axis.com>, Ingo Molnar <mingo@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, 
	kernel@axis.com, Richard Weinberger <richard@nod.at>, 
	linux-um@lists.infradead.org
Date: Thu, 07 Mar 2024 11:29:45 +0100
In-Reply-To: <2cc222b7-618c-46a9-b78b-eb099d0f4be7@cambridgegreys.com>
References: <202403052336.y6DkUd8a-lkp@intel.com> <pndzfvbibgm.fsf@axis.com>
	 <87cfca1e-3f53-4935-a274-0920bce86373@cambridgegreys.com>
	 <463be980baf66b967031e3294c3b9745b07aa058.camel@sipsolutions.net>
	 <2cc222b7-618c-46a9-b78b-eb099d0f4be7@cambridgegreys.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-03-07 at 10:27 +0000, Anton Ivanov wrote:
> >=20
> > How's that required to be formatted and loaded? tcpdump itself can also
> > dump the filter in BPF format, with -d/-ddd (-dd is a C representation,
> > so probably not useful). Perhaps we could even automatically call
> > 'tcpdump' at runtime?
>=20
> That is one option.
>=20
> As far as common use cases are concerned, at present you can:
>=20
> tcpdump -ddd, convert it to raw binary (3 liner in a language of choice) =
and pass that to vecX as a bpffile=3D
>=20
> It may be worth it to make vecX also take the -ddd format directly by add=
ing "format" options to bpffile.
>=20
> I'd rather do that instead of invoking tcpdump out of a device open. The =
-ddd notation (+/- a comma here and there) is
> standard - it is also used by iptables, etc. It can used by other code ge=
nerators as well.

Yeah, that makes sense, this is all kind of special configuration
anyway, and given that it's been broken forever ...

I actually doubt anyone would scream if we just removed it, so maybe
just remove it and if they do scream, point to the above, including said
3-liner in the response?

johannes