Received-SPF: pass (google.com: domain of linux-kernel+bounces-95307-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
To: Vadim Pasternak <vadimp@nvidia.com>, Daniil Dulov <d.dulov@aladdin.ru>
Cc: Mark Gross <mgross@linux.intel.com>, 
 Andy Shevchenko <andy@infradead.org>, Darren Hart <dvhart@infradead.org>, 
 Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org, 
 linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
In-Reply-To: <20240306153804.6509-1-d.dulov@aladdin.ru>
References: <BN9PR12MB53815F52C9033DC526085827AF232@BN9PR12MB5381.namprd12.prod.outlook.com>
 <20240306153804.6509-1-d.dulov@aladdin.ru>
Subject: Re: [PATCH] platform/mellanox: mlxreg-hotplug: Remove redundant
 NULL-check
Message-Id: <170980618467.1921.15643030796886976535.b4-ty@linux.intel.com>
Date: Thu, 07 Mar 2024 12:09:44 +0200
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Wed, 06 Mar 2024 18:38:04 +0300, Daniil Dulov wrote:

> Pointer item is checked fo NULL at mlxreg_hotplug_work_helper() and then
> it is dereferenced to produce dev_err().
> This pointer is also dereferenced before calling this function and should
> never be NULL except some piece of hardware is broken as it is said in
> the comment before the check. So, this check can be safely removed.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/mellanox: mlxreg-hotplug: Remove redundant NULL-check
      commit: 576b82c3c9bf021af4984aafc105508c99660667

--
 i.