Received-SPF: pass (google.com: domain of linux-kernel+bounces-95412-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Sunil Kovvuri Goutham <sgoutham@marvell.com>
To: Jijie Shao <shaojijie@huawei.com>,
        "yisen.zhuang@huawei.com"
	<yisen.zhuang@huawei.com>,
        "salil.mehta@huawei.com" <salil.mehta@huawei.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>
CC: "shenjian15@huawei.com" <shenjian15@huawei.com>,
        "wangjie125@huawei.com"
	<wangjie125@huawei.com>,
        "liuyonglong@huawei.com" <liuyonglong@huawei.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE:  [PATCH net 6/8] net: hns3: fix reset timeout under full
 functions and queues
Thread-Topic: [PATCH net 6/8] net: hns3: fix reset timeout under full
 functions and queues
Thread-Index: AQHacIH5VlO91nqK4UmHdb6rsYfgfQ==
Date: Thu, 7 Mar 2024 11:24:09 +0000
Message-ID: 
 <BY3PR18MB4737FA1796C8BC8180296BE8C6202@BY3PR18MB4737.namprd18.prod.outlook.com>
References: <20240307010115.3054770-1-shaojijie@huawei.com>
 <20240307010115.3054770-7-shaojijie@huawei.com>
In-Reply-To: <20240307010115.3054770-7-shaojijie@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?KPiPGIdY9jXHDUrVYgUzqyIr7UsT+NvXX9dSH4aIK11FAJjVHCT7m7KQ3JIc?=
 =?us-ascii?Q?sh4fkvKsP180Y7Y8N+ATyHC1tBp7ziXwe12Y3+6TIKY6vr/6YBQgWJp2jgJ6?=
 =?us-ascii?Q?pjzI37/mZ4DybqA+DXEdEehU1dB+dVjizooe5UoVITumklcPoMv+u97gkG8/?=
 =?us-ascii?Q?C/Od0Px+FHxf3bSgFg0oiGMhb0W+fWI1+j9GKdSWaeMbXoVSxRRXNJExdi0X?=
 =?us-ascii?Q?e70El113OU+f95Tlku30ZtTRRj7FaZrtWdJJGBoJOsy/sjmV5DYkDvHjlO13?=
 =?us-ascii?Q?+myxKTnEdx1biY6XM4NmT7NHqGYx9PMxE48LDtwAiiQTKsnl2V4Dfn3CPgHz?=
 =?us-ascii?Q?qf5n3WD8GoLVbMgNfH+36UDzTUQoUJbY/ug3mBsAzSsUbfjimt405ob1GvfJ?=
 =?us-ascii?Q?ujFNdONMQ+nfeWLkDD3uEZWmcDgmMzMEE0C4USu2rdDMgJQq3NipiZ2hlvRF?=
 =?us-ascii?Q?xUOGcghipiOgrMEjmo9MgsKcQLNL7cKVEli1/IOzxOztcQy0/Z6FHLBliur4?=
 =?us-ascii?Q?Sk/LuI0DGLs7tFAMLz/pXkdxH9tYnbfY/uPR33IegzQidMlJ1NDp4sWf+kpi?=
 =?us-ascii?Q?HG3jMp9OigPTaX8ZQ8TwV5fOcBKH7dfmTQ0uhoE80jzLv2mfy/B6ABFbXah6?=
 =?us-ascii?Q?uzkYnYsMsa8unTvyNc2bpckOUxW19t4kA7vjuDdvJ9qSFFCkcDvx4vC/rsV6?=
 =?us-ascii?Q?nEjM/L6iHptBf7AnzIyFdhJfVA8xmYT2Lte4DEJRYtdaj8J/QWFkPBNarBbe?=
 =?us-ascii?Q?+piWVFCnEVoakGArr1j84dmYHXpW3Me4Ebn6IpLriymNQ6kjy3Khi/UOGyi4?=
 =?us-ascii?Q?JGvw06i8PoWKZHRWdP7LPWJQxWTpylkx7U/8YzEM224DRAEaSOsgmASJ5dPU?=
 =?us-ascii?Q?TO8onebR9c3QcUE+8GYPth8oN+ZZHijlFiyZQo0V00FQ8WJwMb+I94FkVpl4?=
 =?us-ascii?Q?oW/SAnGsrPpAOjknLLs490RTfTMQ7Dtye0LpTn5mepUsSH+wIg5x4QsjSvNo?=
 =?us-ascii?Q?FnHnb7Ok0jOoLoAf9+qywAm5teenO/JGfFBMbo3+WJ4wMmE2ZZt7WX10pdmC?=
 =?us-ascii?Q?oHsy/CQ2mtYTO/NQxX48CDiMj26nSjrEiwk13bluerDf2MlsrDUQ5NHZOAx/?=
 =?us-ascii?Q?12MOKY5jltaEI6zhkdZMwBKs4/zGL/jHmmkeZHg1OhX/HkWfiOOHcago1Mt+?=
 =?us-ascii?Q?2EJeq7Ee+hCScNyNGz/XU42sssDaY1wNiTtkZpDdbrjFVd5jk0hk4Sd52j0c?=
 =?us-ascii?Q?5r+zswF1dddRAgVQYplKrK3S4NUd0mJoh4njcUeciirWtKedKz0xAJ4eyVQr?=
 =?us-ascii?Q?wpTgnxit4ZNnaRskFB/VWb9wx2xSDuJKHqYePuPlp77nDSms5FNtAf4t2f44?=
 =?us-ascii?Q?yje9iRjsXP0800CeWUAGEl2qybjidd8Lfs1lxRWTHH5mc+TRk9QpTDAWobZ+?=
 =?us-ascii?Q?0Ma1K1GNaCL6fdJRtDjOsmOT1OsAXQAFtv4yw59cvbu1Hm4yUFaRKXnALJWm?=
 =?us-ascii?Q?4JuJPfDjFulzRww561GR1Fa+do8ky2mDyApQOUTaQmwWY9h+LynbVSRl8GfW?=
 =?us-ascii?Q?I1Xjw90Y0jzJi8QJduHXeyKhG9fF4ysB2IePhLNi?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4737.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7bc8c39-64c6-4e29-ecfb-08dc3e991ba9
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2024 11:24:09.4758
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H2uOpi3J4WpRzILHM6XDRGU/Fkl4360oZLq8E1Zg6yBDHCzSraIYCWeyF/u7MC6lGF2bhzl2J/5RS2t8W+ROhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR18MB3694
X-Proofpoint-ORIG-GUID: WGK22gbNDWa6swa6X7uHMhDMLcOx2n3d
X-Proofpoint-GUID: WGK22gbNDWa6swa6X7uHMhDMLcOx2n3d
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-07_07,2024-03-06_01,2023-05-22_02


> -----Original Message-----
> From: Jijie Shao <shaojijie@huawei.com>
> Sent: Thursday, March 7, 2024 6:31 AM
> To: yisen.zhuang@huawei.com; salil.mehta@huawei.com;
> davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com
> Cc: shenjian15@huawei.com; wangjie125@huawei.com;
> liuyonglong@huawei.com; shaojijie@huawei.com; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [EXTERNAL] [PATCH net 6/8] net: hns3: fix reset timeout under fu=
ll
> functions and queues
>=20
> From: Peiyang Wang <wangpeiyang1@huawei.com>
>=20
> The cmdq reset command times out when all VFs are enabled and the
> queue is full. The hardware processing time exceeds the timeout set by th=
e
> driver.
> In order to avoid the above extreme situations, the driver extends the re=
set
> timeout to 1 second.
>=20

Reviewed-by: Sunil Goutham <sgoutham@marvell.com>

But one observation, loop of udelay(1) for 1sec seems a lot, probably bette=
r to use usleep_range().