Received-SPF: pass (google.com: domain of linux-kernel+bounces-95451-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <8628b57e-3087-4fb5-9e8a-03a1b4b8c31a@intel.com>
Date: Thu, 7 Mar 2024 12:41:36 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] net: hsr: Provide RedBox support
Content-Language: en-US
To: Lukasz Majewski <lukma@denx.de>, <netdev@vger.kernel.org>
CC: Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>, "Florian
 Fainelli" <f.fainelli@gmail.com>, Vladimir Oltean <olteanv@gmail.com>, "David
 S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, "Oleksij
 Rempel" <o.rempel@pengutronix.de>, <Tristram.Ha@microchip.com>, "Sebastian
 Andrzej Siewior" <bigeasy@linutronix.de>, Paolo Abeni <pabeni@redhat.com>,
	Ravi Gunasekaran <r-gunasekaran@ti.com>, Simon Horman <horms@kernel.org>,
	Nikita Zhandarovich <n.zhandarovich@fintech.ru>, Murali Karicheri
	<m-karicheri2@ti.com>, Dan Carpenter <dan.carpenter@linaro.org>, Ziyang Xuan
	<william.xuanziyang@huawei.com>, Kristian Overskeid <koverskeid@gmail.com>,
	Matthieu Baerts <matttbe@kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240307113352.345388-1-lukma@denx.de>
From: Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20240307113352.345388-1-lukma@denx.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTY5Zmhiai9nVWt2YlBSaFFTeDhFdlkyOXFaMDN1R3BZbDhUZjBpT1lnNnlj?=
 =?utf-8?B?RFFOd3RDUUlobFBoTm5MVWJxNWcyRkxnN29yZEgwclJwbUpualdmQm5Gc0tI?=
 =?utf-8?B?eEZUUjZqN2ErYThwUm9kRWlKYkpLeFZpcnBuV0xJVWhTYndFVVZETlNJTEp3?=
 =?utf-8?B?OUpja1hxUTlpNExqeGRmb2VuWEl5TGxDMGhPaFM2dGhXcDhBcU5ka0luc294?=
 =?utf-8?B?NDhLSzNrcjErZGNIeGttVEt4K2Z2dStLZXJoQnVaL3RXaFhzN3BzVDRqNUZD?=
 =?utf-8?B?OEtzaFZmanJ2VXlDOUZ4empvK21QaUc2cG5KaWhaZG5QZ25ZWlBkeE9sa0NW?=
 =?utf-8?B?dEVaTWxSQlNRdXJyemEvTmdGM25sckdsT2lRTGV3dkFXY1YwS3hJWG5XY0ZN?=
 =?utf-8?B?NS9SRjc0blkxeXJWZURkUmJTNVc4djE4djJ5MjhvNmlQaFR6TWFzWUJ4ZzdC?=
 =?utf-8?B?TEVUTUx3M2VxVmdlNVJQRTJjYTF6ZU9xMmF3c25MSDZEanhtRzUybC91QVM3?=
 =?utf-8?B?VTUvRERIU1lsMWFVUXJqZkQ1bmhDaU5xMmJCY2lQKzNpY1UvT1VIT3RKUTVZ?=
 =?utf-8?B?TWhVZVgzdm5oRnhsR2VxK2c5em45TnpNQlNRd1V6YkRaek1FV2ZleHpKZFNU?=
 =?utf-8?B?b1B2elNOelVDS2dyalFWTW9yTStaN2cvYnEzNG1sN3FpbGptZXhZZFFiNU4w?=
 =?utf-8?B?NnQxN2kzRUgwRlZJOHc4cnBQMzRIZVRkRVZlbDMrbFhvRE95a3FVZGEvZmxJ?=
 =?utf-8?B?WlZ6R0o3K1VmbUJ2MGhJa3owWlFCd2tNRVlzSmJ4SVlPK1RUZ2pmeGRwL0J6?=
 =?utf-8?B?TWdzNHoyeWhjSXRvdmpMTG9SV0pQODFTc3dkdU5ydWQzNTBEKy84dmFEclM5?=
 =?utf-8?B?dGxZbUlHQ2tDQ3RLdkhYaEtDUmkyVGpOQXA5Q0FEOThYdTBBYlI2QTdjYVIw?=
 =?utf-8?B?UmhzcFdpSlBLTit2ZnZEUjVWWWxOeXBOYktFUVpVMzdqaHV4SFBvblFoeUEw?=
 =?utf-8?B?bmEvY2IzZzIwdUZDRGQxM2ROMjA5Z2ZmUHhFNi9DNEFHV0hqNHJpanl0MHZp?=
 =?utf-8?B?YjFaTHlkNldvenpVNklKWkFhUkd4MFUvQ2c1anl5a2daK0tuWVBNem1MRW50?=
 =?utf-8?B?NDVzSDQraE0vYXdDYy8zNEovNkhuNnhiaVRQQzZDWWpvU2VKdHRpam1ndThG?=
 =?utf-8?B?MkhpOGJOYTdwbUR0b2JmNVZOVnY4Mk5GK1NFUVVpSVQyblh2YWE2eVl1aVNh?=
 =?utf-8?B?c1NUcWtaOTh1aHQ1MTJ6ZUZlSEZoNzRGblJKTmFzRU80bCtJNVY4WTVzSGhB?=
 =?utf-8?B?MmhPQmQ2bFpYNkpRV1A5QUxWUUduWlJKR2lJK0hzTTA1OW1DYzZ4TzJsQlRY?=
 =?utf-8?B?NVo5NlJJcWYzY3h0aDZkbUt5dko3TE5mR09laXN5MXdiUVZsSlQwL0NhVHJR?=
 =?utf-8?B?dVJnVTdNSlZYSXVZUDk0cXRESFF0WUpWekl2L0NhdzVLd1BHM1NMSXdpcmhv?=
 =?utf-8?B?Nmt2Y0M1UDFLR0RBSjdKMjZtK2l5OG83d3VLWjVEbnMwcFdtZ1VkbGFSbDZ3?=
 =?utf-8?B?ZnlMeXlIc2tRdlB5aWhLQlpqSFpxSHNLZmh6ci9qTUhlWE1PZFlnZVpRZkEr?=
 =?utf-8?B?dnhPWHJ5aitRTnQrdkFQMm80RlpFbC9vUTJqeHpGbmxwTzJKWWVKM3QxbUdz?=
 =?utf-8?B?UnR5bDNZazFpZ1RyWlNZelJLSGxDT3VCYlNEOXlKMytvczVaSEd5TDZwNnlK?=
 =?utf-8?B?Zi9HR1Q0SlZxS2xXckdkdm9GOEZLclpOL01NcWllcUFmNUxGMUJPWks5V2tI?=
 =?utf-8?B?eXdGeFNjeFMvZjUrcUprQUdIckNFUkVRUGhDRDRscElVNUZKTE82L0huWjNP?=
 =?utf-8?B?WUtmUldRcVYvSDJZOFZBdFExR2NoTnQzRGR5R28zOGp5eU1OWFlyQ1hpRklx?=
 =?utf-8?B?em93TlMyWFB1OEYwYzV6anJ0SnM2NFFweEhybUdTeVhnNzQxL3BaSHpYeXBi?=
 =?utf-8?B?d3hLVkRtWHcxMWYyYXpoR1c3Uk4yZlFMRXB0YjN2ZUxVZW01NjBuSTczazJV?=
 =?utf-8?B?bkdtTG0zUVVjYkdBMktKcGFFUmRvOHFQMk42aDNEdEVYckRMTUVMK3FHWVMv?=
 =?utf-8?B?ZjJaeFM0OVFxM2l4cXlIa3J0R3h1UnlMRElua3ZLeGJMa0d3VVZTS09tZ21K?=
 =?utf-8?B?VUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c19b408-551d-4245-5ddd-08dc3e9b8fea
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 11:41:43.7527
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Spb4x7/J0AjAKM50O+CKZYRaZTc2XZ9mC4enBYvK/yLfUIgH9V2vsp32WLqxUn37u2Z7mDwRHikwsIMORC2SfHVCHMVv+lfleTIMsk5K2VI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7192
X-OriginatorOrg: intel.com


On 07.03.2024 12:33, Lukasz Majewski wrote:
> Introduce RedBox support (HSR-SAN to be more precise) for HSR networks.
> The 'Mode U' has been implemented without optimizations for traffic
> reduction - i.e. only sending HSR supervisory frames to Port C and not
> forwarding to HSR ring frames addressed to Port C.
> 
> The corresponding patch to modify iptable2 sources has already been sent:
> https://lore.kernel.org/netdev/20240226124110.37892211@hermes.local/T/
> 
> Testing procedure:
> ------------------
> The EVB-KSZ9477 has been used for testing on net-next branch
> (SHA1: 709776ea8562).
> 
> Ports 4/5 were used for SW managed HSR (hsr1) as first hsr0 for ports 1/2
> (with HW offloading for ksz9477) was created. Port 3 has been used as
> interlink port (single USB-ETH dongle).
> 
> Configuration - RedBox (EVB-KSZ9477):
> ifconfig lan1 down;ifconfig lan2 down
> ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision 45 version 1
> ip link add name hsr1 type hsr slave1 lan4 slave2 lan5 interlink lan3 supervision 45 version 1
> ifconfig lan4 up;ifconfig lan5 up
> ifconfig lan3 up
> ifconfig hsr1 192.168.0.11 up
> 
> Configuration - DAN-H (EVB-KSZ9477):
> 
> ifconfig lan1 down;ifconfig lan2 down
> ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision 45 version 1
> ip link add name hsr1 type hsr slave1 lan4 slave2 lan5 supervision 45 version 1
> ifconfig lan4 up;ifconfig lan5 up
> ifconfig hsr1 192.168.0.12 up
> 
> This approach uses only SW based HSR devices (hsr1).
> 
> --------------          -----------------       ------------
> DAN-H  Port5 | <------> | Port5         |       |
>        Port4 | <------> | Port4   Port3 | <---> | PC
>              |          | (RedBox)      |       | (USB-ETH)
> EVB-KSZ9477  |          | EVB-KSZ9477   |       |
> --------------          -----------------       ------------
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

> 
> ---
> Changes for v2:
> 
> - Add deleting of HSR_PT_INTERLINK node to hsr_del_ports()
> - Rewrite handle_std_frame() to awoid code duplication
> - Fix reverse christmas tree in hsr_prune_proxy_nodes() as well as
>   remove stale node indication as interlink doesn't need this detection
>   (only check if node is inactive for more than HSR_PROXY_NODE_FORGET_TIME
>   is required)
> - Rewrite commit message
> ---
>  include/uapi/linux/if_link.h |  1 +
>  net/hsr/hsr_device.c         | 36 ++++++++++++++++++++--
>  net/hsr/hsr_device.h         |  4 +--
>  net/hsr/hsr_forward.c        | 58 ++++++++++++++++++++++++++++++------
>  net/hsr/hsr_framereg.c       | 52 ++++++++++++++++++++++++++++++++
>  net/hsr/hsr_framereg.h       |  6 ++++
>  net/hsr/hsr_main.h           |  7 +++++
>  net/hsr/hsr_netlink.c        | 29 ++++++++++++++++--
>  net/hsr/hsr_slave.c          |  1 +
>  9 files changed, 178 insertions(+), 16 deletions(-)
> 

<...>