Received-SPF: pass (google.com: domain of linux-kernel+bounces-95493-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <685223a2-4a67-4b70-8726-5a666224b2b5@oracle.com>
Date: Thu, 7 Mar 2024 11:51:01 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 07/14] fs: iomap: Sub-extent zeroing
Content-Language: en-US
To: Dave Chinner <david@fromorbit.com>
Cc: djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, brauner@kernel.org,
        jack@suse.cz, chandan.babu@oracle.com, axboe@kernel.dk,
        martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com,
        ritesh.list@gmail.com, linux-block@vger.kernel.org
References: <20240304130428.13026-1-john.g.garry@oracle.com>
 <20240304130428.13026-8-john.g.garry@oracle.com>
 <ZejcyPPX3bVdvJyV@dread.disaster.area>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ZejcyPPX3bVdvJyV@dread.disaster.area>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dzNGQXdTRVozTXdCNk9TNThDRnlEMERqcGVhRjNjRXFQVlJPajJXa09TM2FC?=
 =?utf-8?B?VkdNeVZMUVI0ZUJjanlQdCt3T2IxT3BhMTcwWmxIelBlQWN2eVZMTDc3RDNk?=
 =?utf-8?B?eVlONDdMdzFURkY5aXhsQXp2UUQ5MFBxZ1gwQ1U0MkQ5emZkSUh3UzljV1hy?=
 =?utf-8?B?T1lwZFFsbFUxT29MUUdJR3J2TDFhR0RVZnJaVWhBeUhwSWtrZ2hhOXZIYVNW?=
 =?utf-8?B?V3hzZTVqSFRxWjVsRjMwSENKMWdFdS9vTWJCRHc4OHVvRlk5K052RHVqOUZX?=
 =?utf-8?B?SkZoV0o5VjNVbVBNdzl0TXlwUXBwclNNUEdtaUcycjhuK2tTQ0dDK0JhTHY4?=
 =?utf-8?B?dnFzNUdmVmN0aU5nbERUY292a0d3Mm43RWxrV2RNMVpNMHJ6Mlhrdkk5MU5r?=
 =?utf-8?B?TThJRVF5K3FGNHBQa3BKcjZndFlJQlZ5cktPNWtrWWw3TUtldXJKdlZmYXdQ?=
 =?utf-8?B?UU9FR3QwclBxQ2tCVWkrcnRqTi9pUE9uV2FXd2l3c0c1SjFUNVpKU3dUemZt?=
 =?utf-8?B?aTJMb1R0MEdTd3pQOXVSdmZ6OGptYTVBeGJDUXgxWVJiNGJ0WHcvVzlSL3Q0?=
 =?utf-8?B?dDZrSEpDL3E3ZHBuUEtTZUhLY2VlZmVtclNTb20zZzR1c2tpUUIySlh1ZkY3?=
 =?utf-8?B?RXZXSjFZRHhZcTRpVm45dmhoMVVBVG9hZlFUaVJBVmtWUTVEOFliTi9DRnhW?=
 =?utf-8?B?VTJLRFJjTmZrL0xHVUloRUhrQjAzaHhuNEJ4b0RRUlBkdFp5cDVWMTJVT2oy?=
 =?utf-8?B?NVhnRjVTSWFnbkY0amppMTJyNEtBNWRES29kVWIwSmU4SUplWHhldnlseVNt?=
 =?utf-8?B?OWViWnU5NE4yelpCTXdYeW9PRndzR1hOSFNscXFad2hKTUtWbFZwSU5uVUVB?=
 =?utf-8?B?QjhxNHkyUEpsbVQ5N0dkTjJZdEJnTDhmRDF5NXprUVllRkpFOFlRNDZESndJ?=
 =?utf-8?B?SytjbGNqWmRIYnptcW1IdElySmEzMzVkZERGMHhScUUxWkNEaHBXaU9PQU9L?=
 =?utf-8?B?b1dQenIzd1VRUGNKY0U0VlhWQjB0Uzh3S1JXaWIwLy9PcUJJSGJSaTlUTEh6?=
 =?utf-8?B?aXdGQ2MwS21JaktpSXNvbVh3L0FXc2pvQ2ROaGVock5xT0IwU2RTZkVHaFNP?=
 =?utf-8?B?Y1R1c1ZOWmxNTklMcDBYSTNEV0ZXMGM5eVBXRlVUQ09lcXF0R2VzdEgvNURu?=
 =?utf-8?B?dE16RVZpMUZveVI5VkRHQmRkMG5XQXluUHoxREJLdWcxNU5YaW9mb0dIUncw?=
 =?utf-8?B?NkF4TDJYb0RTK2lJVlBKZHBRNVlTcVhlOE8zL2Q1dzdYd3J0M2tpaGFzSTZl?=
 =?utf-8?B?eWdzOWlGVDdsUi9Sb25tbGNOZ2VaS0kxWG1rbFNNZ01hYzlqT3pQdHl2dE01?=
 =?utf-8?B?QkNCNncrSSsvenI5YitEekVDd01pa3hMb2Rva2RUNmVRYWJwU1hYaHNuOXZF?=
 =?utf-8?B?V0xWUFBGNjU2RTdGYkRGalZpYlZjZ01CNldoQXk0M1NINGo5TzNuRU9Mbmlv?=
 =?utf-8?B?WlMyaGdkMGlWaGdha3M2MFROamV4blh2QTVnWUtEOGxPTWo5RkhneEk4VlZG?=
 =?utf-8?B?U1Y2RzU4Q3N4OXFkRTdhQUMyb0hYRlBSRkVXQ0puRG40RS9TcGEzWnhZYXhY?=
 =?utf-8?B?SEEwUC9wL3F1NkFqMkIwNWV3bVA5UDRBdklMNSszcEdleVIxTEtqTVZydngy?=
 =?utf-8?B?Wm83dmNqekw1Ym9WVi9NRXBFT0tFYjYzaXB6dnpiWmlGTFVxcGlpSVdVRWcv?=
 =?utf-8?B?UkRMYkN1U0EvT0U4OVo4c3VaYXRvZmFTZVMxMzBmNTZoSUdJSS9zTnptemp0?=
 =?utf-8?B?UVZRQWtSWWJ4VVg0endQNmZ5SzNOelJUVXptOEV6Ulg0Qm5yZkhseTFIdUQv?=
 =?utf-8?B?TS9uWUFPTUhqNXk1bGkwVFNtV0R2V0E3MHo5WEo5aWtDMXVJNHpaZ1FReVpk?=
 =?utf-8?B?VlI4NWxmdzFrN1BEVmowN1FxRVVBd3V6MFYzTTUwK1ZNaFFqTzZmc29ZR0U3?=
 =?utf-8?B?MUd3VW5YZ01tZnNjdVZwOFQyMlg2MXkyTnhMcGJVczZCbHBLeExWaDlTaC9q?=
 =?utf-8?B?b09RZU5Iam1RU2VUREdSN3M0RWxLc2VYMmtZNk01cVpibGtDa2xVRlpGYzJ0?=
 =?utf-8?Q?LVejT4ClnmWL29yT1kpOMYqW8?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Si+qXiV2rA0WiW/6H9DTmnKDpfL8HiLJA2Ow2x46CNPEWopKgS6KEXDGqF4PuwDy5JRISr2p28eStp63KAATTQELvweRI+QZBYklX2FRPlSwLL46pTzIKb/Ex/AdU6BNSTtXORgN/WY/eD+xke0KbJFccfryzKTr+g448j2nym4NgVk235ytwwy2tE+Ennlp5wz68Fqh7qFb7X4dmFftmW0lHKGJRecRT0TPYPVDt9+JoHwsJgI1rzXKrgXBBnD3Rbavd7Bz5+7wHsUxl7QH7z9YsFBrXRtKsttqD0PH8kHqirdNg2DS/BexpdxFdBlF51eKXC48ekaqsuUDQljfiBQNdm4RzrOPfAoZbqpsrNMenJA6yCq048yQx9ZqVOFYFAAv+nCqcUouqlee90meMjPVe9CM9sAsJ7o0IUZaJ3+rkYVPxKDCDULikzpiXMWt8JSHJfWlVQlbCHBIGvHs92WdcUJkdFrjehMxjV1MlsX5cvln9vS9xdUmVbQlqq6WsJucJFOEyLkaO4UTJvkhubS8BhMbfcIWJNUyERhJonImdJD4Mbs2EIfuPwbP2RbjlCS0mOQvqvKl1odbYSylRhhQE6Pk96ng3T9WVNnwQJg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95cb3167-a6df-4757-6c2a-08dc3e9cdf26
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 11:51:06.1316
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wNdLfGK5OMSz3Nd4gF39QoSSQxFHaLOOp2kowxAhyRZ2D2M/CEbvTlHINfzqFR7MFYwpanrkWW+HCXKQ3+vA8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4202
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-07_08,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999
 spamscore=0 phishscore=0 mlxscore=0 malwarescore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403070087
X-Proofpoint-ORIG-GUID: ehiwCwK9Bb66FTrXgmirfTyFq0rIUkQ6
X-Proofpoint-GUID: ehiwCwK9Bb66FTrXgmirfTyFq0rIUkQ6

On 06/03/2024 21:14, Dave Chinner wrote:
>> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
>> index bcd3f8cf5ea4..733f83f839b6 100644
>> --- a/fs/iomap/direct-io.c
>> +++ b/fs/iomap/direct-io.c
>> @@ -277,7 +277,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
>>   {
>>   	const struct iomap *iomap = &iter->iomap;
>>   	struct inode *inode = iter->inode;
>> -	unsigned int fs_block_size = i_blocksize(inode), pad;
>> +	unsigned int zeroing_size, pad;
>>   	loff_t length = iomap_length(iter);
>>   	loff_t pos = iter->pos;
>>   	blk_opf_t bio_opf;
>> @@ -288,6 +288,8 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
>>   	size_t copied = 0;
>>   	size_t orig_count;
>>   
>> +	zeroing_size = i_blocksize(inode) << iomap->extent_shift;
> The iomap interfaces use units of bytes for offsets, sizes, ranges,
> etc. Using shifts to define a granularity value seems like a
> throwback to decades old XFS code and just a bit weird nowdays.  Can
> we just pass this as a byte count? i.e.:
> 
> 	zeroing_size = i_blocksize(inode);
> 	if (iomap->extent_size)
> 		zeroing_size = iomap->extent_size;

Fine

I was also thinking of something like i_extentsize() for vfs, which 
would save requiring adding iomap->extent_size, but decided to limit vfs 
changes.

Thanks,
John