Received-SPF: pass (google.com: domain of linux-kernel+bounces-95498-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <5e7eb717-d810-4dc3-80b0-3baaa20ca41f@oracle.com>
Date: Thu, 7 Mar 2024 11:55:59 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 14/14] fs: xfs: Support setting FMODE_CAN_ATOMIC_WRITE
Content-Language: en-US
To: Dave Chinner <david@fromorbit.com>
Cc: djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, brauner@kernel.org,
        jack@suse.cz, chandan.babu@oracle.com, axboe@kernel.dk,
        martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com,
        ritesh.list@gmail.com, linux-block@vger.kernel.org
References: <20240304130428.13026-1-john.g.garry@oracle.com>
 <20240304130428.13026-15-john.g.garry@oracle.com>
 <ZejhNMW5o0JSCgqW@dread.disaster.area>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ZejhNMW5o0JSCgqW@dread.disaster.area>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?L3JZcXNrVUZ5cGhmbS9xSHVxYmNUei9VMDBiTU53SEROYnA5MlF0OW55UXBQ?=
 =?utf-8?B?Y2NlTTBjbTZDYVk3V3pMNjVlTFZaUElKSWp6MHBMOFI3ZXFqNWJuRjdaMmpI?=
 =?utf-8?B?eWZ5QSt4NHpQNjlxSGJ6eVBFeEZ3MnhPRXQ3L2MxZU9TMTdvUk1aVlZlYlln?=
 =?utf-8?B?bExtRkRqNFM1QUZ0Y0l2R2lNTUxZclZ1VVNWaDVmZkc2Y1RHSHVhVTdERWtn?=
 =?utf-8?B?L1cwaWFpR3BzWmYrcFVlb1RCREZKQ25yT095ODJIZTRHbTNSZ1NmeTVIeG1y?=
 =?utf-8?B?NGVvZUJ4ajRiUTRUUFh3RW5ka0pyYWNzdE53Q2IrOVBYbXRhaWlRK2xkRGY0?=
 =?utf-8?B?TzN0M244aVhvWjFTL0F1cWdybGF3Yzh6b3dlL21MR0JKVEdtKzAyazkxT0Yr?=
 =?utf-8?B?Z2VHc0JKSHVORVB3SjFmSExGUzd3YmxZN29pVHFLSmNITUJqNkZUZ3pJTXNx?=
 =?utf-8?B?emFOL1plYUhSTmEzeE1hcGtxdjFhT01xTFpNQ2ZXRGdYTlQxUExtVWNPOGox?=
 =?utf-8?B?cHdkSXRuWHhpRGtoL3VnVjgwemxkb1RRQU1ZdzA2NHlxRjdIQjE3dEJydmMr?=
 =?utf-8?B?akdEcldadERlb0NEc0FDY2E3aW9nMDkxMzZEMldTM3M4bTI1ck5MYzZodldu?=
 =?utf-8?B?RGJ4RDdJZzg3ZmZkQXI3WG1yZ0s0cnRiZ0pldmd2VTBXVGdXNlFqT3g4eEZq?=
 =?utf-8?B?bS9OdlI2YjE1UTBQL2pWU1k1TDZTWHA3OW1jMVB3UzIyWU5QNUhFVEJCRGRl?=
 =?utf-8?B?RnBHOWk5ZWg4cXZjeHEyRTlXT2x3V3hYK2hRaU1Tc055clZSMlZ6MjE2RGlQ?=
 =?utf-8?B?QXo4eHJXKzBVcTlhRTBneitLS1BUbjNlZEZSUWttWGQvSVNDalc1cEhmNXJt?=
 =?utf-8?B?MzVWZUdYaktmdXBIZTh4VG56Q3RsT0x1b01DMXhwMVVoMGJyYXZIVExlWTVS?=
 =?utf-8?B?emRaZnBWVDMrSDI0WTNTVTgxd05adkVrNHdDUDlSQ2dEYS9BaWhud3VTMFo3?=
 =?utf-8?B?UEwxbE1OakQvSjZuV1YycGZjcWJYbktveHZ3Q1UzcFpkYzRTOFhONmRtWXV0?=
 =?utf-8?B?cEJuUzNwQlE3NHA3VlhxbWt6MUhmZXFzaGNGT2Z3N0YwUkxFSGtRS2pIRzMx?=
 =?utf-8?B?SEhwUEt5Um8zQjR2alViTnorb2VtWVBGZS91V01sWEorbHl1cGVmSjV3akt4?=
 =?utf-8?B?TUhmNXlYL3lPMWJETDNjNE56SVFpN0F1TTZzZ3FEUk9IWHljSHRvaDVwN0NJ?=
 =?utf-8?B?LzVwYSsyd3I1UUxsNVhXUC8rSjRpYnJaR1pzVStoUU5GQ0d4V2Q1aHMycW1B?=
 =?utf-8?B?UWZBcFlQOHJQYkxBMjNMMlZ3ZkY3ZHZiVWRvaHhDd3dpQWlxTlIzWCtqbDBM?=
 =?utf-8?B?d2NGVGdYY0tBYnhvai9UTlpob2FVa0U0UUZKNnFhQ1lpQm9ueUJFdGZXaktM?=
 =?utf-8?B?cEtxY3ltMG02cEpmeFhxMGhMTGxlbVliQjk0U1p2ZnZ5RU50RmdxVE5qaGRh?=
 =?utf-8?B?Y29ja2VNdUx1ZU00NEVEREY5RytLOUNQQldaQnovbk9NWGtLMWhLS3BkYWRO?=
 =?utf-8?B?TzR2RGJJV08wSU5qMmt3YmFJMHQyamxDdmd4QnRHc0cwOW1VV3JhRGNTS0dq?=
 =?utf-8?B?alAvZi9senBZNFE4VVdpbTVQZmVwbkQvQVBEVGtHR2FpU1R4M1JXUW5pYSto?=
 =?utf-8?B?NnAyaUo1c1BRWmlidHJhc3JlZ25NRjg1a2NNM3dFZGVMQlVJUzBKKzVEOU9N?=
 =?utf-8?B?amU1cERCNDBNbmpwa21RVDlOVmZQQmVEK3drYUhaT3BDdVhhWFU2RDZZRklr?=
 =?utf-8?B?TFUxUUNyMFhiYkhZTzIxS1Q5OHM4THY3d3JWalVvSi9yK0M2bHpjY1h3Y0or?=
 =?utf-8?B?ZzI4ODJSRHM0VC9KZU1vNURXaTEvdHJRU2xqNlhVMU9wazVHUU5DdUlaYTJ0?=
 =?utf-8?B?cWpObWVybDZGbFI5RUlsVHpQRHRRZ2hOLzlLT0lzQlMvaHQxUE9ySVo1SHBF?=
 =?utf-8?B?bFJyQUJyOHY2TUllUkIwZ2FNTmdEWHRWdEYrQ3VmT3d4QzNwT1pEM0UvUkJx?=
 =?utf-8?B?SDVoSE50NE5EbnVoN2RQQTVqZ0MwZ2NlNTUzSTlpTVFlNkgvbWMxODlPTFlG?=
 =?utf-8?B?aEdsMUVkQ2FWbUJRQVd3VWJPc2lmUjNhYUdXR2pReFVyK0lMVVZvSlNpSCtF?=
 =?utf-8?B?VHc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	VfIELLDZnecccmw1QeiYVKL2CQ7wWUZTp7f3ahuRMEt1UVDXhwtUdx4v6lQFZfxzUwd66evSbmhI5c0Qc7t+3S05SJJjavbuPJM2lKxIe9XyDHUaJPHY96OZEMRLo123VydToMQDrix2DNBrzgaPBBz3tpCcA3ceDma/GsD0wxSQmm4LQb02UE5g1t1whLfaczAvb/949HqhmafHYmuW4/NQI2Y57VMg/tNGfwC9w+xl8aN/iWkmayCPevKsb8sPx2jjjTLg+iwRBHJj3APLDIlG3Jz9jdAYIJSHYRuc72K3OHjmDAnRChk6Gm7+zxK8x9WeqTCeXxuQG1hK+UqXvqfqn6Gb4Ja7HPjrKarG9xVUJgg6lByXNFiSSSc0dS7PvECmZrW8WWMFN86MW3kSm7a3aowUqfpvwNs1ZbHO8XWHagKSorZpjGwCOOboDOT9o7EYUNHtFoP94gkzRNWM1PLkwbgKZ17d9WjJkFY75I1oRoCXxBw9En0kaavVcNNF2p+voeVOjS1aUh6BPh3OrJWQhMiR9wK3yjWXNQL3YbGaiFuNhUHqpMApXGkazWWIzynclHW0ri3aDSyPt48nQ6bj8akvM5KBc9aNcxTEjRY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5c6954c-f6c4-4860-1e3a-08dc3e9d90b6
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 11:56:04.0458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9X2go77mXY8aZ/LFjEAVI90XSzrKFYp8d3QZnjg+4h8EmbJFJr8wHet/eLATNnXszD+6fSCa0YXSVKmiK9ldlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4202
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-07_08,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 spamscore=0 adultscore=0 malwarescore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403070087
X-Proofpoint-ORIG-GUID: cVtTd53W68gGkQ8lqJE6gZwqhDMIfjo7
X-Proofpoint-GUID: cVtTd53W68gGkQ8lqJE6gZwqhDMIfjo7

On 06/03/2024 21:33, Dave Chinner wrote:
>> +static bool xfs_file_open_can_atomicwrite(
>> +	struct inode		*inode,
>> +	struct file		*file)
>> +{
>> +	struct xfs_inode	*ip = XFS_I(inode);
>> +	struct xfs_buftarg	*target = xfs_inode_buftarg(ip);
>> +
>> +	if (!(file->f_flags & O_DIRECT))
>> +		return false;
>> +
>> +	if (!xfs_inode_atomicwrites(ip))
>> +		return false;
>> +
>> +	if (!bdev_can_atomic_write(target->bt_bdev))
>> +		return false;
> Again, this is static blockdev information - the inode atomic write
> flag should not be set if the bdev cannot do atomic writes. It
> should be checked at mount time

ok

> - the filesystem probably should
> only mount read-only if it is configured to allow atomic writes and
> the underlying blockdev does not support atomic writes...

Let me know if you really would like to see that change also. It does 
seem a bit drastic, considering we can just disallow atomic writes.

Thanks,
John