Received-SPF: pass (google.com: domain of linux-kernel+bounces-95526-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 7 Mar 2024 13:23:01 +0100
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vitor Soares <ivitro@gmail.com>
Cc: manivannan.sadhasivam@linaro.org, thomas.kopp@microchip.com, 
	wg@grandegger.com, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, 
	vitor.soares@toradex.com, stable@vger.kernel.org
Subject: Re: [PATCH] can: mcp251xfd: fix infinite loop when xmit fails
Message-ID: <xmk5cgskx2ug2psec6qgbxndbuqq5cnin7rd4zt3thnhybxgeo@xudpdob7tcg2>
References: <20240307120442.12262-1-ivitro@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="z7skr4ctodjzwe4v"
Content-Disposition: inline
In-Reply-To: <20240307120442.12262-1-ivitro@gmail.com>


--z7skr4ctodjzwe4v
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Sorry, resend. I fsck up the linux-can ML's address.

On 07.03.2024 12:04:42, Vitor Soares wrote:
> From: Vitor Soares <vitor.soares@toradex.com>
>=20
> When the mcp251xfd_start_xmit() function fails, the driver stops
> processing messages, and the interrupt routine does not return,
> running indefinitely even after killing the running application.
>=20
> Error messages:
> [  441.298819] mcp251xfd spi2.0 can0: ERROR in mcp251xfd_start_xmit: -16
> [  441.306498] mcp251xfd spi2.0 can0: Transmit Event FIFO buffer not empt=
y. (seq=3D0x000017c7, tef_tail=3D0x000017cf, tef_head=3D0x000017d0, tx_head=
=3D0x000017d3).
> ... and repeat forever.
>=20
> The issue can be triggered when multiple devices share the same
> SPI interface. And there is concurrent access to the bus.
>=20
> The problem occurs because tx_ring->head increments even if
> mcp251xfd_start_xmit() fails. Consequently, the driver skips one
> TX package while still expecting a response in
> mcp251xfd_handle_tefif_one().
>=20
> This patch resolves the issue by decreasing tx_ring->head if
> mcp251xfd_start_xmit() fails. With the fix, if we attempt to trigger
> the issue again, the driver prints an error and discard the message.

What about returning NETDEV_TX_BUSY, then the networking stack will
retry.

> Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD =
SPI CAN")
> Cc: stable@vger.kernel.org
> Signed-off-by: Vitor Soares <vitor.soares@toradex.com>
> ---
>  drivers/net/can/spi/mcp251xfd/mcp251xfd-tx.c | 27 ++++++++++----------
>  1 file changed, 14 insertions(+), 13 deletions(-)
>=20
> diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-tx.c b/drivers/net/c=
an/spi/mcp251xfd/mcp251xfd-tx.c
> index 160528d3cc26..a8eb941c1b95 100644
> --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-tx.c
> +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-tx.c
> @@ -181,25 +181,26 @@ netdev_tx_t mcp251xfd_start_xmit(struct sk_buff *sk=
b,
>  	tx_obj =3D mcp251xfd_get_tx_obj_next(tx_ring);
>  	mcp251xfd_tx_obj_from_skb(priv, tx_obj, skb, tx_ring->head);
> =20
> -	/* Stop queue if we occupy the complete TX FIFO */
>  	tx_head =3D mcp251xfd_get_tx_head(tx_ring);
> -	tx_ring->head++;
> -	if (mcp251xfd_get_tx_free(tx_ring) =3D=3D 0)
> -		netif_stop_queue(ndev);
> -
>  	frame_len =3D can_skb_get_frame_len(skb);
> -	err =3D can_put_echo_skb(skb, ndev, tx_head, frame_len);
> -	if (!err)
> -		netdev_sent_queue(priv->ndev, frame_len);
> +	can_put_echo_skb(skb, ndev, tx_head, frame_len);
> +
> +	tx_ring->head++;
> =20
>  	err =3D mcp251xfd_tx_obj_write(priv, tx_obj);
> -	if (err)
> -		goto out_err;
> +	if (err) {
> +		can_free_echo_skb(ndev, tx_head, NULL);
> =20
> -	return NETDEV_TX_OK;
> +		tx_ring->head--;
> +

I'm not sure, if we want an error message for -EBUSY. We could add
proper ethtool statistics.

> +		netdev_err(priv->ndev, "ERROR in %s: %d\n", __func__, err);
> +	} else {
> +		/* Stop queue if we occupy the complete TX FIFO */
> +		if (mcp251xfd_get_tx_free(tx_ring) =3D=3D 0)
> +			netif_stop_queue(ndev);
> =20
> - out_err:
> -	netdev_err(priv->ndev, "ERROR in %s: %d\n", __func__, err);
> +		netdev_sent_queue(priv->ndev, frame_len);
> +	}
> =20
>  	return NETDEV_TX_OK;
>  }

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--z7skr4ctodjzwe4v
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEUEC6huC2BN0pvD5fKDiiPnotvG8FAmXpsaIACgkQKDiiPnot
vG+Whwf+KRkCgvw56NbiASrI8ezzUbH91uXRXQoqqquK1+9Ipudd3jqizmDkyFLF
L3Vw0GvrcdO5t3Wv8Tn2JxbfkiZvvfmVFJ7nD0THzqnjJr6ZKR+73okKuwcvxq/Y
G4lKLnQlgF1AfAsdTCJEuz4SNBrWDx4EsAEuTa2Tp5eBs0ePEPatZyml1wL8l6Dv
zOPh/Y9c+wWiSzGHFELXnfe9SaoDfUat+NIlJ4AsfxuXMSys4aQ+8Hz+ynoJFBp8
qYL0/9C/wBCaBF5mlv92guEQN8ZTcD8PxMfa7ZcqhEmO9e/1zET1HCDZYv+6yF/e
uv1rJNxBSob5knxMJiZUJTUQIACzQA==
=zeld
-----END PGP SIGNATURE-----

--z7skr4ctodjzwe4v--