Received: by 2002:ab2:788f:0:b0:1ee:8f2e:70ae with SMTP id b15csp526911lqi; Thu, 7 Mar 2024 04:40:28 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVDDvqFxJd16LTRJfb1pwXHpM6C4vKD23oYlBF2FoGz9xEGQILFJKJ7t/9Xp6HGdkMyUcrwDDDco6kirXbJd+MXx6FwonbDTUX0apkZcw== X-Google-Smtp-Source: AGHT+IHU5XrDEEzrS3nZsWUwPxtJO62r194XW5PAjKyQAADDr8ODoIVerXntZrQvfEzBead3Pzq1 X-Received: by 2002:a17:906:b00c:b0:a44:c1a9:ee37 with SMTP id v12-20020a170906b00c00b00a44c1a9ee37mr11323035ejy.61.1709815227897; Thu, 07 Mar 2024 04:40:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709815227; cv=pass; d=google.com; s=arc-20160816; b=NzOqLNL3PWxx/UKrt+hKQAHjyHxTJBodP/QqiYfTRdA4tbUdTDa+QnuXT+Y3WNKL4R ScAhA1Yb4ob844/4btmEhuBvdVrjmatT/kukf0bg51ZtqyP9SiBAE8XAJQ3J4OArl/k2 kDC6lvAP2vekaq3f7YqkoDKZ37knidCtRe0f/TvNrT9lgRlZTPjLD/0Qti+mSL9qx0tH wTIenWv2VyzGWBLhJkjpdVuNZfnpYbiOsSdLo0SCxZU6h38uGvlKXBALghdYyu69RTeC XWeHWBhCYhmSVUryf1IXi908CF3XB0HXitrVEUTnetf+yaxRIh1Pjt06HZGfW5Dls3GT OLKA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=VO5eonHO5vIMxGBlQPCGuvzt87yFvPmeAwfVip5Saaw=; fh=YgxGwtLtgHtsKao/o6/2osLsR0pCbgqRO7mLtkV4mKY=; b=nvXVhiqg6EkvCaDFl2B/WfXXsiR+pvAMJbSUOwhHnFhQ3pwpxSYzholiUCo5Un9c/D xLoiYCoGvB7PED567l160+mNLXMgmMI7iHN03EqGlchNFxRDEhjFDtlVZcNhjB8vZzl4 ORv9E+QgbW1TRR3me2w9XhWhJPq4V0mpDOvBPiDKGavBYK+EuzINUmLPvv71mhx05yJe srhJx3x7x41K/IU4mhq6MInIlJraACTEk+GDPuamWDVpC18KZFc02wJef43n/ajrBIWM Rka2rjlcq8TAPKQDpKqAWquaBzTEVJa9yQ9+1n9XLMEn2Aj6g5q/0FlXSYGJBcfpytS5 OGtg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=JYXuF7Ul; arc=pass (i=1 spf=pass spfdomain=suse.com dkim=pass dkdomain=suse.com dmarc=pass fromdomain=suse.com); spf=pass (google.com: domain of linux-kernel+bounces-95546-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-95546-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id hd37-20020a17090796a500b00a45bb1f5ec9si1505668ejc.138.2024.03.07.04.40.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 04:40:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-95546-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=JYXuF7Ul; arc=pass (i=1 spf=pass spfdomain=suse.com dkim=pass dkdomain=suse.com dmarc=pass fromdomain=suse.com); spf=pass (google.com: domain of linux-kernel+bounces-95546-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-95546-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 990C61F22A48 for ; Thu, 7 Mar 2024 12:40:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6247312B14B; Thu, 7 Mar 2024 12:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="JYXuF7Ul" Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7995912A175 for ; Thu, 7 Mar 2024 12:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709815219; cv=none; b=PQYhsaQeTd9ncAEWTxJ7T1VGgEnxK983GEUdyWw6k5X0WepeJkasLVm1ThTj7iy0Rws3yUAXE1CbWaUfQHkd8reRqUnzHHw9/fjTdubOxZgpD+6+gnT2FtmurLmxzb40XKAh6UWjvWC2LP0dqq+RSPAyCe0eD0RRa3jffgeIpJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709815219; c=relaxed/simple; bh=7q8x59bKdN+t2i+lMbr/meCuqsyVnDqfKNaz6Kknf/Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ia76w6LhyIWQ2Px8mfcL9ByWFHYVro+V4VkQln23qiDl8czqbOgUAkc6y9xNscV9K2XQ3X6sOKZ0nTMoV7aA3xB2f8nhWrYR2qmoJpXLFW9e1oFtx2KhbjwT0rh41QWpkLKsVrrFdBGd88Hl+LHZ3vUb3skUiX7NxH6+XDQuO0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=JYXuF7Ul; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-564647bcdbfso1006805a12.2 for ; Thu, 07 Mar 2024 04:40:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1709815216; x=1710420016; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=VO5eonHO5vIMxGBlQPCGuvzt87yFvPmeAwfVip5Saaw=; b=JYXuF7Uln9rx6Nt96m0Bjs4TI/bVcE9lakG/M/TO5pVo1xxsnHXEqjk3lB3Ilx0CzF plNWC3zW00YwXCIBv5bObRhal3DAd2U+nUn3ZwYcAd4n1DvZtQuOp+DAvm3yOTrRXw2y S2eUp2UtxNp4nCOCHEpta0T2ddvH8FF3J7Mrnfrh5SrOZiZ+foR5MC/xSrT08f+dXJ2W uGcInuurDPCvA7de0bwcyvbgQiQVTj4jN0es+R07qx6G7DpecMDo1ipX1tjjBv7Iz5QM RAwPN7U+CPtCrF4MS+UK7FRno8cXq/BxvPtW7nbRWwaA4HXfnyNeaHntDWIQE0749Axh 7Alg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709815216; x=1710420016; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VO5eonHO5vIMxGBlQPCGuvzt87yFvPmeAwfVip5Saaw=; b=xUh7r3AeN8VoWnP0MvghWH7Kc8+dFX1Ba67NhDVGoySanInyBVhXuC7BOSxIR2Zgar 5DmkPksPq+7ZTOBYS+pSrWdZeUgvd8bW6xVMbkKL0bMCQHjxwavCg2exVnFHfMNtdofq MzzHLvjeEv1b2kAj43RLBjFjLutHf2gmIzKh8G2Bcpd3CCe/J1B74NRJri4pw87GrkVY 7T7QcvfMIcPhYoYOqUjl6CG7yrfqvD8OQWZPCkpiozYpqTpDE0lzV5gi0gC++w3OH/qV XXl6Kx+oFd63YhTQH+NTN6OClk4PiR3kxyyxH8kN5kFo/mWta5hYQJPT0s6jX1wvweCt b0+g== X-Forwarded-Encrypted: i=1; AJvYcCW3AKDP11izElXjvYRFWEzyG0V/h0xQWb5P4XhBiETtzCCideMrsOLErRwd7V2b7uJwG1ECN6K8/6qDzrz6ZnAkn1+0UVZ10e56Ls3S X-Gm-Message-State: AOJu0YxPe3x1wKGaJFBsMsrtK1yOvKtQ20SP3WKTWOAvZBIxgYKdabaG Pi1YxY7dpHeevcyHOGGWSezRD1fOav/hyEVFeBA63k5rgbsOjU3dr2CNJZ+VBag= X-Received: by 2002:a50:aa9c:0:b0:568:2149:329a with SMTP id q28-20020a50aa9c000000b005682149329amr118073edc.19.1709815215724; Thu, 07 Mar 2024 04:40:15 -0800 (PST) Received: from linux-l9pv.suse ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id m18-20020aa7c492000000b005662d3418dfsm7958712edq.74.2024.03.07.04.40.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2024 04:40:15 -0800 (PST) Date: Thu, 7 Mar 2024 20:40:07 +0800 From: joeyli To: Jens Axboe Cc: Justin Sanders , "Lee, Chun-Yi" , Pavel Emelianov , Kirill Korotaev , "David S . Miller" , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: (subset) [PATCH] aoe: fix the potential use-after-free problem in aoecmd_cfg_pkts Message-ID: <20240307124007.GC31128@linux-l9pv.suse> References: <20240305082048.25526-1-jlee@suse.com> <170973933432.23995.8994501180418490235.b4-ty@kernel.dk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <170973933432.23995.8994501180418490235.b4-ty@kernel.dk> User-Agent: Mutt/1.11.4 (2019-03-13) Hi Jens, On Wed, Mar 06, 2024 at 08:35:34AM -0700, Jens Axboe wrote: > > On Tue, 05 Mar 2024 16:20:48 +0800, Lee, Chun-Yi wrote: > > This patch is against CVE-2023-6270. The description of cve is: > > > > A flaw was found in the ATA over Ethernet (AoE) driver in the Linux > > kernel. The aoecmd_cfg_pkts() function improperly updates the refcnt on > > `struct net_device`, and a use-after-free can be triggered by racing > > between the free on the struct and the access through the `skbtxq` > > global queue. This could lead to a denial of service condition or > > potential code execution. > > > > [...] > > Applied, thanks! > > [1/1] aoe: fix the potential use-after-free problem in aoecmd_cfg_pkts > commit: f98364e926626c678fb4b9004b75cacf92ff0662 > Thanks for your review! Joey Lee