Received-SPF: pass (google.com: domain of linux-kernel+bounces-95591-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Daniil Dulov <d.dulov@aladdin.ru>
To: Ingo Molnar <mingo@redhat.com>
CC: Daniil Dulov <d.dulov@aladdin.ru>, Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>, Vincent Guittot
	<vincent.guittot@linaro.org>, Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, Mel
 Gorman <mgorman@suse.de>, Daniel Bristot de Oliveira <bristot@redhat.com>,
	Valentin Schneider <vschneid@redhat.com>, <linux-kernel@vger.kernel.org>,
	<lvc-project@linuxtesting.org>
Subject: [PATCH] sched/topology: Check return value of zalloc_cpumask_var()
Date: Thu, 7 Mar 2024 16:23:40 +0300
Message-ID: <20240307132340.13192-1-d.dulov@aladdin.ru>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

zalloc_cpumask_var() returns false if mask was not allocated.
So, let's check if cpu masks are allocated successfully.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 8d5dc5126bb2 ("sched/topology: Small cleanup")
Signed-off-by: Daniil Dulov <d.dulov@aladdin.ru>
---
 kernel/sched/topology.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 10d1391e7416..2df98ffdfe16 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -2600,9 +2600,10 @@ int __init sched_init_domains(const struct cpumask *cpu_map)
 {
 	int err;
 
-	zalloc_cpumask_var(&sched_domains_tmpmask, GFP_KERNEL);
-	zalloc_cpumask_var(&sched_domains_tmpmask2, GFP_KERNEL);
-	zalloc_cpumask_var(&fallback_doms, GFP_KERNEL);
+	if (!zalloc_cpumask_var(&sched_domains_tmpmask, GFP_KERNEL) ||
+	    !zalloc_cpumask_var(&sched_domains_tmpmask2, GFP_KERNEL) ||
+	    !zalloc_cpumask_var(&fallback_doms, GFP_KERNEL))
+		return -ENOMEM;
 
 	arch_update_cpu_topology();
 	asym_cpu_capacity_scan();
-- 
2.25.1