Received-SPF: pass (google.com: domain of linux-kernel+bounces-95653-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <4ecb9a73-2930-42fa-9681-d1c8e5076677@nvidia.com>
Date: Thu, 7 Mar 2024 13:43:00 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] phy: tegra: xusb: Add API to retrieve the port
 number of phy
Content-Language: en-US
To: Wayne Chang <waynec@nvidia.com>, thierry.reding@gmail.com,
 jckuo@nvidia.com, vkoul@kernel.org, kishon@kernel.org,
 gregkh@linuxfoundation.org
Cc: linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
 stable@vger.kernel.org
References: <20240307030328.1487748-1-waynec@nvidia.com>
 <20240307030328.1487748-2-waynec@nvidia.com>
From: Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20240307030328.1487748-2-waynec@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?THNSai9saG9Qemg5cDFta2NrbWVZSWh6MzVRaDhHUklwRzJmeW5KN1dkK1V1?=
 =?utf-8?B?U0w4UXpWSExLcEZjOGpBRWhxWlR1Tnh3WnR2QkNjSEpuQlNIZEEveVE1YlVh?=
 =?utf-8?B?cTNyaWgrOWcrTE9RazNBeU43bjduZFRGNmJNd3RQZjFOYnk1Vm5BbW5mbjFn?=
 =?utf-8?B?aWZBbGpyVnkvY1puNFV2NkJ5UXlMdDJDNHRjaW1HdjZzd2N0VmNUMWlPUWtS?=
 =?utf-8?B?dlgwYW9NK2ZBREVPZ0dvcDBFZUoyK3orajJWcU1QeGlSWGcxUHRYZVl2aUE0?=
 =?utf-8?B?ZXJOcVU0amEzNndaYk9pbUdDU1p4UGI4YTB0L1hLV0Ftcldzc040VS9IT1Rw?=
 =?utf-8?B?QWZmVU9rUUN2VjlHbllzVTZNSGRkNFoyWi8yUWU2WG1YUjdLTEVTQU9LdFVT?=
 =?utf-8?B?eCtzWWlSTnkyZGVNdUdYeXpXMTg2VENUUTlKaGhEa2VSNmFKeUxDbEg2TGdZ?=
 =?utf-8?B?VEo4K3NDZVo5cTBPdndqSHM3TTZtZGxvTWNwbk9Sa0gzU3pjekU5TUVGZ01I?=
 =?utf-8?B?Z2RGUzhJaXJiQ0JVdE4wZzBXMEhMc3Y5RDJJekNoNCtQUHdYSVlYVU43SWg4?=
 =?utf-8?B?SFMxVHhDQlZyWEtiZE5XVzZqbzYyeTU0Zy9VeUdidUxCYmVlUEdEektGbnhp?=
 =?utf-8?B?WFVzWUMyWTBLTTJnTndCb0NuSTJIMUF1VkJ2cTh3cHF5SjU3V2todHYvOHBt?=
 =?utf-8?B?bWRIT01ZNWd0bWRCaTFHUEUrTC90KzRvOW80TWVja25aRXMyTm9laXBjbUJu?=
 =?utf-8?B?dkh2bHpycFB6bHZTdXhXZWlLK2xCVUYyczBlOEQ3amlyU3FhWlhnWHB1eTdC?=
 =?utf-8?B?Wnh0cFRHNHpPRkY1M2VIMW9GZExONU4ybWNiUGNUa2x3dTBic2hhWi9VYzNS?=
 =?utf-8?B?ODErTnVrczdSTjZ3NG1NMzRnRlJRVHJGZkR0YzFrcVlQbUh0UWFhVUxyanJG?=
 =?utf-8?B?ZVN0ekxCZ1lRMjZzMjBwc2htMTNRbzFESlVhSUkrQ3JVWm0zZmwxOWd3U2l5?=
 =?utf-8?B?YVNod0RjV04xRGxTTjM4MVdFS09ERUlnTEFJRWowcXpIQmNKdnB5TE5zQWg2?=
 =?utf-8?B?UzVReUxvL01naTdzYjA3NEJwUG1zLzI4ejdseVV2T290d3VXN0RaMjB4TGRF?=
 =?utf-8?B?bnRPODh3b1RxUkZnc3Z0QzZ0OHhpZGtJaUhqVnBWa05qUkpXbVh2dmN0Tzlq?=
 =?utf-8?B?MlYxamN2eXFpamxGNGJSUkwzanhEZ0RWcms0cWFLazVWT1J0TnZTUFRORVJv?=
 =?utf-8?B?c3IydE4rUlJFd0F1ZEVBMk0yT2dCOVlpckZsK0Vsenp5ZTNHc3dNSWs3YzZ1?=
 =?utf-8?B?aU1TcU0reDVtSWI1L1FwMlFjdjZFYmN0aUNsRVpaNUIvRDF0U1JWYitHWFR6?=
 =?utf-8?B?WVM2Z0ZKTk9Dd2ZTVnRhd2g5VWtVV0oram9NcEJJZUw1SmwzakpSTTlzN1JC?=
 =?utf-8?B?a2t5WnFRdGxBQTZWdUtKR3gyS29aNnVUNHhQZjVRQURWZ2JaM2ptNC9uMk5H?=
 =?utf-8?B?aHJUWWllNFVsWHh4UEJkNG5VR1dUalJHMmIzM2FUSTZnWjc2ajhQalBUYndp?=
 =?utf-8?B?RmdRdjA0WGw2YkYyZ0tiZm1qSnVLMy9ubmFXdTkzTjFVbDYrZjA0OVArUDFH?=
 =?utf-8?B?U3ZLZEpLWVdEdW9NRTlxQ2czVEREYzhaR2VxUDdPQTZKajA2TmlkVGlNbW1h?=
 =?utf-8?B?Z2RWODZ5Yjl1NW9Fb1VHNnFrcmphczg5UTlwQ2c2N2N4Y3A2R1NESWVUY2dV?=
 =?utf-8?B?bXM0V1RmNDM3RFFPZ2NvTXZCamZySWdEM29GKytHS0t4UjJkQWZONVRSMVZN?=
 =?utf-8?B?aFFSOXJ5dkJVaHJHUGJydTRObzBGcktNMis1aEVXb2c3Wk1sMnZnM1plZGQr?=
 =?utf-8?B?cEJFV3RKVS9LT0VCc1RMQ0FqQ2t3OC92TW9BM1ZzdG1uY2F0aXI0ZGU2U2xm?=
 =?utf-8?B?RU9vL3ltZmZNSnpPMTZWQlZvMC9ZeUEzNmlKTlB4a1pqaE91Nm1VTzVhZW5o?=
 =?utf-8?B?Z2tBZVB4RUFQQjI4MHdPcHZMd0dpQW1mUm1EcW5RRU1NOEVmZFk4SWxzMzNh?=
 =?utf-8?B?cUNTS2Q5SjhOQ0V5SFJEQjNiY2xNdG9ubmtIbGdHQmZKempPL0JtNERRMlFv?=
 =?utf-8?Q?97SPswUpsVaaz5yBYrey9QdbX?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89e82ece-349f-4ee7-b66e-08dc3eac8470
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 13:43:05.9351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VZ2fEHlHNMF6N1pWpBgmSMPoEvcB/xzBC5kxhYnK2uyV4OTZmfdsbIhBaoAR1LcqwEJi8iQp/n86v+Otj/fufA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8349


On 07/03/2024 03:03, Wayne Chang wrote:
> This patch introduces a new API, tegra_xusb_padctl_get_port_number,
> to the Tegra XUSB Pad Controller driver. This API is used to identify
> the USB port that is associated with a given PHY.
> 
> The function takes a PHY pointer for either a USB2 PHY or USB3 PHY as input
> and returns the corresponding port number. If the PHY pointer is invalid,
> it returns -ENODEV.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
> V1 -> V2:cc stable
>   drivers/phy/tegra/xusb.c       | 13 +++++++++++++
>   include/linux/phy/tegra/xusb.h |  1 +
>   2 files changed, 14 insertions(+)
> 
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index 142ebe0247cc..983a6e6173bd 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -1531,6 +1531,19 @@ int tegra_xusb_padctl_get_usb3_companion(struct tegra_xusb_padctl *padctl,
>   }
>   EXPORT_SYMBOL_GPL(tegra_xusb_padctl_get_usb3_companion);
>   
> +int tegra_xusb_padctl_get_port_number(struct phy *phy)
> +{
> +	struct tegra_xusb_lane *lane;
> +
> +	if (!phy)
> +		return -ENODEV;
> +
> +	lane = phy_get_drvdata(phy);
> +
> +	return lane->index;
> +}
> +EXPORT_SYMBOL_GPL(tegra_xusb_padctl_get_port_number);
> +
>   MODULE_AUTHOR("Thierry Reding <treding@nvidia.com>");
>   MODULE_DESCRIPTION("Tegra XUSB Pad Controller driver");
>   MODULE_LICENSE("GPL v2");
> diff --git a/include/linux/phy/tegra/xusb.h b/include/linux/phy/tegra/xusb.h
> index 70998e6dd6fd..6ca51e0080ec 100644
> --- a/include/linux/phy/tegra/xusb.h
> +++ b/include/linux/phy/tegra/xusb.h
> @@ -26,6 +26,7 @@ void tegra_phy_xusb_utmi_pad_power_down(struct phy *phy);
>   int tegra_phy_xusb_utmi_port_reset(struct phy *phy);
>   int tegra_xusb_padctl_get_usb3_companion(struct tegra_xusb_padctl *padctl,
>   					 unsigned int port);
> +int tegra_xusb_padctl_get_port_number(struct phy *phy);
>   int tegra_xusb_padctl_enable_phy_sleepwalk(struct tegra_xusb_padctl *padctl, struct phy *phy,
>   					   enum usb_device_speed speed);
>   int tegra_xusb_padctl_disable_phy_sleepwalk(struct tegra_xusb_padctl *padctl, struct phy *phy);


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!

Jon

-- 
nvpublic