Received-SPF: pass (google.com: domain of linux-kernel+bounces-95707-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240227034539.193573-1-aford173@gmail.com> <20240227034539.193573-2-aford173@gmail.com>
 <63199ea3af86986545fcec4e81fa3a38f18a160f.camel@imgtec.com>
In-Reply-To: <63199ea3af86986545fcec4e81fa3a38f18a160f.camel@imgtec.com>
From: Adam Ford <aford173@gmail.com>
Date: Thu, 7 Mar 2024 08:11:31 -0600
Message-ID: <CAHCN7xK18gA-im4C16Ax-xevCOOqy1C8mXsUCEXNHnEPxxsuOA@mail.gmail.com>
Subject: Re: [PATCH 1/6] dt-bindings: gpu: powervr-rogue: Add PowerVR support
 for some Renesas GPUs
To: Frank Binns <Frank.Binns@imgtec.com>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, 
	"linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>, 
	"magnus.damm@gmail.com" <magnus.damm@gmail.com>, "tzimmermann@suse.de" <tzimmermann@suse.de>, 
	Matt Coster <Matt.Coster@imgtec.com>, 
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "robh@kernel.org" <robh@kernel.org>, 
	"airlied@gmail.com" <airlied@gmail.com>, 
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
	"geert+renesas@glider.be" <geert+renesas@glider.be>, 
	"maarten.lankhorst@linux.intel.com" <maarten.lankhorst@linux.intel.com>, 
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "daniel@ffwll.ch" <daniel@ffwll.ch>, 
	"aford@beaconembedded.com" <aford@beaconembedded.com>, "conor+dt@kernel.org" <conor+dt@kernel.org>, 
	"mripard@kernel.org" <mripard@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 7, 2024 at 6:41=E2=80=AFAM Frank Binns <Frank.Binns@imgtec.com>=
 wrote:
>
> Hi Adam,
>
> On Mon, 2024-02-26 at 21:45 -0600, Adam Ford wrote:
> > Update the binding to add support for various Renesas SoC's with PowerV=
R
> > Rogue GX6250 and GX6650 GPUs.  These devices only need one clock, so up=
date
> > the table to indicate such like what was done for the ti,am62-gpu.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.ya=
ml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > index 256e252f8087..7c75104df09f 100644
> > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > @@ -14,6 +14,11 @@ properties:
> >    compatible:
> >      items:
> >        - enum:
> > +          - renesas,r8a774a1-gpu
> > +          - renesas,r8a774e1-gpu
> > +          - renesas,r8a77951-gpu
> > +          - renesas,r8a77960-gpu
> > +          - renesas,r8a77961-gpu
> >            - ti,am62-gpu
> >        - const: img,img-axe # IMG AXE GPU model/revision is fully disco=
verable
>
> A new set of items should be added for 'img,powervr-series6xt' and the Re=
nesas
> models along the lines of [1].

Should I rebase my binding off the one below, so it applies to your
branch or should I attempt to base it off the mainline?
>
> Thanks
> Frank
>
> [1]
> https://gitlab.freedesktop.org/imagination/linux/-/blob/powervr-next/Docu=
mentation/devicetree/bindings/gpu/img,powervr.yaml?ref_type=3Dheads#L16-19
>
> >
> > @@ -51,7 +56,13 @@ allOf:
> >        properties:
> >          compatible:
> >            contains:
> > -            const: ti,am62-gpu
> > +            enum:
> > +              - ti,am62-gpu
> > +              - renesas,r8a774a1-gpu
> > +              - renesas,r8a774e1-gpu
> > +              - renesas,r8a77951-gpu
> > +              - renesas,r8a77960-gpu
> > +              - renesas,r8a77961-gpu
> >      then:
> >        properties:
> >          clocks: