Received: by 2002:ab2:788f:0:b0:1ee:8f2e:70ae with SMTP id b15csp586046lqi; Thu, 7 Mar 2024 06:16:18 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUOfxPQfLFV3JNkqpPP9g2gSbiWmgsK8fay5iDWh3hplJ9mgNd3XiOcDfLO53u0FtfK9rduq1y/rsVvzCls8qgITx5lbgf6dWCDSeGiow== X-Google-Smtp-Source: AGHT+IGkluRpbtRbQWIdvnN87dGz9L2/TlDE6yFodHMCYVB8kKWsmPpnK3QZ8IHuaJJFOrAiJhGM X-Received: by 2002:a17:906:1846:b0:a45:d3c7:b462 with SMTP id w6-20020a170906184600b00a45d3c7b462mr1351685eje.41.1709820978134; Thu, 07 Mar 2024 06:16:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709820978; cv=pass; d=google.com; s=arc-20160816; b=cYin76s75+mDpisdgrQUMEz4f+VafPwZ9h3cGjraq0UzM/m6kYJ8BvO0eGt1LJfq8O 51b/q0Tnh1Md8RCK36jJQTLRtgYRTE6+HMzQBhbsFw8U/FIZlMnhLPfc1kdBROzjXhww 3d+YvYd9Zfu2Xzimt1JAaFb6BKtxdtwDb7tmkWijdlPPhONjY6YA5R1uOIoDuLFU/nCo cQL+3HMFCv7RJ3gorWWnSmyhVs9uQvHUaUrZqYqNqe5aHLm6+fWbTgPzeLOxK41jn0ZL 8ku5lNlW366GlWfH4UVssH2jf/WIIJo563PGjiy68CZlY8tsP1zfZe+9kDXrMx8f4Gi9 /kww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ToQvH/Vx5Q+OQGJBpuVsrYlXd/4o0J3+V5QulHTpF2s=; fh=PKov2v7mtZqWrG2ToL14QCqscLF6oofVifdomTnOWI8=; b=N7iKPVe1HqrLpYXQBHE8cl+JFrAjEp2vGyTXHKd8qjS41hm/E4VIWHte9kHsltWAlF 2JV8t6g8SNKbzSfV4DvhZd9GqF1lIIbSqMVeTLOS3SAu8bPJdSY1rCgu8eXSeZpJUXB7 pyEUyxccpXuHkUXls1AF5eN5Q1NpnlHwXhq/xaW1Eie8rGLOPxplUrPKMKp/pOgVCkQf ORxsjt+TqdeVPccfwFNVPK4ekKVsunQN+20wwqjYa40GtmYzVFlvE9rdslguyennjkoh YACFMrE/rVxtbPJfME5tzyl3o70RKnh5y7BvjKSt6eizCdAEyZ76PRLSs71M4H6vCGOL zrsw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-95711-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-95711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id e3-20020a170906c00300b00a45b79437b4si1588438ejz.608.2024.03.07.06.16.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 06:16:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-95711-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-95711-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-95711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D92A51F2716D for ; Thu, 7 Mar 2024 14:16:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1BF0C12EBCE; Thu, 7 Mar 2024 14:15:55 +0000 (UTC) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 727E312D771; Thu, 7 Mar 2024 14:15:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.190 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709820954; cv=none; b=WUZE5eXqwWsAl+gOoqrE+jEfmyNEJ4ADxwIBVQQErkiyizq9iQ1OlJWdhI5XgpK5ItYFfCI4jLhOBWIfsOzf01eH0qFNjFdKd16e0awICHBwQcnfckMIwnMNEPapPV9c6NcOmTVklVj6LMYsL2u53FzACfX8cLG9cyv33pynkqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709820954; c=relaxed/simple; bh=0oU6KL9B71fDtOf5uIw+wC2C4iG62LR7H2m3mEJxiNs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Sk1DXsHOSa5rfBCWxJH5hWWyL3Vq2e8EPDUkndtItAcqaDcM+Hs3UR8E1SGZSDJTEvXTMPPEUCPKORV7gtD9nbfS9PQQgoJDRwKJrmN2u5WnbG4Wwdu8c2jrTfUiYj1YBqgd5lDQd6qXWQDaRQwg3zVqZZVI71k77s9ca7OjML4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4TrBB94cPlz1xq7L; Thu, 7 Mar 2024 22:14:09 +0800 (CST) Received: from dggpemd100001.china.huawei.com (unknown [7.185.36.94]) by mail.maildlp.com (Postfix) with ESMTPS id 97DC81A0172; Thu, 7 Mar 2024 22:15:48 +0800 (CST) Received: from localhost.localdomain (10.50.165.33) by dggpemd100001.china.huawei.com (7.185.36.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Thu, 7 Mar 2024 22:15:48 +0800 From: Xingui Yang To: , , , , CC: , , , , , Subject: [PATCH v4 1/2] scsi: libsas: Add a helper sas_get_sas_addr_and_dev_type() Date: Thu, 7 Mar 2024 14:14:12 +0000 Message-ID: <20240307141413.48049-2-yangxingui@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240307141413.48049-1-yangxingui@huawei.com> References: <20240307141413.48049-1-yangxingui@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemd100001.china.huawei.com (7.185.36.94) Add a helper to get attached_sas_addr and device type from disc_resp. Suggested-by: John Garry Signed-off-by: Xingui Yang Reviewed-by: John Garry --- drivers/scsi/libsas/sas_expander.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c index 1eeb69cba8da..d6147616339f 100644 --- a/drivers/scsi/libsas/sas_expander.c +++ b/drivers/scsi/libsas/sas_expander.c @@ -1631,6 +1631,16 @@ int sas_discover_root_expander(struct domain_device *dev) /* ---------- Domain revalidation ---------- */ +static void sas_get_sas_addr_and_dev_type(struct smp_disc_resp *disc_resp, + u8 *sas_addr, + enum sas_device_type *type) +{ + memcpy(sas_addr, disc_resp->disc.attached_sas_addr, SAS_ADDR_SIZE); + *type = to_dev_type(&disc_resp->disc); + if (*type == SAS_PHY_UNUSED) + memset(sas_addr, 0, SAS_ADDR_SIZE); +} + static int sas_get_phy_discover(struct domain_device *dev, int phy_id, struct smp_disc_resp *disc_resp) { @@ -1684,13 +1694,8 @@ int sas_get_phy_attached_dev(struct domain_device *dev, int phy_id, return -ENOMEM; res = sas_get_phy_discover(dev, phy_id, disc_resp); - if (res == 0) { - memcpy(sas_addr, disc_resp->disc.attached_sas_addr, - SAS_ADDR_SIZE); - *type = to_dev_type(&disc_resp->disc); - if (*type == 0) - memset(sas_addr, 0, SAS_ADDR_SIZE); - } + if (res == 0) + sas_get_sas_addr_and_dev_type(disc_resp, sas_addr, type); kfree(disc_resp); return res; } -- 2.17.1