Received-SPF: pass (google.com: domain of linux-kernel+bounces-95732-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <49a7c0b667abe23d95d67cf0cf7ea7e193d9f2a1.1709773065.git.len.brown@intel.com>
 <dc6c4d98-e56a-448d-b372-38ce0cd927e9@nvidia.com>
In-Reply-To: <dc6c4d98-e56a-448d-b372-38ce0cd927e9@nvidia.com>
From: Len Brown <lenb@kernel.org>
Date: Thu, 7 Mar 2024 09:27:21 -0500
Message-ID: <CAJvTdK=Fbo0in7diYv_4Zk_-zrOPP4skDgpTMOYw-UM8=3R29Q@mail.gmail.com>
Subject: Re: [PATCH 1/1] nvme: Use pr_dbg, not pr_info, when setting shutdown timeout
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: kbusch@kernel.org, linux-nvme@lists.infradead.org, maxg@mellanox.com, 
	axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-kernel@vger.kernel.org, 
	Len Brown <len.brown@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 7, 2024 at 4:29=E2=80=AFAM Max Gurtovoy <mgurtovoy@nvidia.com> =
wrote:

> > Some words are alarming in routine kernel messages.
> > "timeout" is one of them...
> >
> > Here NVME is routinely setting a timeout value,
> > rather than reporting that a timeout has occurred.
>
> No.
> see the original commit message
>
> "When an NVMe controller reports RTD3 Entry Latency larger than the
> value of shutdown_timeout module parameter, we update the
> shutdown_timeout accordingly to honor RTD3 Entry Latency. Use an
> informational debug level instead of a warning level for it."
>
> So this is not a routine flow. This informs users about using a
> different value than the module param they set.

I have machines in automated testing.
Those machines have zero module params.
This message appears in their dmesg 100% of the time,
and our dmesg scanner complains about them 100% of the time.

Is this a bug in the NVME hardware or software?

If yes, I'll be happy to help  debug it.

If no, then exactly what action is the informed user supposed to take
upon seeing this message?

If none, then the message serves no purpose and should be deleted entirely.

thank you,

Len Brown, Intel