Received-SPF: pass (google.com: domain of linux-kernel+bounces-95740-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240307140729.2278907-1-arnd@kernel.org>
In-Reply-To: <20240307140729.2278907-1-arnd@kernel.org>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Thu, 7 Mar 2024 15:34:15 +0100
Message-ID: <CACRpkdYOofmWd6=_XN0+FWDJjp0W8vV_deUZbNOr2n5BkGaL4w@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: aw9523: allow building as loadable module
To: Arnd Bergmann <arnd@kernel.org>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>, 
	David Bauer <mail@david-bauer.net>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, 
	Arnd Bergmann <arnd@arndb.de>, Andy Shevchenko <andy.shevchenko@gmail.com>, linux-gpio@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 7, 2024 at 3:07=E2=80=AFPM Arnd Bergmann <arnd@kernel.org> wrot=
e:


> When CONFIG_I2C is set to =3Dm, the new aw9523 driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw95=
23_probe':
> pinctrl-aw9523.c:(.text+0x9f8): undefined reference to `__devm_regmap_ini=
t_i2c'
> arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw95=
23_driver_init':
> pinctrl-aw9523.c:(.init.text+0x4): undefined reference to `i2c_register_d=
river'
> arm-linux-gnueabi-ld: drivers/pinctrl/pinctrl-aw9523.o: in function `aw95=
23_driver_exit':
> pinctrl-aw9523.c:(.exit.text+0x2): undefined reference to `i2c_del_driver=
'
>
> Make it a tristate symbol so the dependency is correctly honored.
>
> Fixes: bfa5aa367a82 ("pinctrl: Add driver for Awinic AW9523/B I2C GPIO Ex=
pander")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I sent something similar yesterday:
https://lore.kernel.org/linux-gpio/20240305-fix-aw9523-v2-1-2dc50bab2b17@li=
naro.org/

Thanks anyway!

Yours,
Linus Walleij