Received-SPF: pass (google.com: domain of linux-kernel+bounces-95771-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <8cf4333a-b500-4fb7-8176-734fdc892da4@collabora.com>
Date: Thu, 7 Mar 2024 19:51:37 +0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>, kernel@collabora.com,
 kernel-janitors@vger.kernel.org, linux-mmc@vger.kernel.org,
 linux-kernel@vger.kernel.org, Jaehoon Chung <jh80.chung@samsung.com>,
 Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: dw_mmc: remove unneeded assignment
To: Yang Xiwen <forbidden405@outlook.com>
References: <20240307122129.2359553-1-usama.anjum@collabora.com>
 <SEZPR06MB69597EEFAB2F77049E9B257296202@SEZPR06MB6959.apcprd06.prod.outlook.com>
Content-Language: en-US
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <SEZPR06MB69597EEFAB2F77049E9B257296202@SEZPR06MB6959.apcprd06.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 3/7/24 5:22 PM, Yang Xiwen wrote:
> On 3/7/2024 8:21 PM, Muhammad Usama Anjum wrote:
>> The err is being set to 0 and replaced every time after this
>> assignment. Remove this assignment as it is extraneous.
>>
>> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200")
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>> ---
>>   drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c
>> b/drivers/mmc/host/dw_mmc-hi3798mv200.c
>> index 989ae8dda7228..96af693e3e37c 100644
>> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c
>> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c
>> @@ -133,7 +133,6 @@ static int
>> dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot,
>>               goto tuning_out;
>>             prev_err = err;
>> -        err = 0;
> 
> 
> Same for dw_mmc-hi3798cv200.c, maybe fix it as well?
Sent separately as different Fixes tag is required for that:
https://lore.kernel.org/all/20240307145013.2721326-1-usama.anjum@collabora.com

> 
> 
>>       }
>>     tuning_out:
> 
> 

-- 
BR,
Muhammad Usama Anjum