Received-SPF: pass (google.com: domain of linux-kernel+bounces-95781-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Zi Yan <ziy@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org,
 "\"Pankaj Raghav (Samsung)\"" <kernel@pankajraghav.com>,
 Zi Yan <ziy@nvidia.com>, "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 David Hildenbrand <david@redhat.com>, Yang Shi <shy828301@gmail.com>,
 Yu Zhao <yuzhao@google.com>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 =?utf-8?q?=22Michal_Koutn=C3=BD=22?= <mkoutny@suse.com>,
 Roman Gushchin <roman.gushchin@linux.dev>,
 "\"Zach O'Keefe\"" <zokeefe@google.com>, Hugh Dickins <hughd@google.com>,
 Luis Chamberlain <mcgrof@kernel.org>, linux-kernel@vger.kernel.org,
 cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 linux-kselftest@vger.kernel.org, Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH v5 7/8] mm: thp: split huge page to any lower order pages
Date: Thu, 07 Mar 2024 09:58:34 -0500
Message-ID: <FD2D17E1-5B18-4342-8692-FCE2FA774895@nvidia.com>
In-Reply-To: <20240226205534.1603748-8-zi.yan@sent.com>
References: <20240226205534.1603748-1-zi.yan@sent.com>
 <20240226205534.1603748-8-zi.yan@sent.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_B8DAFD2B-C04B-489B-B42B-E18B80234EC8_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?15J7Vl2CRuPKR8SmVbwXZk+tcQAz+3gYVg+BKiL5jtX0IfnFzJo1dm8Y9vsc?=
 =?us-ascii?Q?ZSRc76yZzWuxqJvT5ay9bd57pI4sPfElnY+090KkZiGocdC2L6OAL5FaQX+S?=
 =?us-ascii?Q?NwRSocAsGjMDDrjUYlducq7+SM3xGjKGXjZser/wBcHuEq3kkBm7Yzpx5wc+?=
 =?us-ascii?Q?Fi2NI4ACopNJSrIGH9154R07UuLv7mHXwAsxtqutNIxheuJSoQR3QJ+Xefgp?=
 =?us-ascii?Q?u6u87spqGD8LiYtB+lNbbtEx18ych+yBDtOdj5K5Kw7WnEl1SkonbZcbVoeG?=
 =?us-ascii?Q?2Rk5bE92GQ+nc3W+F8Y/8NUSyfd+Haec7Itwaeu1A7viF6MCgUBDYjB0Rhv9?=
 =?us-ascii?Q?2cYm0EOxxrP16OCBuTZtxbL7xm9btTEZ7TRUuzo9nyJHvtkXKzdtvMxOG2I3?=
 =?us-ascii?Q?XLgidk60RzfOGHf4s/O+nd46E6Fik/LrdrqeYDRmyC+MRFe1XgZHAWeY4+Wy?=
 =?us-ascii?Q?eqXzPQH9nJXay7eyINZT9Ml12jU4djrOaUdxlfrrqTilJaJrf9uHjggv2ppY?=
 =?us-ascii?Q?KQur5wsOhxVVzUt7qCeRu9j7XYMzDtm07xAi8kcSmSXyA2td91uxWSocsk7a?=
 =?us-ascii?Q?bOsMwHKVgys4ME9h8CDWGisPoQMYDNZh9aDRF4om8eJ65HhDYaHEk687/Y9H?=
 =?us-ascii?Q?1H9TAwS1nClJm5EyyIClU+iYkxFYlcQ/LbXtk9tI+gxcOyKpAOzM8bujYDSV?=
 =?us-ascii?Q?Kg5hN3egtMeBq2yBUA41Aw/ja8w4lUs8fuafbz9et9/ZAR3NIFkzt0OAd2Z+?=
 =?us-ascii?Q?16ECvw7OPz67rOowB7mjHZF+LiXa5sZanOfZhflqJzd88K6CAM73te9HNmtY?=
 =?us-ascii?Q?YwxchxgmhyjzI2SIxBa1oCMKs9L7nksKFZH3L7KkTMK4zkmQkKCrUBfpu6ZN?=
 =?us-ascii?Q?9HVAcO8XRHbej+Gya6CsU+d7jRezI4BS1lfkR1v31JIhZ4qgR+Xtv1ZkPRme?=
 =?us-ascii?Q?SUbE0EwS7w4rZP6RG9PIkccXkRjNtCnL7AKL+3rDvQhyfjHVFOSRlg9W1qAb?=
 =?us-ascii?Q?Ci3IdoJuz3fz5UDuKWue3dDpGYAs+yMUnWEOh3Pm5FOBOzeZwY346AmSy4I3?=
 =?us-ascii?Q?8VUjmCmGH0pbPoFqmU1bpS2DKLcvG+aH2IRVmT/JM/Wtnv5I7fAdTuA8P3t8?=
 =?us-ascii?Q?fVZqbWMkQJwALgSwP51ItxorYP3P52PGrGiuQeEIhOwKThui6I4EVDgSBHbY?=
 =?us-ascii?Q?ghac/Ayo+3dmRcq0h7d+rJHbdgTCvh2+z5WUxe8QviBuv32lkdbAvBE5KlLI?=
 =?us-ascii?Q?OJ4eKU1XDgeFqNd2K+0KTauSKC/SGpMTPxvc93Kptifr5PqlfBf+t2aRCw9Y?=
 =?us-ascii?Q?zlsreGRxj04uDAfRMWwAI8POERDNuY2hRnDhlgj0Ep7Bo6iWO9ntixxOVKxi?=
 =?us-ascii?Q?alzBS2KHqczwL7sRrFmFtu7NckPioQqWqYZYsG1oDQM8pPOATQyUTb4t+eVY?=
 =?us-ascii?Q?UX14Tk+pyU1iWY2/Qap8KuNeX26vhYZ+Tt7iTtue7jc2px71NlmAm6lZxDaZ?=
 =?us-ascii?Q?4AdYAJJIXtZSjEYGVrW9919vcMP9RhB7WI2nmjHG8bM+Ry6qJ9gNzKlSyYG+?=
 =?us-ascii?Q?RbZBCJuQ89nqSGhkZpeP50F/fRfEk4meja7v1JX6?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ba4b84b-2393-42de-242d-08dc3eb711e3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 14:58:38.1309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M8XV+TifusyUEtbohxKxRttRCCDzmL1G+1eX/wpQPYqitKYo4uxfp80nDCfBqr75
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8575

--=_MailMate_B8DAFD2B-C04B-489B-B42B-E18B80234EC8_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 26 Feb 2024, at 15:55, Zi Yan wrote:

> From: Zi Yan <ziy@nvidia.com>
>
> To split a THP to any lower order pages, we need to reform THPs on
> subpages at given order and add page refcount based on the new page
> order. Also we need to reinitialize page_deferred_list after removing
> the page from the split_queue, otherwise a subsequent split will
> see list corruption when checking the page_deferred_list again.
>
> Note: Anonymous order-1 folio is not supported because _deferred_list,
> which is used by partially mapped folios, is stored in subpage 2 and an=

> order-1 folio only has subpage 0 and 1. File-backed order-1 folios are
> fine, since they do not use _deferred_list.
>
> Signed-off-by: Zi Yan <ziy@nvidia.com>
> ---
>  include/linux/huge_mm.h |  21 +++++---
>  mm/huge_memory.c        | 110 +++++++++++++++++++++++++++++++---------=

>  2 files changed, 99 insertions(+), 32 deletions(-)

Hi Andrew,

Can you fold the patch below into this patch 7? It is based on the discus=
sion
with Dan Carpenter at https://lore.kernel.org/linux-mm/7dda9283-b437-4cf8=
-ab0d-83c330deb9c0@moroto.mountain/.
It prevents invalid new_order input from causing unexpected outcome of
split_huge_page_to_list_to_order(). Especially in patch 8, new_order can =
come
from debugfs without any restriction. I will send another fixup to
patch 8 to check new_order from debugfs.

Thanks.

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index a81a09236c16..57fca7bffd20 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3052,6 +3052,9 @@ int split_huge_page_to_list_to_order(struct page *p=
age, struct list_head *list,
        VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio);
        VM_BUG_ON_FOLIO(!folio_test_large(folio), folio);

+       if (new_order >=3D folio_order(folio))
+               return -EINVAL;
+
        /* Cannot split anonymous THP to order-1 */
        if (new_order =3D=3D 1 && folio_test_anon(folio)) {
                VM_WARN_ONCE(1, "Cannot split to order-1 folio");


--
Best Regards,
Yan, Zi

--=_MailMate_B8DAFD2B-C04B-489B-B42B-E18B80234EC8_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXp1hoPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUMnEQAJ1C/Cy05bUNn2krv9foAAFlcORFj0/hyisD
19MRI7B4l1iYcHZDqYNj9WwhOypnOIYqdDutkHhJGwZBCnoYwmfZizaNmwOZu/d5
H5HjNIV2RXsBXWbwMM/f750Y8Vc2ccVQvS57np/5mYiVfFjJ7AAr3d8cdSxDlJwq
JytAgGLXJS6bV2GIX8AxLc/AwKAe+8cCZRU3pf24P40FM4u5GhkASbTrY0UzsqeZ
mUmkH6th0H5ZDBiu3GMVsIbHqlOutP2D9rmptcvqcZuxrFKIZ5tK7VweJ1VdU7SV
Ddgclc8pTtNY1hdzDgvd9OdkhZDDTMTdl748cdbtR59E5TT+JByr8Ofwkdx1KWqI
W6mP+Kxte3jWwAjxRCzp3mb3MbjS+/O7KGH6vJM+2Yc2lu0Pt3aKxsxOSmHPJcdD
uH7e8FOMjSDoKsTA5t/OCxWiv4a5NxEppNnW7+kgmcGmNwQLNU4WvNggvTmHHeks
ReqsKkfFtg7M0DnRDBajETEoQJw49VcIkxM0jDq0nVNuIJSH3uctIZPj8NAkIlF1
gSxx8uT8vY5BrYAhT7aZ2QP8MhGLIqtdtoWNafMgN0IbcbM2AZX6UQUWh1xsV4pw
FY27IoBS/uVnaxYEgrKuY2uQUZl+/kVPSabXdfwCFcrpQWXlhM52wO9jzwO1jMU4
8g5WhRPf
=r1py
-----END PGP SIGNATURE-----

--=_MailMate_B8DAFD2B-C04B-489B-B42B-E18B80234EC8_=--