Received-SPF: pass (google.com: domain of linux-kernel+bounces-95670-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 7 Mar 2024 15:58:04 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	Vineeth Vijayan <vneethv@linux.ibm.com>,
	Peter Oberparleiter <oberpar@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH v1 1/1] s390/cio: Use while (i--) pattern to clean up
Message-ID: <ZenH7IojjFOtIMwX@smile.fi.intel.com>
References: <20240222134501.236871-1-andriy.shevchenko@linux.intel.com>
 <ZeXeBr5z8TrLbuCI@smile.fi.intel.com>
 <20240307135442.33873-B-hca@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240307135442.33873-B-hca@linux.ibm.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, Mar 07, 2024 at 02:54:42PM +0100, Heiko Carstens wrote:
> On Mon, Mar 04, 2024 at 04:43:18PM +0200, Andy Shevchenko wrote:
> > On Thu, Feb 22, 2024 at 03:45:01PM +0200, Andy Shevchenko wrote:
> > > Use more natural while (i--) patter to clean up allocated resources.
> > 
> > Any comments?
> 
> It is up to Vineeth and Peter to decide what to do with this.
> 
> But in general I'm not a fan of such patches. It depends on what people
> prefer, and you can send literally thousands of similar patches where the
> code looks "more natural" afterwards.

I understand your point, however, the lesser characters to parse, the better
readability is (usually). At least the proposed pattern is mainly used in
the kernel (you may grep for different patterns). It also has an educational
effect in case somebody takes this code as an example (for whatever reason).
With this we will show that *in practice* kernel prefers this style over
others.

-- 
With Best Regards,
Andy Shevchenko