Received-SPF: pass (google.com: domain of linux-kernel+bounces-95834-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Haiyang Zhang <haiyangz@microsoft.com>
To: Jakub Kicinski <kuba@kernel.org>, Shradha Gupta
	<shradhagupta@linux.microsoft.com>, Shradha Gupta
	<shradhagupta@microsoft.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>, Eric Dumazet
	<edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Ajay Sharma
	<sharmaajay@microsoft.com>, Leon Romanovsky <leon@kernel.org>, Thomas
 Gleixner <tglx@linutronix.de>, Sebastian Andrzej Siewior
	<bigeasy@linutronix.de>, KY Srinivasan <kys@microsoft.com>, Wei Liu
	<wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>, Long Li
	<longli@microsoft.com>, Michael Kelley <mikelley@microsoft.com>
Subject: RE: [PATCH] net :mana : Add per-cpu stats for MANA device
Thread-Topic: [PATCH] net :mana : Add per-cpu stats for MANA device
Thread-Index: AQHacJ8N8LLwvYYKc0y/h+tCzJvDjrEsZziAgAADR7A=
Date: Thu, 7 Mar 2024 15:49:15 +0000
Message-ID:
 <DM6PR21MB14817597567C638DEF020FE3CA202@DM6PR21MB1481.namprd21.prod.outlook.com>
References:
 <1709823132-22411-1-git-send-email-shradhagupta@linux.microsoft.com>
 <20240307072923.6cc8a2ba@kernel.org>
In-Reply-To: <20240307072923.6cc8a2ba@kernel.org>
Accept-Language: en-US
Content-Language: en-US
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=60ca9008-496c-4f0f-954c-124078107146;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-03-07T15:41:07Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM6PR21MB1481:EE_|DM4PR21MB3539:EE_
x-ms-office365-filtering-correlation-id: 910a61b8-2a1d-4b3c-65d8-08dc3ebe2477
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 rZXGHgnGXVA07MpPpYoksNhNjSLM4zd2IvlZV6PH33GlahbHxVNjP6HNUH+oXkUvJCkfECBml4f1jvQav58oOpEd05NxGLWHg1gSpZFILktLOyICqCYl3ZqdVGfS9c3FwSr5IFgHVRkX8Q9bVXvxvn0w2+f4OtuNcTNDloSGNoeTq8EmU0GCkBC2PkAh5J/KVZRuquo6eFappHZty9Ro0TLCExT2EYEvkGJh4LWWzlDo8RQOBrVrMgj/KawqqCbPfyvBnW+z343d2ZH0KwE1F7RkavbYyZZ7zmgJ36wPZIS7yNsNv22mjZ5IIaol5nlRrZnKXlT+AwSzVPr8hR2Qct23Rdi3K+sqUMRjE2dFksgSjLG5yMNP2RxFa/NeGtSYxX2OsMovfYck0I6WOxawfH4ch9oskVoMGuZf0K2kstatVtFvXtw5tuutV4ri7GdnXDQRzGfy+130dBFtT9xcIXVv5Oz0o/bo/J6uB+bzKmFNnJy07SxV1BDJOejStHlT42mdg4Q7TiqWvM9JBdhZPNR1d+o/El+p/o8Jg+1rVd55LOzEO5XJ6ueWe3GZagGsW9MzaCFleGF/HP5RSQiA590NRIgVEsSp9TogG+kCm+Bx1Ny1IIms9LPDw2San9LHTDBNhXPqg74d9++6BEBEVaVodjiu4rW0FJj+/oeNjALAXPgAewbpw1hE8Z9P+/512P4eZrCkceezdnAI35EIKzglh8nCAN0LdfKmzJx2isw=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR21MB1481.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(38070700009);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?YHxooy0H/AMpMuYcCHtaejpEz7Ec4c2NGfjrhFyGOF7/Qjg9vvCRw0cexFS+?=
 =?us-ascii?Q?YM7KhR6HLN3NH8k8O6TQaDgoM3s2IEStkpO11l2oQWi+BOMAwtAKuKNtGiRZ?=
 =?us-ascii?Q?0NLq7ky1z7s8q+KciEBm7RMTL0GUzgPVXQ5/TPUKu9ap6lhrtAwGHVT3EP/U?=
 =?us-ascii?Q?hbbbjownjGZPfI35n9p806seC2i/hTjV98Ten5yVgUTmSmhnlqL+34Qbn5XP?=
 =?us-ascii?Q?5mgst92ffknRRIgt1ya8s030AFD6kVIUPaDkEn/KZv38Db8fgJj6W6YluCP2?=
 =?us-ascii?Q?J9+Kwm9DZ/E2ZGkjpFLrv4Z6rfFOtx9OXQEd5HbzjWY6HHkMCAU24ZxwrS62?=
 =?us-ascii?Q?cEWrsNYpLIhj4yJ58sEREMrxCRFkzb2kSyhRVNslb0zbVtQBGr4L6hHQvVS4?=
 =?us-ascii?Q?sNCOgQUDRJQhQ8LlwYhGfpuS7Im6ZddPALy1iRSYP8iOUciq2uYEw0KZfmDu?=
 =?us-ascii?Q?ZOS9UNiZomgy8hB7kJ2SfV/IZl9SpcUR2j22c4T1cqah/gH1KpUeW37c2zSZ?=
 =?us-ascii?Q?o8+DEerCypGdRtn2aMOPLDSSGy+3VuJZfDgMEUkZyz1dfHdyMese0LcZpQ6/?=
 =?us-ascii?Q?EGDIBBY78juJdzQewPuveJgryrtKvwMmm7VlNJEYvTU/w9onVKssjFhV83E1?=
 =?us-ascii?Q?g7bC9+NWhmGZY0Et5EPyaMJRu6RRRDTvO6G3+/h7qNHeynqFGkuf2+OiYDv4?=
 =?us-ascii?Q?HH0TLkwPHCj4WekFglEJaJqytUB5YtVU8R/x2siUN0YF7SgPUUI7AAk1/2sP?=
 =?us-ascii?Q?f5sErPgF2ZVwTXYEHCIAK+8FGG4vBswly64+g4gwi9e5g7x7oaREL0bKDpIA?=
 =?us-ascii?Q?XiQBkA3ZGIOrccc/Wb9QVCI2dVhHJAgwKvKuoPwmp0k4MG1XUgfTJaaIKXaR?=
 =?us-ascii?Q?MmRkR19PSOKv/y5oC7sWShss1y2jM8JDl+1Sj0ManP4y97K3vy/lQU2gcY3+?=
 =?us-ascii?Q?9Ss6Ylqs4cLDRg/N7/KsS27hpe/TJY2nijwbTgqYEcU16Dadepwh3NvLBgYo?=
 =?us-ascii?Q?01Z2hxJjlbi62vIT6tPcaq2sHYB1RT3kcI/8Dq95Qvrc3zfBzH3hTNFj23lM?=
 =?us-ascii?Q?aSY8nwfM02czF5MbjJzoFQv7VMhsUoOwmhE/QLwIZB4kjxdNioUP+lzI4coY?=
 =?us-ascii?Q?sodqiniBfZ/Tsm8AVdjSVemlS4wStSMLeb1ErfU+n64X94qNIE3t+JLJR3BO?=
 =?us-ascii?Q?AnUJmAIhDWt0V3Q71MgevfbpqggsS01pcxqH7KMCv+lpyArVY3TcsPrwjQH4?=
 =?us-ascii?Q?a2WE8BWeAdIB7eUzr1q91+/Mc9mzl0Ul/+3vpP1KB5WEz4eRRydaQxdVZov7?=
 =?us-ascii?Q?iLnV3wIl7ZBFpyRJNNoJoriqGt0+HSJZRH9Y+AvWrgeFybayLPnXmbuKS+c3?=
 =?us-ascii?Q?rB5wAtYLukEt8a2RO3BfOYPTEBRWTWM+7aGLybcIuVpqoPNHvtBnripZMw9c?=
 =?us-ascii?Q?DhmZFOa7t/YqVnd326zjniNAQoCphqdKOAJ5ru3B/PrgDuzmFHgIr9f2aJjJ?=
 =?us-ascii?Q?99+5WlrhTJL4ffvjhgF+UQMJdxJbmit986ew1qPcRMXp4SHd3rxr+C1uOAjl?=
 =?us-ascii?Q?xU2wqJu/fgJ5WkwCzAH6rB5JDFk+J2p6lCCq5YVT?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR21MB1481.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 910a61b8-2a1d-4b3c-65d8-08dc3ebe2477
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2024 15:49:15.5752
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Y2lIs3h8wXliHV8pqd81iCH4yni/JNLvywT4G9VQy2uuxfX1/r1Sedr35RU3DvWi0m25cN9g9sgGbI7K/+PUog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR21MB3539


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Thursday, March 7, 2024 10:29 AM
> To: Shradha Gupta <shradhagupta@linux.microsoft.com>
> Cc: linux-kernel@vger.kernel.org; linux-hyperv@vger.kernel.org; linux-
> rdma@vger.kernel.org; netdev@vger.kernel.org; Eric Dumazet
> <edumazet@google.com>; Paolo Abeni <pabeni@redhat.com>; Ajay Sharma
> <sharmaajay@microsoft.com>; Leon Romanovsky <leon@kernel.org>; Thomas
> Gleixner <tglx@linutronix.de>; Sebastian Andrzej Siewior
> <bigeasy@linutronix.de>; KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; Wei Liu <wei.liu@kernel.org>; Dexuan Cui
> <decui@microsoft.com>; Long Li <longli@microsoft.com>; Michael Kelley
> <mikelley@microsoft.com>; Shradha Gupta <shradhagupta@microsoft.com>
> Subject: Re: [PATCH] net :mana : Add per-cpu stats for MANA device
>=20
> On Thu,  7 Mar 2024 06:52:12 -0800 Shradha Gupta wrote:
> > Extend 'ethtool -S' output for mana devices to include per-CPU packet
> > stats
>=20
> But why? You already have per queue stats.
Yes. But the q to cpu binding is dynamic, we also want the per-CPU stat=20
to analyze the CPU usage by counting the packets and bytes on each CPU.

>=20
> > Built-on: Ubuntu22
> > Tested-on: Ubuntu22
>=20
> I understand when people mention testing driver changes on particular
> SKUs of supported devices, that adds meaningful info. I don't understand
> what "built" and "tested" on a distro is supposed to tell us.
> Honest question, what is the value of this?
@Shradha Gupta Please add the tested SKU and test case here. Or, you don't
have to include test info with the patch.

Thanks,
- Haiyang