Received-SPF: pass (google.com: domain of linux-kernel+bounces-95836-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 7 Mar 2024 16:51:16 +0100
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: David Gouarin <dgouarin@gmail.com>
CC: <david.gouarin@thalesgroup.com>, Madalin Bucur <madalin.bucur@nxp.com>,
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, "Camelia
 Groza" <camelia.groza@nxp.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>
Subject: Re: [PATCH net v2] dpaa_eth: fix XDP queue index
Message-ID: <ZenidKFF/gQefijz@boxer>
References: <ZeiNxaq3jzloO9l6@boxer>
 <20240307142402.906681-1-dgouarin@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240307142402.906681-1-dgouarin@gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5eH5oYmVsBDY0mErDaNPEbugeB+S3btLqNd0bC86DeFl9oMojFfX3dcor+Rx?=
 =?us-ascii?Q?w2e0IWN44gGGI5rVRhu4zY2aSjBmf6ZjjqUe0bsaClDuASZk6ZXCQfDECNBv?=
 =?us-ascii?Q?+HM75xrreHk0McXJmB0/MxQZcLMkkq8nIVlGoGj0w3Wv+32LLv27CZHjGIBO?=
 =?us-ascii?Q?GbmmwaDE116KRlCHjF1f5wGIRSw1AMND9IsjHwXdBHbKyR+fVX89hZ8xePWt?=
 =?us-ascii?Q?6Q8VKEAF9T5ah5VGHknMqpQLQ/CT3RBq9+mCdgdFcSVRKCxw2JJrGcDm+WfI?=
 =?us-ascii?Q?VP+pV2WnerecPIrHY9nsa0orTtr2b1dM5SssH9Lvf/gljKUTQVYY8tApq0DJ?=
 =?us-ascii?Q?h7Uj84nYDEj2ck1j1ZkcXsiWFd0Y/50adeV12TeMJtZVq7AZxVXYC1VGOiUQ?=
 =?us-ascii?Q?cN7udX+uOmA+ZmGG80PpbVfYr3LKDE7QwV61n0kS8WbX4a47B6MxCQDQb75M?=
 =?us-ascii?Q?o0+cS5+2WsjRxAN4835bWoTAvxvAW2DW3AAfqdd7E4Me/sage3Q4dbHQ5z27?=
 =?us-ascii?Q?yGxuzqH3+lhz2KtEUAp1v4SZ/FeftFIHjNbACimzmNzSjiJQ791/tZNRfm3T?=
 =?us-ascii?Q?5Z4FdmT3zzyUGAjUe9NCWIqBKuKRsuUwlkMIdu6C8wftezVT/laGSlmn65Ql?=
 =?us-ascii?Q?JBuB6LQe2dt7fYK01+6pvUP9twNOLLudm1QRMRXW/0lSUlkb4mzwgpUx94Sv?=
 =?us-ascii?Q?nI0MAfQI2mibmExnxgy5+SYDqLZh+wPBwTkFSrLJLhI2U1cI3UjyfChNgE+z?=
 =?us-ascii?Q?WGlaG4LGfzIuMtAjx9D72ljb3oofNt4jkDF7g2P7nmNQBmOEDsj6hLtRbis1?=
 =?us-ascii?Q?UMlxabfM031UEcRWrFrVDyxuhYkwEyPV7LknwVkMAQko0jHiHMaoJdND0MTG?=
 =?us-ascii?Q?3Du2rczCHXeVs/MMblzDxPaLGsxERHJnLBG6wJDByBBGw2lMpV7smTK3anUG?=
 =?us-ascii?Q?vT3qZAOR5qT3ovOQnDwewz8HTd8TdLUbaqDQDySyI0IoVoUp379IZvWBhfzX?=
 =?us-ascii?Q?oL2+xH9QfA5wc1Y1GJUHLhE2eiM5Zj6zkSAkZ8gD780Sl+L0bUS7PNnd1kVi?=
 =?us-ascii?Q?0mLYtZ3x5PVIwPrV0D0sWLnw2E5PHvCe11Mxf7a2ELYnwWTIdqHYrh55D1A7?=
 =?us-ascii?Q?Gq4jYQUqH1FkbFRUvInHLF1kzQKLUvJAqb1oyz2fbOWpn9uROfh/AqI1uK/E?=
 =?us-ascii?Q?mKHujrm3kCupZQKp3CaSgR3aW3xq9Fm4UauWYCE0Ts0+dSVYu7as3G0utYpn?=
 =?us-ascii?Q?UBXYkLLCidkeng+VZw+e9eGETjDo965zwXLH629fD9pO60b34G2zkOLFH1dd?=
 =?us-ascii?Q?fNKGfzIXXpURBW0oKr9EEytLwo7L4C30VlfhxMFUJBxWqSDE0KhTPxFmOFer?=
 =?us-ascii?Q?t+95Rlwn8N/oax4SkKeTpDCEauyebmFW0d+UtBznSo8NFF4tYk65Pn9tyLcb?=
 =?us-ascii?Q?KKpDbTkJ6Q53UFI0mzc+4kle8cyQpAvoD6eQLqZzZDZRruEUK2BSTMKVcmmH?=
 =?us-ascii?Q?ucbTGiTZR8VDH/1MYoXc/Pnkd8LF+zvReonT3GataIBka6+9Sd4puI6gjwyd?=
 =?us-ascii?Q?L6f0IQOcOfn8O7DozipvK+H4Ovhx/eGY5ZMB0nmjz+cRZcnOLX8pnFL8QlDH?=
 =?us-ascii?Q?0A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 742421ae-761c-488e-8b14-08dc3ebe7359
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 15:51:28.0946
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H9CYabF8Ae0mZF9FrDmp5Wmj9oWVsPyODYo77f+dvSsPXjQdIxy/AqMO02PAdPEic3UBLsq4LsRix0DiDwdJZIdGJ+L5oAnS1NXe/6e3HG4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8283
X-OriginatorOrg: intel.com

On Thu, Mar 07, 2024 at 03:24:02PM +0100, David Gouarin wrote:
> Make it possible to bind a XDP socket to a queue id.
> The DPAA FQ Id was passed to the XDP program in the XDP packet metadata
> which made it unusable with bpf_map_redirect.

I think that referring to a member from xdp_rxq_info struct as 'packet
metadata' is confusing. I was trying to find a place where you are
actually storing this id at xdp_buff::data_meta. This is not happening
AFAICT. Thing is that xsk_rcv_check() picks xdp->rxq->queue_index which
holds fqid which is not related to queue number, right?

> Instead of the DPAA FQ Id, initialise the XDP rx queue with the channel id.
> 
> Fixes: d57e57d0cd04 ("dpaa_eth: add XDP_TX support")
> 
> Signed-off-by: David Gouarin <dgouarin@gmail.com>
> ---
> v2: add Fixes: in description
> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index dcbc598b11c6..988dc9237368 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -1154,7 +1154,7 @@ static int dpaa_fq_init(struct dpaa_fq *dpaa_fq, bool td_enable)
>  	if (dpaa_fq->fq_type == FQ_TYPE_RX_DEFAULT ||
>  	    dpaa_fq->fq_type == FQ_TYPE_RX_PCD) {
>  		err = xdp_rxq_info_reg(&dpaa_fq->xdp_rxq, dpaa_fq->net_dev,
> -				       dpaa_fq->fqid, 0);
> +				       dpaa_fq->channel, 0);
>  		if (err) {
>  			dev_err(dev, "xdp_rxq_info_reg() = %d\n", err);
>  			return err;
> -- 
> 2.34.1
>