Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757408AbYAFOFT (ORCPT ); Sun, 6 Jan 2008 09:05:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754499AbYAFOFI (ORCPT ); Sun, 6 Jan 2008 09:05:08 -0500 Received: from accolon.hansenpartnership.com ([76.243.235.52]:37218 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752973AbYAFOFG (ORCPT ); Sun, 6 Jan 2008 09:05:06 -0500 Subject: Re: [patch] scsi: revert "[SCSI] Get rid of scsi_cmnd->done" From: James Bottomley To: Linus Torvalds Cc: Peter Osterlund , Matthew Wilcox , Ingo Molnar , Linux Kernel Mailing List , Andrew Morton , Jens Axboe , Al Viro In-Reply-To: References: <20080102162534.GA4041@elte.hu> <1199292381.3258.32.camel@localhost.localdomain> <20080102194030.GC11638@parisc-linux.org> <1199304735.3258.53.camel@localhost.localdomain> <1199316785.3258.85.camel@localhost.localdomain> Content-Type: text/plain Date: Sun, 06 Jan 2008 08:04:56 -0600 Message-Id: <1199628296.5205.7.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.2 (2.12.2-2.fc8) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1188 Lines: 28 On Sat, 2008-01-05 at 19:43 -0800, Linus Torvalds wrote: > This all still leaves the question unanswered why that commit > 6f5391c283d7fdcf24bf40786ea79061919d1e1d changed any behaviour at > all. > Because the thing that Peter is describing has nothing to do with any > low-level drivers what-so-ever. It isn't even a secondary effect like I thought. This commit genuinely didn't have anything to do with the bug, it was purely accidental. It came about because if you look at the reporter's recipe to reproduce, which all of us tried without success, it's missing several steps. To get the bug, these steps must have been done somehow, but I bet by pure chance they weren't when reverting 6f5391c283d7fdcf24bf40786ea79061919d1e1d which led to wrongly fingering this commit. Now, if only someone who understood the mechanics of what the commit was doing tried to stop you reverting it we could have saved a lot of trouble ... James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/