Received-SPF: pass (google.com: domain of linux-kernel+bounces-95847-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Stefan Wiehler <stefan.wiehler@nokia.com>
To: Russell King <linux@armlinux.org.uk>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Joel Fernandes <joel@joelfernandes.org>,
	Josh Triplett <josh@joshtriplett.org>,
	Boqun Feng <boqun.feng@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Zqiang <qiang.zhang1211@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	rcu@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Stefan Wiehler <stefan.wiehler@nokia.com>
Subject: [PATCH] arm: smp: Avoid false positive CPU hotplug Lockdep-RCU splat
Date: Thu,  7 Mar 2024 17:09:51 +0100
Message-ID: <20240307160951.3607374-1-stefan.wiehler@nokia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?5fFDlDO+x7TihxCiDDDhoY5zNSaeij+cFi2SfFJMZ75NSLrbuRS+tpX+2FtB?=
 =?us-ascii?Q?3naKf0weP5VX7s5XGcUKBAaLUJrXjEMTWdkXKyW+TpEPUvXMRfzZNisEEMdQ?=
 =?us-ascii?Q?C1x99iPDWL0N4Z9IZ6VDXJdiJ/OlXyv2LdHjyQ0X5SnrEaAS9AO4ggatXmc2?=
 =?us-ascii?Q?8idK21wVbQK4GqCac6g1CNU52PWerILV8N0j4x1Z3aQzFbFh9bE642FN4JXH?=
 =?us-ascii?Q?JXdyx0DYA+sm6XzgxQbsEoRzvChRWSpHudUcW9loxXDRvLYazKcuV5nYLlDt?=
 =?us-ascii?Q?H1PEE0uzfD3Ao0M0EOa3sJDzJYTp22G8eNvQfqGTn3pQo9/9iqKQNfVa+zaj?=
 =?us-ascii?Q?yNEywxkacy9ey7BgGxRc6b3Wn2BpPQQDgFoa+jXuRGr9sTE+7weKowLttWDk?=
 =?us-ascii?Q?rE0D/p9/1xVDw6ikN8Bw7i+T9LsW7hp3Z8JU4lPirMFAn5fhhOTK5c0if9Yz?=
 =?us-ascii?Q?2ghI0EDfymvtEnnP+J8vLT/oQX+QsKPRITbzJdXcItSgUTuljBGIRGTLjHCu?=
 =?us-ascii?Q?sYpctjPZyPS8Ddo+9WbFc2ZAs0kG8mW3VkZi6UVIfmU3Twt0PtX+2Y2WGUui?=
 =?us-ascii?Q?7ha2bMooaDJKkU3ouSjv6vKIfoi4N+RHU4E3ineRRaktlqKu0zb36Exqwf1i?=
 =?us-ascii?Q?+wHExUoBqLlujl1jMu9emr2YrSdx186zLaDXhI96g1MNoWNInL71b9GYLuvC?=
 =?us-ascii?Q?ESkF4JyvfcJsGiuhO6mz5x8BBT50FR2FPigPngdez0l2HJZTYzMwblNb38hr?=
 =?us-ascii?Q?5V+MSLnebE8SGpQxcDVf3N8DhgOWefNNbnpaG3QlqdMpl5tFj1/99ppjCpFy?=
 =?us-ascii?Q?poJSq9Lq6J8utj1kYxbZB1DSYsCYNp/GgipPCfyJxsAf/xRLCK3rssATYmiw?=
 =?us-ascii?Q?25SU1R5bk1UHBPExfLU/xmWsGfXYCQLUC3D7N3gmOTRMONzxCtILkHMaiJZ5?=
 =?us-ascii?Q?HPbo+rwwlnOJkYcnwv1VjLZWHPBa77vWZqfzyvGz5F41nKHXD96Vc1spRmEF?=
 =?us-ascii?Q?Q+1k3NV7tvK5w5ArbJ0bWCDn0qtGYynpt3kQwxDq/dKfV97mj2fgZ3IUq2w/?=
 =?us-ascii?Q?NKdUx8qBso0cKPoCtxOmz1lnCHpHWfaUhYOPKjKuv3UgdBQhYBsnaW2CG/1T?=
 =?us-ascii?Q?VUjmrs2ttO5PpQ3YDC02lDfT9bBvmXPfFo21fwosm0JxchzzxWqW5asof2C3?=
 =?us-ascii?Q?iW5azVgsxoTfxFeFaVMSZEKPSHVyDDwjWRKGw8EGgElgAW9Atms+1AH4DQYa?=
 =?us-ascii?Q?vYupMldXCU9/aon8Q7azhvzP+mWs44IhoChA3ldKTT1sMTlGzJzlwQE7v/0n?=
 =?us-ascii?Q?x3L35Lizm4qzTn2a7X5UdWEeykFda4KfgospKh13aMuA4ai8AcZhF7n+8mGA?=
 =?us-ascii?Q?i+2++W8JghupU+bXoOzJrlYjR3z+FuBH6tpBFAUXHAcv+EatgwI1SCUqZ1vo?=
 =?us-ascii?Q?QoUM6vWE5faOQAE51PMbP/L5gwKg+XeUsbW+V/IaMon1XGMdSZnnuXACGFSR?=
 =?us-ascii?Q?kUWqXdXETxtp/VK3kRDj6udNV9sOlyqnP2u7idjoEYHOAuPXAkRReYW1/bT9?=
 =?us-ascii?Q?+WboRfyTId3TCkGmfSsrCQxRVfiqsUg6t5DLGi0T3kjmXesosFtWq9iN6aYs?=
 =?us-ascii?Q?cg=3D=3D?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fdf6f0d-e30c-4ed5-2c3d-08dc3ec12017
X-MS-Exchange-CrossTenant-AuthSource: PAWPR07MB9688.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 16:10:36.8441
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7VgSLwm8oHtCNKSrEck7Vr1ikBN/RZA2G0t8WRH6u9LlL7PadTI1mUtX6xnAzXwLyVJgRtOhX9kwVf5egrEQUKeOLLok74Efsl5llcRdAx4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR07MB8723

With CONFIG_PROVE_RCU_LIST=y and by executing

  $ echo 0 > /sys/devices/system/cpu/cpu1/online

one can trigger the following Lockdep-RCU splat on ARM:

  =============================
  WARNING: suspicious RCU usage
  6.8.0-rc7-00001-g0db1d0ed8958 #10 Not tainted
  -----------------------------
  kernel/locking/lockdep.c:3762 RCU-list traversed in non-reader section!!

  other info that might help us debug this:

  RCU used illegally from offline CPU!
  rcu_scheduler_active = 2, debug_locks = 1
  no locks held by swapper/1/0.

  stack backtrace:
  CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.8.0-rc7-00001-g0db1d0ed8958 #10
  Hardware name: Allwinner sun8i Family
   unwind_backtrace from show_stack+0x10/0x14
   show_stack from dump_stack_lvl+0x60/0x90
   dump_stack_lvl from lockdep_rcu_suspicious+0x150/0x1a0
   lockdep_rcu_suspicious from __lock_acquire+0x11fc/0x29f8
   __lock_acquire from lock_acquire+0x10c/0x348
   lock_acquire from _raw_spin_lock_irqsave+0x50/0x6c
   _raw_spin_lock_irqsave from check_and_switch_context+0x7c/0x4a8
   check_and_switch_context from arch_cpu_idle_dead+0x10/0x7c
   arch_cpu_idle_dead from do_idle+0xbc/0x138
   do_idle from cpu_startup_entry+0x28/0x2c
   cpu_startup_entry from secondary_start_kernel+0x11c/0x124
   secondary_start_kernel from 0x401018a0

The CPU is already reported as offline from RCU perspective in
cpuhp_report_idle_dead() before arch_cpu_idle_dead() is invoked. Above
RCU-Lockdep splat is then triggered by check_and_switch_context() acquiring the
ASID spinlock.

Avoid the false-positive Lockdep-RCU splat by briefly reporting the CPU as
online again while the spinlock is held.

Signed-off-by: Stefan Wiehler <stefan.wiehler@nokia.com>
---
 arch/arm/kernel/smp.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index 3431c0553f45..6875e2c5dd50 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -319,7 +319,14 @@ void __noreturn arch_cpu_idle_dead(void)
 {
 	unsigned int cpu = smp_processor_id();
 
+	/*
+	 * Briefly report CPU as online again to avoid false positive
+	 * Lockdep-RCU splat when check_and_switch_context() acquires ASID
+	 * spinlock.
+	 */
+	rcutree_report_cpu_starting(cpu);
 	idle_task_exit();
+	rcutree_report_cpu_dead();
 
 	local_irq_disable();
 
-- 
2.42.0