Received-SPF: pass (google.com: domain of linux-kernel+bounces-95857-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 7 Mar 2024 11:26:29 -0500
From: Frank Li <Frank.li@nxp.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>,
	linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/4] arm64: dts: imx8qxp: add asrc[0, 1], esai0,
 spdif[0, 1] and sai[4, 5]
Message-ID: <Zenqtcg8HuGNN9L5@lizhi-Precision-Tower-5810>
References: <20240305-asrc_8qxp-v4-0-c61b98046591@nxp.com>
 <2177674.irdbgypaU6@steina-w>
 <ZeiJdoTqWd8h0Q5I@lizhi-Precision-Tower-5810>
 <1961523.PYKUYFuaPT@steina-w>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1961523.PYKUYFuaPT@steina-w>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?iso-8859-1?Q?9xzelrCkN4S8M86PEUHBAUV/+J7kFJiendwiNNypJ4Lt7HpZlepaID/NPw?=
 =?iso-8859-1?Q?LLvKl7U6EKEzV+FUI5SEfb/KCNNf6nOOiaIM9lshrp/LKlHGc9zw5CyC+j?=
 =?iso-8859-1?Q?6x+gCeBs5Tkdt+koOwwhYy0DzDM3IUbiV7+jHqbi9SE95S78TVuA9IjtX4?=
 =?iso-8859-1?Q?UGlCZERyaFTJEU5mcjRkrjzQBxzzpgeC9e0sFlyd/b9Ah5LnqqX4WPvDJt?=
 =?iso-8859-1?Q?3Xt0a3Uw4zguiRIlpnKyJ62s4WmaycJi+o7WiLFQSsg7LZHRLoZGwnzFJv?=
 =?iso-8859-1?Q?89gwXeekB9aKwDrx5lo+caRVEtcLlBcjmeCrfhRbMoBvIIKEmef9k/ZigB?=
 =?iso-8859-1?Q?8IhufLBgfZeve3jvlelpZgejYyWxSm1xtfrTAmBueqqbbyiMsND+nzWQq8?=
 =?iso-8859-1?Q?BdcPHWwiZC+xjGaAEOjnQPv7OfbZqJyYC8zgtZt6FHeDpNBmhgwcmC8/5G?=
 =?iso-8859-1?Q?BJrnmPtllkTah4OC2yWBZq9VXPFUwzDfxQWKmGLj5ZxxkAzxMOyUCFPQcG?=
 =?iso-8859-1?Q?ok1VnKE/7nP//3JjroBJPxMv3LN0lSv8HWUPfkQ6sIN3ZoCn+M3d9zaxIu?=
 =?iso-8859-1?Q?DO9dIdWvnRxCIdlxZcADlZ00rqonsok1Qx51vQbpl43SUysiKYNCujufU7?=
 =?iso-8859-1?Q?NYF4UPNwsEyFX9cVnjmCHV0WSaHOA8eR93oGPOhVUHgseSxUOmAVVbNk1x?=
 =?iso-8859-1?Q?+d3yC4zsTVNBwL7OB6w7dbjYWjW8Swp6nniOtHdt6euj17fQCnUWEiIpYh?=
 =?iso-8859-1?Q?tnXAOwLg+ibkD3VeruYNgRhV01LaYGB8lhnB7zZSN6y+gPjsJq4JY3hsxo?=
 =?iso-8859-1?Q?DecwSs3+EKs4qTCeS3iqvQfaV5TSNDPfwU6CcK0FHcG57CbRMQWq67GXPu?=
 =?iso-8859-1?Q?cUa4c3g5K8R+BakA0z2U8pOWcAXZhexQGv3kC7FoEWWGHi1V5UDnOb1vKL?=
 =?iso-8859-1?Q?4QxyYiYuLd32Yrr9Ov7wRZQfbMPBK1sukNuTsPl+2fCHEq85QgPNMCAG7U?=
 =?iso-8859-1?Q?/bQ1eORsP8+xCsj6xxn5uDtVtbyZc2XnvpOwhuXlBcGfvYk08izZQv7dMI?=
 =?iso-8859-1?Q?9oTw+3Q8Hg+a2rZgFwctFrx3l+YXKlpzf/zqoTY42dVwvjc1/UPYlVvwbN?=
 =?iso-8859-1?Q?QfQ1oZGGcoaTH0xX5ynzLGNBns/vTtwuCi0MxYVSPNO7c/BydGsTg//Dmu?=
 =?iso-8859-1?Q?PkzEAZ+iC8SzPWlNDj8nBhwz+J2VGdhSl/5rBt6+lhgA2tzAf5/i0XCjrU?=
 =?iso-8859-1?Q?UJFiWfhaiuCOIq3ZfQxkFEXiVqp1nemqvN5GydlbcmVaAUKVaGb+mHEwbT?=
 =?iso-8859-1?Q?usZ5DZblq5LC98e4g9hnWYwEmFmipnG92jUTr9R8LvfRqZZSJxpvYJD90f?=
 =?iso-8859-1?Q?O7QmvQQ2BWx6lrsVXkqPCd25Jg0zJK06+LeDxsK1KZE1dzhU35e/5R5NjR?=
 =?iso-8859-1?Q?O3BUJYOUwuYDEEgqz6WwS1xtVqbQ2AW7FoRBrQ4rgLWDbY0RwjdGnc4xjn?=
 =?iso-8859-1?Q?fWIwvr1gdzNr5+VBrvG5hkz0VLDxrEnPTW17pItvaFTYxvFWYvvke0+IDC?=
 =?iso-8859-1?Q?6VGZEi159A4M1INc6YUXzbRF34bqxnUOPmzr5H1Ty3CSlebOkLxbJ3wM04?=
 =?iso-8859-1?Q?arDjpnInqz9dk=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8df6b6a5-bc68-440b-afd5-08dc3ec35cec
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 16:26:37.9459
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TcUO8Ci8lPdVvVJLb9FAPkTSVnjQslEML+wWMz+DoV0RDtXNn0X8diisbnBi/BQVZw7fYsGThyeFuHAmFhJkkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8881

On Thu, Mar 07, 2024 at 08:22:25AM +0100, Alexander Stein wrote:
> Hi Frank,
> 
> Am Mittwoch, 6. M?rz 2024, 16:19:18 CET schrieb Frank Li:
> > On Wed, Mar 06, 2024 at 08:20:00AM +0100, Alexander Stein wrote:
> > > Hi Frank,
> > > 
> > > thanks for the patch.
> > > 
> > > Am Dienstag, 5. M?rz 2024, 18:33:05 CET schrieb Frank Li:
> > > > Add asrc[0,1], esai0, spdif[0,1], sai[4,5] and related lpcg node for
> > > > imx8 audio subsystem.
> > > > 
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi | 304 +++++++++++++++++++++++
> > > >  1 file changed, 304 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi
> > > > index 07afeb78ed564..78305559f15c9 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-audio.dtsi
> > > > @@ -6,6 +6,7 @@
> > > >  
> > > >  #include <dt-bindings/clock/imx8-clock.h>
> > > >  #include <dt-bindings/clock/imx8-lpcg.h>
> > > > +#include <dt-bindings/dma/fsl-edma.h>
> > > >  #include <dt-bindings/firmware/imx/rsrc.h>
> > > >  
> > > >  audio_ipg_clk: clock-audio-ipg {
> > > > @@ -481,4 +482,307 @@ acm: acm@59e00000 {
> > > >  			      "sai3_rx_bclk",
> > > >  			      "sai4_rx_bclk";
> > > >  	};
> > > > +
> > > > +	asrc0: asrc@59000000 {
> > > 
> > > Please insert nodes sorted by address. ASRC0 is the very first node.
> > > 
> > > > +		compatible = "fsl,imx8qm-asrc";
> > > > +		reg = <0x59000000 0x10000>;
> > > > +		interrupts = <GIC_SPI 372 IRQ_TYPE_LEVEL_HIGH>;
> > > > +		clocks = <&asrc0_lpcg 0>,
> > > > +			 <&asrc0_lpcg 0>,
> > > > +			 <&aud_pll_div0_lpcg 0>,
> > > > +			 <&aud_pll_div1_lpcg 0>,
> > > > +			 <&acm IMX_ADMA_ACM_AUD_CLK0_SEL>,
> > > > +			 <&acm IMX_ADMA_ACM_AUD_CLK1_SEL>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>;
> > > > +		clock-names = "mem", "ipg",
> > > > +			      "asrck_0", "asrck_1", "asrck_2", "asrck_3",
> > > > +			      "asrck_4", "asrck_5", "asrck_6", "asrck_7",
> > > > +			      "asrck_8", "asrck_9", "asrck_a", "asrck_b",
> > > > +			      "asrck_c", "asrck_d", "asrck_e", "asrck_f",
> > > > +			      "spba";
> > > > +		dmas = <&edma0 0 0 0>,
> > > > +		       <&edma0 1 0 0>,
> > > > +		       <&edma0 2 0 0>,
> > > > +		       <&edma0 3 0 FSL_EDMA_RX>,
> > > > +		       <&edma0 4 0 FSL_EDMA_RX>,
> > > > +		       <&edma0 5 0 FSL_EDMA_RX>;
> > > > +		/* tx* is output channel of asrc, it is rx channel for eDMA */
> > > > +		dma-names = "rxa", "rxb", "rxc", "txa", "txb", "txc";
> > > > +		fsl,asrc-rate  = <8000>;
> > > > +		fsl,asrc-width = <16>;
> > > > +		fsl,asrc-clk-map = <0>;
> > > > +		power-domains = <&pd IMX_SC_R_ASRC_0>;
> > > > +		status = "disabled";
> > > > +	};
> > > > +
> > > > +	esai0: esai@59010000 {
> > > > +		compatible = "fsl,imx8qm-esai", "fsl,imx6ull-esai";
> > > > +		reg = <0x59010000 0x10000>;
> > > > +		interrupts = <GIC_SPI 409 IRQ_TYPE_LEVEL_HIGH>;
> > > > +		clocks = <&esai0_lpcg 1>, <&esai0_lpcg 0>, <&esai0_lpcg 1>, <&clk_dummy>;
> > > > +		clock-names = "core", "extal", "fsys", "spba";
> > > > +		dmas = <&edma0 6 0 FSL_EDMA_RX>, <&edma0 7 0 0>;
> > > > +		dma-names = "rx", "tx";
> > > > +		power-domains = <&pd IMX_SC_R_ESAI_0>;
> > > > +		status = "disabled";
> > > > +	};
> > > > +
> > > > +	spdif0: spdif@59020000 {
> > > > +		compatible = "fsl,imx8qm-spdif";
> > > > +		reg = <0x59020000 0x10000>;
> > > > +		interrupts =  <GIC_SPI 456 IRQ_TYPE_LEVEL_HIGH>, /* rx */
> > > > +			      <GIC_SPI 458 IRQ_TYPE_LEVEL_HIGH>; /* tx */
> > > > +		clocks = <&spdif0_lpcg 1>,	/* core */
> > > > +			 <&clk_dummy>,		/* rxtx0 */
> > > > +			 <&spdif0_lpcg 0>,	/* rxtx1 */
> > > > +			 <&clk_dummy>,		/* rxtx2 */
> > > > +			 <&clk_dummy>,		/* rxtx3 */
> > > > +			 <&clk_dummy>,		/* rxtx4 */
> > > > +			 <&audio_ipg_clk>,	/* rxtx5 */
> > > > +			 <&clk_dummy>,		/* rxtx6 */
> > > > +			 <&clk_dummy>,		/* rxtx7 */
> > > > +			 <&clk_dummy>;		/* spba */
> > > > +		clock-names = "core", "rxtx0", "rxtx1", "rxtx2", "rxtx3", "rxtx4",
> > > > +			      "rxtx5", "rxtx6", "rxtx7", "spba";
> > > > +		dmas = <&edma0 8 0 (FSL_EDMA_MULTI_FIFO | FSL_EDMA_RX)>,
> > > > +		       <&edma0 9 0 FSL_EDMA_MULTI_FIFO>;
> > > > +		dma-names = "rx", "tx";
> > > > +		power-domains = <&pd IMX_SC_R_SPDIF_0>;
> > > > +		status = "disabled";
> > > > +	};
> > > > +
> > > > +	spdif1: spdif@59030000 {
> > > 
> > > That's imx8qm only, no?
> > 
> > I am not sure what means. why do you think it is imx8qm only? It is for
> > imx8qm, imx8qxp, imx8dxl.
> 
> According to Table- 2-6 (Audio DMA memory Map) in i.MX8X RM Rev. 0 05/2020,
> the lasted one available on the webpage, address 0x59030000 is reserved.
> I read that as there is no periphery available. This matches the feature list
> in 1.1.2 Features, where "1x SPDIF" is stated.
> 
> So spdif1 is only for imx8qm (no idea about imx8dxl though) and should be
> listed in a file called imx8qm-ss-audio.dtsi which is only included in
> imx8qm.dtsi.
> 

Thanks, I will do that.

> Thanks and best regards
> Alexander
> 
> > 
> > Frank
> > 
> > > 
> > > > +		compatible = "fsl,imx8qm-spdif";
> > > > +		reg = <0x59030000 0x10000>;
> > > > +		interrupts =  <GIC_SPI 460 IRQ_TYPE_LEVEL_HIGH>, /* rx */
> > > > +			      <GIC_SPI 462 IRQ_TYPE_LEVEL_HIGH>; /* tx */
> > > > +		clocks = <&spdif1_lpcg 1>,	/* core */
> > > > +			 <&clk_dummy>,		/* rxtx0 */
> > > > +			 <&spdif1_lpcg 0>,	/* rxtx1 */
> > > > +			 <&clk_dummy>,		/* rxtx2 */
> > > > +			 <&clk_dummy>,		/* rxtx3 */
> > > > +			 <&clk_dummy>,		/* rxtx4 */
> > > > +			 <&audio_ipg_clk>,	/* rxtx5 */
> > > > +			 <&clk_dummy>,		/* rxtx6 */
> > > > +			 <&clk_dummy>,		/* rxtx7 */
> > > > +			 <&clk_dummy>;		/* spba */
> > > > +		clock-names = "core", "rxtx0", "rxtx1", "rxtx2", "rxtx3", "rxtx4",
> > > > +			      "rxtx5", "rxtx6", "rxtx7", "spba";
> > > > +		dmas = <&edma0 10 0 (FSL_EDMA_MULTI_FIFO | FSL_EDMA_RX)>,
> > > > +		       <&edma0 11 0 FSL_EDMA_MULTI_FIFO>;
> > > > +		dma-names = "rx", "tx";
> > > > +		power-domains = <&pd IMX_SC_R_SPDIF_1>;
> > > > +		status = "disabled";
> > > > +	};
> > > > +
> > > > +	asrc1: asrc@59800000 {
> > > 
> > > Insert this between dsp and edma1, sorted by address.
> > > 
> > > > +		compatible = "fsl,imx8qm-asrc";
> > > > +		reg = <0x59800000 0x10000>;
> > > > +		interrupts = <GIC_SPI 380 IRQ_TYPE_LEVEL_HIGH>;
> > > > +		clocks = <&asrc1_lpcg 0>,
> > > > +			 <&asrc1_lpcg 0>,
> > > > +			 <&aud_pll_div0_lpcg 0>,
> > > > +			 <&aud_pll_div1_lpcg 0>,
> > > > +			 <&acm IMX_ADMA_ACM_AUD_CLK0_SEL>,
> > > > +			 <&acm IMX_ADMA_ACM_AUD_CLK1_SEL>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>;
> > > > +		clock-names = "mem", "ipg",
> > > > +			      "asrck_0", "asrck_1", "asrck_2", "asrck_3",
> > > > +			      "asrck_4", "asrck_5", "asrck_6", "asrck_7",
> > > > +			      "asrck_8", "asrck_9", "asrck_a", "asrck_b",
> > > > +			      "asrck_c", "asrck_d", "asrck_e", "asrck_f",
> > > > +			      "spba";
> > > > +		dmas = <&edma1 0 0 0>,
> > > > +		       <&edma1 1 0 0>,
> > > > +		       <&edma1 2 0 0>,
> > > > +		       <&edma1 3 0 FSL_EDMA_RX>,
> > > > +		       <&edma1 4 0 FSL_EDMA_RX>,
> > > > +		       <&edma1 5 0 FSL_EDMA_RX>;
> > > > +		/* tx* is output channel of asrc, it is rx channel for eDMA */
> > > > +		dma-names = "rxa", "rxb", "rxc", "txa", "txb", "txc";
> > > > +		fsl,asrc-rate  = <8000>;
> > > > +		fsl,asrc-width = <16>;
> > > > +		fsl,asrc-clk-map = <1>;
> > > > +		power-domains = <&pd IMX_SC_R_ASRC_1>;
> > > > +		status = "disabled";
> > > > +	};
> > > > +
> > > > +	sai4: sai@59820000 {
> > > > +		compatible = "fsl,imx8qm-sai";
> > > > +		reg = <0x59820000 0x10000>;
> > > > +		interrupts = <GIC_SPI 329 IRQ_TYPE_LEVEL_HIGH>;
> > > > +		clocks = <&sai4_lpcg 1>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&sai4_lpcg 0>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>;
> > > > +		clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
> > > > +		dmas = <&edma1 8 0 FSL_EDMA_RX>, <&edma1 9 0 0>;
> > > > +		dma-names = "rx", "tx";
> > > > +		power-domains = <&pd IMX_SC_R_SAI_4>;
> > > > +		status = "disabled";
> > > > +	};
> > > > +
> > > > +	sai5: sai@59830000 {
> > > > +		compatible = "fsl,imx8qm-sai";
> > > > +		reg = <0x59830000 0x10000>;
> > > > +		interrupts = <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>;
> > > > +		clocks = <&sai5_lpcg 1>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&sai5_lpcg 0>,
> > > > +			 <&clk_dummy>,
> > > > +			 <&clk_dummy>;
> > > > +		clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
> > > > +		dmas = <&edma1 10 0 0>;
> > > > +		dma-names = "tx";
> > > > +		power-domains = <&pd IMX_SC_R_SAI_5>;
> > > > +		status = "disabled";
> > > > +	};
> > > > +
> > > > +	amix: amix@59840000 {
> > > > +		compatible = "fsl,imx8qm-audmix";
> > > > +		reg = <0x59840000 0x10000>;
> > > > +		clocks = <&amix_lpcg 0>;
> > > > +		clock-names = "ipg";
> > > > +		power-domains = <&pd IMX_SC_R_AMIX>;
> > > > +		dais = <&sai4>, <&sai5>;
> > > > +		status = "disabled";
> > > > +	};
> > > > +
> > > > +	mqs: mqs@59850000 {
> > > > +		compatible = "fsl,imx8qm-mqs";
> > > > +		reg = <0x59850000 0x10000>;
> > > > +		clocks = <&mqs0_lpcg 0>,
> > > > +			<&mqs0_lpcg 1>;
> > > > +		clock-names = "mclk", "core";
> > > > +		power-domains = <&pd IMX_SC_R_MQS_0>;
> > > > +		status = "disabled";
> > > > +	};
> > > > +
> > > > +	asrc0_lpcg: clock-controller@59400000 {
> > > 
> > > Please insert he lpcg nodes according to their address.
> > > 
> > > > +		compatible = "fsl,imx8qxp-lpcg";
> > > > +		reg = <0x59400000 0x10000>;
> > > > +		#clock-cells = <1>;
> > > > +		clocks = <&audio_ipg_clk>;
> > > > +		clock-indices = <IMX_LPCG_CLK_4>;
> > > > +		clock-output-names = "asrc0_lpcg_ipg_clk";
> > > > +		power-domains = <&pd IMX_SC_R_ASRC_0>;
> > > > +	};
> > > > +
> > > > +	esai0_lpcg: clock-controller@59410000 {
> > > > +		compatible = "fsl,imx8qxp-lpcg";
> > > > +		reg = <0x59410000 0x10000>;
> > > > +		#clock-cells = <1>;
> > > > +		clocks = <&acm IMX_ADMA_ACM_ESAI0_MCLK_SEL>,
> > > > +			 <&audio_ipg_clk>;
> > > > +		clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
> > > > +		clock-output-names = "esai0_lpcg_extal_clk",
> > > > +				     "esai0_lpcg_ipg_clk";
> > > > +		power-domains = <&pd IMX_SC_R_ESAI_0>;
> > > > +	};
> > > > +
> > > > +	spdif0_lpcg: clock-controller@59420000 {
> > > > +		compatible = "fsl,imx8qxp-lpcg";
> > > > +		reg = <0x59420000 0x10000>;
> > > > +		#clock-cells = <1>;
> > > > +		clocks = <&acm IMX_ADMA_ACM_SPDIF0_TX_CLK_SEL>,
> > > > +			 <&audio_ipg_clk>;
> > > > +		clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
> > > > +		clock-output-names = "spdif0_lpcg_tx_clk",
> > > > +				     "spdif0_lpcg_gclkw";
> > > > +		power-domains = <&pd IMX_SC_R_SPDIF_0>;
> > > > +	};
> > > > +
> > > > +	spdif1_lpcg: clock-controller@59430000 {
> > > 
> > > That's imx8qm only as well, no?
> > > 
> > > Thanks and best regards,
> > > Alexander
> > > 
> > > > +		compatible = "fsl,imx8qxp-lpcg";
> > > > +		reg = <0x59430000 0x10000>;
> > > > +		#clock-cells = <1>;
> > > > +		clocks = <&acm IMX_ADMA_ACM_SPDIF1_TX_CLK_SEL>,
> > > > +			 <&audio_ipg_clk>;
> > > > +		clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
> > > > +		clock-output-names = "spdif1_lpcg_tx_clk",
> > > > +				     "spdif1_lpcg_gclkw";
> > > > +		power-domains = <&pd IMX_SC_R_SPDIF_1>;
> > > > +		status = "disabled";
> > > > +	};
> > > > +
> > > > +	asrc1_lpcg: clock-controller@59c00000 {
> > > > +		compatible = "fsl,imx8qxp-lpcg";
> > > > +		reg = <0x59c00000 0x10000>;
> > > > +		#clock-cells = <1>;
> > > > +		clocks = <&audio_ipg_clk>;
> > > > +		clock-indices = <IMX_LPCG_CLK_4>;
> > > > +		clock-output-names = "asrc1_lpcg_ipg_clk";
> > > > +		power-domains = <&pd IMX_SC_R_ASRC_1>;
> > > > +	};
> > > > +
> > > > +	sai4_lpcg: clock-controller@59c20000 {
> > > > +		compatible = "fsl,imx8qxp-lpcg";
> > > > +		reg = <0x59c20000 0x10000>;
> > > > +		#clock-cells = <1>;
> > > > +		clocks = <&acm IMX_ADMA_ACM_SAI4_MCLK_SEL>,
> > > > +			 <&audio_ipg_clk>;
> > > > +		clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
> > > > +		clock-output-names = "sai4_lpcg_mclk",
> > > > +				     "sai4_lpcg_ipg_clk";
> > > > +		power-domains = <&pd IMX_SC_R_SAI_4>;
> > > > +	};
> > > > +
> > > > +	sai5_lpcg: clock-controller@59c30000 {
> > > > +		compatible = "fsl,imx8qxp-lpcg";
> > > > +		reg = <0x59c30000 0x10000>;
> > > > +		#clock-cells = <1>;
> > > > +		clocks = <&acm IMX_ADMA_ACM_SAI5_MCLK_SEL>,
> > > > +			 <&audio_ipg_clk>;
> > > > +		clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
> > > > +		clock-output-names = "sai5_lpcg_mclk",
> > > > +				     "sai5_lpcg_ipg_clk";
> > > > +		power-domains = <&pd IMX_SC_R_SAI_5>;
> > > > +	};
> > > > +
> > > > +	amix_lpcg: clock-controller@59c40000 {
> > > > +		compatible = "fsl,imx8qxp-lpcg";
> > > > +		reg = <0x59c40000 0x10000>;
> > > > +		#clock-cells = <1>;
> > > > +		clocks = <&audio_ipg_clk>;
> > > > +		clock-indices = <IMX_LPCG_CLK_0>;
> > > > +		clock-output-names = "amix_lpcg_ipg_clk";
> > > > +		power-domains = <&pd IMX_SC_R_AMIX>;
> > > > +	};
> > > > +
> > > > +	mqs0_lpcg: clock-controller@59c50000 {
> > > > +		compatible = "fsl,imx8qxp-lpcg";
> > > > +		reg = <0x59c50000 0x10000>;
> > > > +		#clock-cells = <1>;
> > > > +		clocks = <&acm IMX_ADMA_ACM_MQS_TX_CLK_SEL>,
> > > > +			 <&audio_ipg_clk>;
> > > > +		clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
> > > > +		clock-output-names = "mqs0_lpcg_mclk",
> > > > +				     "mqs0_lpcg_ipg_clk";
> > > > +		power-domains = <&pd IMX_SC_R_MQS_0>;
> > > > +	};
> > > >  };
> > > > 
> > > > 
> > > 
> > > 
> > 
> > 
> 
> 
> -- 
> TQ-Systems GmbH | M?hlstra?e 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht M?nchen, HRB 105018
> Gesch?ftsf?hrer: Detlef Schneider, R?diger Stahl, Stefan Schneider
> http://www.tq-group.com/
> 
>