Received-SPF: pass (google.com: domain of linux-kernel+bounces-95873-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <439695e8-d94a-4057-84b9-0bd86f7ec84c@intel.com>
Date: Thu, 7 Mar 2024 17:41:53 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/1] ASoC: Intel: catpt: Carefully use PCI bitwise
 constants
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	<alsa-devel@alsa-project.org>, <linux-sound@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Liam Girdwood
	<liam.r.girdwood@linux.intel.com>, Peter Ujfalusi
	<peter.ujfalusi@linux.intel.com>, Bard Liao
	<yung-chuan.liao@linux.intel.com>, Ranjani Sridharan
	<ranjani.sridharan@linux.intel.com>, Kai Vehmanen
	<kai.vehmanen@linux.intel.com>, Mark Brown <broonie@kernel.org>, "Jaroslav
 Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
References: <20240307163734.3852754-1-andriy.shevchenko@linux.intel.com>
Content-Language: en-US
From: Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20240307163734.3852754-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sk9Nb256Y2RtTWYwWWk2T3VxNEs3UTVjTG03TThLYnMxaVVydzNaSDF3aFho?=
 =?utf-8?B?d255RXRvMXdCSEgrcU94cGx2NmFBN0wzTlRTTDUxRzcwSkhxVnFhbFVnNE42?=
 =?utf-8?B?TGlrNVB0cUlRdEdsOXhhSzVUMVlvSGhVR1F1N05SdkRGRlNJREJoVHZndFNz?=
 =?utf-8?B?V09NdkM1cEpjRTRMOGZKZ0tSN0VPNVFrRTU3Vm5BMDZhRWpHQTZMZTNnMTBt?=
 =?utf-8?B?U29vallXYk5vOGVMcjdBcnZWU1ZSRXUyeEJxY0JhUUkrcGxjMnJSRmVMWWhX?=
 =?utf-8?B?Q2UyOUorZ0hOUG1kdkVtdlJLbndJRk1QM0pHMjFuWlR1TTVjSUU2dUl3RmJ6?=
 =?utf-8?B?MW52TVNpMlhOK0VoTFBmNG9SVEpHZ3NxU21BMmg2NmhoUTBnZmdYOURScWhE?=
 =?utf-8?B?bnVNR1BtRGZOREd0K3BBTk00NjBlWXVXYlBYei8vUHdKRklFV295WjV3NHlK?=
 =?utf-8?B?NExkZmRBd2NZZkRnZXhUd3YzOW9JdDNTaklEVmZKamo0RSs4bkpmUGRmdzRQ?=
 =?utf-8?B?UTFtQlRwemc2K0ZGZThST25FWkRsMnNQVTN3SnlURVd6d1JLSlgyZ1dLT1pE?=
 =?utf-8?B?N1ZJNE83VmlyNXdMYnE4YzcrZThoTldUM2tUUSt4akZXU21hcXVjYjVEd2dM?=
 =?utf-8?B?MUFkck52K21ZKzN2YjVhRHNwaTVvMSs0YmMvRnY4dXR0YldUeGl6TldUaktW?=
 =?utf-8?B?ZGY0dGFIVlNleDEwcTErR2RVTmFDOXRyb3dEMFVhSGZzaVVRblNNM3lyM2tx?=
 =?utf-8?B?eGhIY2xXZmREWW5YQndOT0RMWjB0Y29jaThqVWlsTDErOGVVN1JjV3FUbmlQ?=
 =?utf-8?B?UkhXY01qZnErM1d0cGwwTW9BKzhTU0twUmhOK09kbXNyMEVoOEFOQ2R2eXFr?=
 =?utf-8?B?ZFNZUkZ3bzBqbDhDbE9aZ0pvRjlueE5BWDNtbGxXM0dCZTU1VTNRT1Q0VDRU?=
 =?utf-8?B?Ry9CVHJVK0E0SjJuaVhhVEt6cXg5dThrVkZMN3lNelF5STNCcVIzMHZDYUpo?=
 =?utf-8?B?YWp6WVdCL1YveS9rTlJoUElxRmtRZS9LYldIckJlZHdCY2JnZzFuUVhXS2x0?=
 =?utf-8?B?QW4xbHVkNUtMbysrVExhNEFFVVR2TzVHTDNEdDNWNG5lRk8yZUh2MVBNVmdN?=
 =?utf-8?B?UjNwdy82TVV1WkhwUkJtMFp6WHVURzJJMXRWcGtyVm44L1ZocktORUZDUWJw?=
 =?utf-8?B?SDZOTGJpOTJVaXFubWhoaGRUTHkxNFpJd0NwdzhLYkc3eXF3RjBIR1EvQk4x?=
 =?utf-8?B?cEd2dmhGcUNmNTJVTmpYTXQwS2lSak1ndExXeU8vZFNnUWV2WWhSM0s5VTlR?=
 =?utf-8?B?a243RTE2K0UzSWtYN1JwcXZWOTgzdmgzdDV5Q3UzVWZnZk1Jdmxvbm1uRmU3?=
 =?utf-8?B?ZThib3p5YTN0NEdKSHNhTWNCOXJxTkkvWFh3ZHhBdTYzd01Pc3FteFRld0U5?=
 =?utf-8?B?eWlPV1pUcHE5S0pINUhhWG1wQ0VHTkJ1RktWbUhwWXZ3cnpKdTJtY1MyVk1l?=
 =?utf-8?B?RlFQa0xBMzZMdFlENWFSdllwOERPeXF2SmVqcGtaTmFqUWlJdEYzbHAxMDFD?=
 =?utf-8?B?aEFxLys5Y0FoYk9vTit1akVSeEYxOUl1aFhja0YwVWlwVXU1dGhWdVhrek9z?=
 =?utf-8?B?aGJuZzRzZDdRdnN2QTZwczBxNEY2OUNySGlXSUFWeWsvUGRGMjltUGhBeFg0?=
 =?utf-8?B?Mzd1M0tvbEducFFhU0Q0RFhHTG1oanFjSExGa0U2U1hZWkZJd2JkbGRTUTRX?=
 =?utf-8?B?NkFoQVhKZE9XZnkzZUpvQWpVaUsxZHg4MDhVWDNhdmhFd0wyaXlNY1E3TUov?=
 =?utf-8?B?cmFzM0tWcERlQ3hjeUtNRHlmcXU4SE5pWlZacDNCTlBqVVhheW5ZTVZ4L080?=
 =?utf-8?B?R3FoUXp4dkFiYmJVbHQ5VG5hcHRRNXBuT0ZDREpGejQyeHhyQk83aEJDLzZy?=
 =?utf-8?B?NzZVUUdqbWhEbktBT3h1TG9RM1Vxdmc0ckt1YmJPSUxPdFVxTXgzNUovMGYr?=
 =?utf-8?B?WjdOTlMyZGVCZzUvc2M0UW9Kb0JnTTkxbUsyRzErTUFIWnJGVVNiRHlkdk1C?=
 =?utf-8?B?Wm42b250V2MydUJkUlhhQWJZN2ZKWHVVSjg2T1Z6cGNtNStMTkp5b1hDaEtn?=
 =?utf-8?B?SHUxSjdGWjNmUXNqN3hEWDRRSmszeVUyTXdTN1ErS1B2OUw4aEsrbzZYS01I?=
 =?utf-8?B?WFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c3a3734-b374-4790-eb7a-08dc3ec581e8
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 16:41:58.9862
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ka2VIrarRFX6bfJWao0+ax0NcZblT2QT6qyF1hel3jh20no0brg2SkzDbKj7t559hqlfw0gOgSp/3wRBOPBAQ0am4Bxz7PHGmxfy+bsQUnQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7686
X-OriginatorOrg: intel.com

On 2024-03-07 5:37 PM, Andy Shevchenko wrote:
> PM constants for PCI devices are defined with bitwise annotation.
> When used as is, sparse complains about that:
> 
>    .../catpt/dsp.c:390:9: warning: restricted pci_power_t degrades to integer
>    .../catpt/dsp.c:414:9: warning: restricted pci_power_t degrades to integer
> 
> Force them to be u32 in the driver.

Thank you for this input, Andy.

Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   sound/soc/intel/catpt/dsp.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/intel/catpt/dsp.c b/sound/soc/intel/catpt/dsp.c
> index 346bec000306..5454c6d9ab5b 100644
> --- a/sound/soc/intel/catpt/dsp.c
> +++ b/sound/soc/intel/catpt/dsp.c
> @@ -387,7 +387,7 @@ int catpt_dsp_power_down(struct catpt_dev *cdev)
>   	mask = cdev->spec->d3srampgd_bit | cdev->spec->d3pgd_bit;
>   	catpt_updatel_pci(cdev, VDRTCTL0, mask, cdev->spec->d3pgd_bit);
>   
> -	catpt_updatel_pci(cdev, PMCS, PCI_PM_CTRL_STATE_MASK, PCI_D3hot);
> +	catpt_updatel_pci(cdev, PMCS, PCI_PM_CTRL_STATE_MASK, (__force u32)PCI_D3hot);
>   	/* give hw time to drop off */
>   	udelay(50);
>   
> @@ -411,7 +411,7 @@ int catpt_dsp_power_up(struct catpt_dev *cdev)
>   	val = mask & (~CATPT_VDRTCTL2_DTCGE);
>   	catpt_updatel_pci(cdev, VDRTCTL2, mask, val);
>   
> -	catpt_updatel_pci(cdev, PMCS, PCI_PM_CTRL_STATE_MASK, PCI_D0);
> +	catpt_updatel_pci(cdev, PMCS, PCI_PM_CTRL_STATE_MASK, (__force u32)PCI_D0);
>   
>   	/* SRAM power gating none */
>   	mask = cdev->spec->d3srampgd_bit | cdev->spec->d3pgd_bit;