Received-SPF: pass (google.com: domain of linux-kernel+bounces-95877-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 7 Mar 2024 17:44:00 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, 
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v1 4/5] w1: gpio: Remove duplicate NULL checks
Message-ID: <kwn22fq6e4pmaan2x4irvjbykropwvrcz7d547ydrnz3ssehxv@2tr6pvvbrlyz>
References: <20240307143644.3787260-1-andriy.shevchenko@linux.intel.com>
 <20240307143644.3787260-5-andriy.shevchenko@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="htvmaear7d4brykf"
Content-Disposition: inline
In-Reply-To: <20240307143644.3787260-5-andriy.shevchenko@linux.intel.com>


--htvmaear7d4brykf
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 07, 2024 at 04:35:50PM +0200, Andy Shevchenko wrote:
> gpiod_set_value() is NULL-aware, no need to check that in the caller.
>=20
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/w1/masters/w1-gpio.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c
> index 3881f2eaed2f..8fd9fedd8c56 100644
> --- a/drivers/w1/masters/w1-gpio.c
> +++ b/drivers/w1/masters/w1-gpio.c
> @@ -117,8 +117,7 @@ static int w1_gpio_probe(struct platform_device *pdev)
>  	if (err)
>  		return dev_err_probe(dev, err, "w1_add_master device failed\n");
> =20
> -	if (ddata->pullup_gpiod)
> -		gpiod_set_value(ddata->pullup_gpiod, 1);
> +	gpiod_set_value(ddata->pullup_gpiod, 1);
> =20
>  	platform_set_drvdata(pdev, master);
> =20
> @@ -130,8 +129,7 @@ static void w1_gpio_remove(struct platform_device *pd=
ev)
>  	struct w1_bus_master *master =3D platform_get_drvdata(pdev);
>  	struct w1_gpio_ddata *ddata =3D master->data;
> =20
> -	if (ddata->pullup_gpiod)
> -		gpiod_set_value(ddata->pullup_gpiod, 0);
> +	gpiod_set_value(ddata->pullup_gpiod, 0);

This also has the advantage to not have to know that NULL is the dummy
value returned by the gpiod_get_optional() family of functions.

Acked-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--htvmaear7d4brykf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXp7s8ACgkQj4D7WH0S
/k5H2Qf/Xf21WLfMVTOIbH9Ug/45AG+HXZAC5SplkjhLSl7UR1I6smE/wDeLGmOg
UMS6kvrUfU6e20aXejNnt6qUuKFGHys3dccXRpyv1cjSDeNx9zFaitLopqWcl6eZ
V18zE3rXuWBZralnT+CNFEcxGcTvrMBHHIYQRRkz1E8Ln6dY6bKVtYtFIU+npbhp
lkNJPqa0x+gHFpUhIlkbX76/xOFK9pwotmZiW3xqRTlv4DyGnbJbYjO9T3mMxPUd
M3Jm6bZJlFkIkQQVREbF42uxws7SEcsoIPucPTW/9jPJuoSnwKf5LXrD98xcQPla
cJonaj3slqhdrgX7i4KQETu4TRxmKw==
=Wy13
-----END PGP SIGNATURE-----

--htvmaear7d4brykf--