Received-SPF: pass (google.com: domain of linux-kernel+bounces-95904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 7 Mar 2024 18:01:39 +0100
From: Borislav Petkov <bp@alien8.de>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com,
	pbonzini@redhat.com, tglx@linutronix.de, x86@kernel.org,
	jgross@suse.com
Subject: Re: [RFC][PATCH 02/34] x86/xen: Remove early "debug" physical
 address lookups
Message-ID: <20240307170139.GBZeny84YTkJA75V9V@fat_crate.local>
References: <20240222183926.517AFCD2@davehans-spike.ostc.intel.com>
 <20240222183929.E17C1B9C@davehans-spike.ostc.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240222183929.E17C1B9C@davehans-spike.ostc.intel.com>
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 22, 2024 at 10:39:29AM -0800, Dave Hansen wrote:
>=20
> From: Dave Hansen <dave.hansen@linux.intel.com>
>=20
> The __pa() facility is subject to debugging checks if CONFIG_DEBUG_VIRT=
UAL=3Dy.
> One of those debugging checks is whether the physical address is valid
> on the platform.  That information is normally available via CPUID.  Bu=
t
> the __pa() code currently looks it up in 'boot_cpu_data' which is not
> fully set up in early Xen PV boot.
>=20
> The Xen PV code currently tries to get this info with
> get_cpu_address_sizes() which also depends on 'boot_cpu_data' to be at
> least somewhat set up.  The result is that the c->x86_phys_bits gets a
> sane value, but not one that has anything to do with the hardware.  In
> other words, the CONFIG_DEBUG_VIRTUAL checks are performed with what
> amounts to garbage inputs.
>=20
> Garbage checks are worse than no check at all.  Move over to the
> "nodebug" variant to axe the checks.
>=20
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Juergen Gross <jgross@suse.com>
> ---
>=20
>  b/arch/x86/xen/enlighten_pv.c |    2 +-
>  b/arch/x86/xen/mmu_pv.c       |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de>

At least as far as I can follow the Xen boot flow, yap, this makes
sense.

But let's have J=C3=BCrgen confirm first.

Thx.

--=20
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette