Received-SPF: pass (google.com: domain of linux-kernel+bounces-95915-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 7 Mar 2024 09:11:59 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Arun.Ramadoss@microchip.com, andrew@lunn.ch, kernel@pengutronix.de,
 olteanv@gmail.com, davem@davemloft.net, Woojung.Huh@microchip.com,
 linux-kernel@vger.kernel.org, pabeni@redhat.com, f.fainelli@gmail.com,
 edumazet@google.com, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net v2 1/1] net: dsa: microchip: make sure drive
 strength configuration is not lost by soft reset
Message-ID: <20240307091159.07146257@kernel.org>
In-Reply-To: <ZemCysWKkG2BjYiV@pengutronix.de>
References: <20240305064802.2478971-1-o.rempel@pengutronix.de>
	<20240305191457.37419bd4@kernel.org>
	<935b7bd6fe116291ff5f1f5a7a52cdad89e4607a.camel@microchip.com>
	<ZegHO_PqO-3qwFMQ@pengutronix.de>
	<ZemCysWKkG2BjYiV@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 7 Mar 2024 10:03:06 +0100 Oleksij Rempel wrote:
> > > Suggestion: Instead of moving ksz_parse_drive_strength() from end of
> > > file to above, can we move ksz_setup() & ksz_teardown() down. So that
> > > the changes will be minimal. Will that work?  
> > 
> > This will make it hard portable to stable too. As alternative I can
> > offer to use v1 patch for stable and send bigger patch for next after
> > in the next net-next window.  
> 
> Are any changes on my side required?

Not really, just waiting for anyone to speak up, I'll apply v1 soon.
(I can't revive v1 in patchwork because Konstantin's bot will set it
to Superseded, immediately, again :|)